[lake393]

Hello, I've tried looking at the docs and the wiki, as well as a number of searches, and I still have no idea what I'm doing wrong.

I want to make a custom convar called myplugin_verbose_logging, that my plugin will be able to read.

I have the following code:

new g_iVerboseMode = 0;
public OnConfigsExecuted()
{
    new Handle:hCreateVerboseConvar = CreateConVar("myplugin_verbose_logging", "0", "Determines whether to use verbose logging");
    AutoExecConfig(true, "myplugin");
    if(hCreateVerboseConvar != INVALID_HANDLE)
    {
        g_iVerboseMode = GetConVarInt(FindConVar("myplugin_verbose_logging"));
        LogMessage("Verbose mode: %i", g_iVerboseMode);
    }
    else
    {
        LogMessage("Error creating verbose mode convar");
    }
}

I restarted the server and look in /orangebox/cstrike/cfg/sourcemod/ and myplugin.cfg is nowhere to be found, which I believe contradicts the true in the first argument (bool:autoCreate) of AutoExecConfig(), according to the docs page here.

So, I figured that perhaps AutoExecConfig() failed to create the file for some reason, so I created it myself (/orangebox/cstrike/cfg/sourcemod/myplugin.cfg) with the following contents:

myplugin_verbose_logging "1"

I restarted the server and now look in the sourcemod logs in /orangebox/cstrike/addons/sourcemod/logs/ and read what was outputted using LogMessage() in the above code. It says: Verbose mode: 0

There are no errors at all. Its just not reading that file as far as I can tell. It could be because I'm doing it wrong, so if someone could help me make it right, I would appreciate it greatly.

Thank you.

[Cr(+)sshair]

new g_iVerboseMode = 0;
new Handle:hCreateVerboseConvar = INVALID_HANDLE;

public OnPluginStart()
{
    hCreateVerboseConvar = CreateConVar("myplugin_verbose_logging", "0", "Determines whether to use verbose logging");
    AutoExecConfig(true, "myplugin");
    
    if(hCreateVerboseConvar != INVALID_HANDLE)
    {
        g_iVerboseMode = GetConVarInt(hCreateVerboseConvar);
        LogMessage("Verbose mode: %i", g_iVerboseMode);
    }
    else
    {
        SetFailState("Error creating verbose mode convar");
    }
}

[Silvers]

PHP Code:

 if(hCreateVerboseConvar != INVALID_HANDLE)
    {
        g_iVerboseMode = GetConVarInt(hCreateVerboseConvar);
    } 


No need to FindConVar since you already get the handle of the ConVar when creating it.

[Cr(+)sshair]

Originally Posted by Silvers PHP Code:  if(hCreateVerboseConvar != INVALID_HANDLE)     {         g_iVerboseMode = GetConVarInt(hCreateVerboseConvar);     }  No need to FindConVar since you already get the handle of the ConVar when creating it.

Yep!

[Silvers]

I would also recommend moving that code to OnPluginStart (but maybe thats fine there I dunno, majority put into OnPluginStart).

To be honest, I've hardly seen anyone check that the convar is created so I assume all of that is pointless. I've never seen a plugin fail to create a convar.

[Cr(+)sshair]

Originally Posted by Silvers I would also recommend moving that code to OnPluginStart (but maybe thats fine there I dunno, majority put into OnPluginStart). To be honest, I've hardly seen anyone check that the convar is created so I assume all of that is pointless. I've never seen a plugin fail to create a convar.

I totally overlooked that, I've been programming all day and I could have sworn it said OnPluginStart instead of OnConfigs. Wow, really tired. Thanks for pointing that out! Changed that in my post, BRB more coffee =P

[lake393]

Thanks for replying guys. Other than moving it from OnConfigsExecuted() to OnPluginStart(), I don't really see any difference from the original code though.

Originally Posted by Silvers No need to FindConVar since you already get the handle of the ConVar when creating it.

Understood. I'll implement this.

One thing I just noticed... it WORKS when I do sm plugins myplugin reload, but when I restart the server, it doesn't work.

[lake393]

Aaahaa!

The CreateConVar() and AutoExecConfig() parts have to go inside OnPluginStart()

The reading of the convar has to go inside OnConfigsExecuted()

My updated code. Thanks to you both for your replies! I changed my code to implement ideas from both of you.

PHP Code:

// ConVars.
new Handle:g_hCvarVerbose = INVALID_HANDLE;
new bool:g_bCvarVerbose = false;

public OnPluginStart()
{
    // Create ConVars.
    g_hCvarVerbose = CreateConVar("myplugin_verbose_logging", "0", "Determines whether to use verbose logging");
    AutoExecConfig(true, "myplugin");
}

public OnConfigsExecuted()
{
    // Read ConVars.
    g_bCvarVerbose = GetConVarBool(g_hCvarVerbose);
    LogMessage("Verbose mode: %b", g_bCvarVerbose);
}