[Hunter-Digital]

A little example wouldn't hurt.

new hFile = fopen("file.txt", "rt")

if(hFile)
{
    new szRow[24] // make sure you make this bigger for longer lines

    while(fgets(hFile, szRow, charsmax(szRow)))
    {
       // szRow contains current row's text
    }

    fclose(hFile)
}

[fysiks]

Originally Posted by Hunter-Digital A little example wouldn't hurt. new hFile = fopen("file.txt", "rt") if(hFile) { new szRow[24] // make sure you make this bigger for longer lines while(fgets(hFile, szRow, charsmax(szRow))) { // szRow contains current row's text } fclose(hFile) }

And unfortunately that is incorrect. Afaik, fgets() does not return anything. Hence why I say to see my plugin.

[nikhilgupta345]

Yea, i've used opening and reading files before, and bugsy, in another post, told me to do this:

while(!feof(filehandler)
{
fgets(filehandler...) //dont remember other param from the top of my head
}

[mottzi]

hey fysiks,

thanks first for your help.

I tried it, but i the error (Error: Must be a constant expression; assumed zero on line 46) in the RED line;
the error happends in the last code block ( get_random_maps() )

PHP Code:

#include <amxmodx>
#include <amxmisc>

new g_maps_phrases[10][65]
new g_maps_count

public plugin_init()
{
    register_cvar("Bot Apology", "v3.0 by Fysiks", FCVAR_SERVER|FCVAR_SPONLY)
    register_event("DeathMsg", "player_death", "a","1>0")

    new maps[64]
    get_configsdir(maps, sizeof(maps) - 1)
    add(maps, sizeof(maps) - 1, "/mapvote.ini")
    
    if( !file_exists(maps) )
    {
        copy(g_maps_phrases[0], 65, "zm_dust2_new")
        copy(g_maps_phrases[1], 65, "zm_army_tn3_beta")
        g_maps_count = 2
        return
    }
    
    new f = fopen(maps, "rt")
    
    new data[65]
    g_maps_count = 0

    while( !feof(f) && g_maps_count < 65) 
    { 
        fgets(f, data, sizeof(data) - 1)
         
        trim(data)
        if( !data[0] || data[0] == ';' || data[0] == '/' && data[1] == '/' ) continue;
        
        copy(g_maps_phrases[g_maps_count], 65, data)
        g_maps_count++
    }
    
    fclose(f)
}

public get_random_maps(id)
{
    new random1[] = g_maps_phrases[random(g_maps_count)]  // Here <---
    client_print(id, print_chat, "%s", random1)
} 


can you tell me why?

[Hunter-Digital]

Originally Posted by fysiks And unfortunately that is incorrect. Afaik, fgets() does not return anything. Hence why I say to see my plugin.

It returns the number of characters read on that line (including new line character, use trim() to get rid of), no point in using an extra function ( feof() ) for just that.

[nikhilgupta345]

Originally Posted by mottzi hey fysiks, thanks first for your help. I tried it, but i the error (Error: Must be a constant expression; assumed zero on line 46) in the RED line; the error happends in the last code block ( get_random_maps() ) PHP Code: #include <amxmodx> #include <amxmisc> new g_maps_phrases[10][65] new g_maps_count public plugin_init() {     register_cvar("Bot Apology", "v3.0 by Fysiks", FCVAR_SERVER|FCVAR_SPONLY)     register_event("DeathMsg", "player_death", "a","1>0")     new maps[64]     get_configsdir(maps, sizeof(maps) - 1)     add(maps, sizeof(maps) - 1, "/mapvote.ini")          if( !file_exists(maps) )     {         copy(g_maps_phrases[0], 65, "zm_dust2_new")         copy(g_maps_phrases[1], 65, "zm_army_tn3_beta")         g_maps_count = 2         return     }          new f = fopen(maps, "rt")          new data[65]     g_maps_count = 0     while( !feof(f) && g_maps_count < 65)      {          fgets(f, data, sizeof(data) - 1)                   trim(data)         if( !data[0] || data[0] == ';' || data[0] == '/' && data[1] == '/' ) continue;                  copy(g_maps_phrases[g_maps_count], 65, data)         g_maps_count++     }          fclose(f) } public get_random_maps(id) {     new random1[] = g_maps_phrases[random(g_maps_count)]  // Here <---     client_print(id, print_chat, "%s", random1) }  can you tell me why?

If I'm not mistaken this is the problem, or part of it.

new f = fopen(maps, "rt")

Think you're making f = the directory, not the file. Don't you use fopen to open the file, and then fgets to read it? maybe make a const in the beginning to the location of the file or osmething.

[tm.]

You should try something like this for that function:

PHP Code:

public get_random_maps(id)
{
    client_print(id, print_chat, g_maps_phrases[random(g_maps_count)])
} 


Also:

PHP Code:

copy(g_maps_phrases[g_maps_count], 65, data) 


->

PHP Code:

copy(g_maps_phrases[g_maps_count], 64, data) 


And everywhere else you use copy.

[fysiks]

Originally Posted by Hunter-Digital It returns the number of characters read on that line (including new line character, use trim() to get rid of), no point in using an extra function ( feof() ) for just that.

I would be nice if file.inc was documented accurately. So, there's no problem with fgets() at the end of the file? I'm assuming it just returns 0.

Originally Posted by tm. PHP Code: copy(g_maps_phrases[g_maps_count], 64, data)  And everywhere else you use copy.

Just use charsmax(g_maps_phrases) for string lengths. That way if you change array dimensions you don't have to look through and change every hardcoded constant that is based on the dimension of the array.

[Vechta]

Can you give me an example how to check if name already are in the file if loaded?

Name in file looks like this:

"Player"
"Player name 2"
"Player 3"
"Test"

[fysiks]

Originally Posted by Vechta Can you give me an example how to check if name already are in the file if loaded? Name in file looks like this: "Player" "Player name 2" "Player 3" "Test"

Here is one by Bugsy using SteamIDs.