[Tylerst]

I've been working on updating my Infinite Ammo Plugin, and have been working with sdktools a bit.

I was wondering which of these would be better as far as optimization.

Example 1(SDKCall):

new Handle:hGiveAmmo = INVALID_HANDLE;

public OnPluginStart()
{
	new Handle:hFile = LoadGameConfigFile("gamedatafile");
	if(hFile == INVALID_HANDLE) SetFailState("Gamedata file not found: gamedatafile");
	StartPrepSDKCall(SDKCall_Player);
	PrepSDKCall_AddParameter(SDKType_PlainOldData, SDKPass_Plain);
	PrepSDKCall_AddParameter(SDKType_PlainOldData, SDKPass_Plain);
	PrepSDKCall_AddParameter(SDKType_Bool, SDKPass_Plain);
	PrepSDKCall_SetFromConf(hFile, SDKConf_Virtual, "GiveAmmo");
	hGiveAmmo = EndPrepSDKCall();
	CloseHandle(hFile);
}

SDKGiveAmmo(client, iAmmo, iWeaponSlot, bool:bDisableSound)
{
	SDKCall(hGiveAmmo, client, iAmmo, iWeaponSlot+1, bDisableSound);
}

Example 2(Datamaps/Netprops):

new iOffset_Ammo;

public OnPluginStart()
{
	iOffset_Ammo = FindSendPropInfo("CTFPlayer", "m_iAmmo");
}

SetAmmo(client, iWeapon, iAmmo)
{
	new iAmmoType = GetEntProp(iWeapon, Prop_Send, "m_iPrimaryAmmoType")*4;
	SetEntData(client, iAmmoType+iOffset_Ammo, iAmmo, 4, true);	
}

I'm guessing the prop version would be slower due to getting ammotype every time, however I don't know how computationally expensive sdkcalls are.
Also, what if I specified ammotype myself, leaving only the SetEntData?

[Zephyrus]

Originally Posted by Tylerst I've been working on updating my Infinite Ammo Plugin, and have been working with sdktools a bit. I was wondering which of these would be better as far as optimization. Example 1(SDKCall): new Handle:hGiveAmmo = INVALID_HANDLE; public OnPluginStart() { new Handle:hFile = LoadGameConfigFile("gamedatafile"); if(hFile == INVALID_HANDLE) SetFailState("Gamedata file not found: gamedatafile"); StartPrepSDKCall(SDKCall_Player); PrepSDKCall_AddParameter(SDKType_PlainOldData, SDKPass_Plain); PrepSDKCall_AddParameter(SDKType_PlainOldData, SDKPass_Plain); PrepSDKCall_AddParameter(SDKType_Bool, SDKPass_Plain); PrepSDKCall_SetFromConf(hFile, SDKConf_Virtual, "GiveAmmo"); hGiveAmmo = EndPrepSDKCall(); CloseHandle(hFile); } SDKGiveAmmo(client, iAmmo, iWeaponSlot, bool:bDisableSound) { SDKCall(hGiveAmmo, client, iAmmo, iWeaponSlot+1, bDisableSound); } Example 2(Datamaps/Netprops): new iOffset_Ammo; public OnPluginStart() { iOffset_Ammo = FindSendPropInfo("CTFPlayer", "m_iAmmo"); } SetAmmo(client, iWeapon, iAmmo) { new iAmmoType = GetEntProp(iWeapon, Prop_Send, "m_iPrimaryAmmoType")*4; SetEntData(client, iAmmoType+iOffset_Ammo, iAmmo, 4, true); } I'm guessing the prop version would be slower due to getting ammotype every time, however I don't know how computationally expensive sdkcalls are. Also, what if I specified ammotype myself, leaving only the SetEntData?

imho giveammo just sets the netprop as well

[Peace-Maker]

giveammo obeys the max amount of ammo for that ammotype, which isn't possible easily with just the netprops.
You shouldn't worry about optimization here. I'd expect sdkcalls to be slightly "slower" than setting netprops, but you wouldn't really notice the difference.

[11530]

Try compiling two versions and use the Profiler to test the speed of each.

[Tylerst]

Originally Posted by 11530 Try compiling two versions and use the Profiler to test the speed of each.

Wasn't aware of that tool, thanks.
That'll save me a lot of time, not having to ask.

[psychonic]

Use whatever is most readable and works. Don't prematurely optimize unless you know or suspect that you have a slowdown.