View Single Post
DarthNinja
SourceMod Plugin Approver
Join Date: Mar 2009
Location: PreThinkHook()
Old 11-06-2012 , 03:41   Re: [TF2]Merasmus Timer
Reply With Quote #5

Here are some issues that prevent this from being approved:
  • You declare a number of global variables that are only used in one function.
  • "Timer" is a reserved word; Don't use it as a variable or function name.
  • Your client count is currently hardcoded to 10. However the required number of players can be changed with the cvar tf_merasmus_min_player_count. Also I believe only players on teams are counted.
  • You should use !IsFakeClient instead of !IsClientReplay(i) && !IsClientSourceTV(i).
  • The plugin currently checks the values of tf_merasmus_spawn_interval and tf_merasmus_spawn_interval_variation more often than needed. Use HookConVarChange to cut down on updates and make them happen immediately.
__________________
DarthNinja is offline