[Newbie1992]

Hi guys,

I found a weird issue in vsh, few mins ago. In mid-round the plugin stopped working (without server crash) the gamemode changed to default arena red / blu
This was the first time that this happend in more than 4 months since the server is online. After a server restart the plugin does work fine.

I found this errors in the sourcemod logs folder:

L 01/25/2015 - 20:09:51: [SM] Native "SetEntProp" reported: Entity 10 (10) is invalid
L 01/25/2015 - 20:09:51: [SM] Displaying call stack trace for plugin "saxtonhale.smx":
L 01/25/2015 - 20:09:51: [SM]   [0]  Line 4909, C:\Users\user\Desktop\sm\addons\sourcemod\scripting\saxtonhale.sp::HHHTeleTimer()
L 01/25/2015 - 20:10:01: [SM] Native "KillTimer" reported: Invalid timer handle 6a6e02d9 (error 1)
L 01/25/2015 - 20:10:01: [SM] Displaying call stack trace for plugin "saxtonhale.smx":
L 01/25/2015 - 20:10:01: [SM]   [0]  Line 1786, C:\Users\user\Desktop\sm\addons\sourcemod\scripting\saxtonhale.sp::event_round_start()
L 01/25/2015 - 20:10:46: [SM] Native "KillTimer" reported: Invalid timer handle 6a6e02d9 (error 1)

Code from the plugin:

    if (hHHHTeleTimer != INVALID_HANDLE)
    {
        KillTimer(hHHHTeleTimer);
        hHHHTeleTimer = INVALID_HANDLE;
    }

public Action:HHHTeleTimer(Handle:timer)
{
    SetEntProp(Hale, Prop_Send, "m_CollisionGroup", 5); //Fix HHH's clipping.
    hHHHTeleTimer = INVALID_HANDLE;
}

Anyone got a idea how to fix this, and why this happend?

Best regards,
Newbie1992

[rswallen]

Sequence of events that could lead to this:

1. Hale disconnected.
2. Timer fires, throws an error (preventing the variable from being cleared).
3. During round start, the plugin tries to kill the timer.
4. Timer is now invalid, error is thrown (causing plugin to stop setting up a VSH round).

FIX: during the timer, check the hale is still a valid client before changing netprops

[WildCard65]

Originally Posted by rswallen Sequence of events that could lead to this: Hale disconnected. Timer fires, throws an error (preventing the variable from being cleared). During round start, the plugin tries to kill the timer. Timer is now invalid, error is thrown (causing plugin to stop setting up a VSH round). FIX: during the timer, check the hale is still a valid client before changing netprops

Fixed in master and develop branches now.

[Newbie1992]

Originally Posted by WildCard65 Fixed in master and develop branches now.

Thanks for the fix, hopefully works now.

Best regards,
Newbie1992

[Powerlord]

Originally Posted by WildCard65 Fixed in master and develop branches now.

...for VSH? Is this a surprise for ChData?

Also... don't pass client indexes to timers! Always use userids or serials!

[Chdata]

This one timer didn't pass /anything/ because it uses the Hale global variable.

Also, newbie's vsh particularly is a little out of sync with the latest version. He was missing code to set the handle to INVALID_HANDLE in OnMapStart.

Also, looking at the code, there's no reason for a global handle to be saved. I probably did that before I knew more about timers. Right now it's more or less being saved for nothing.

Infact... it's passing the timer flags as extra data instead of flags

CreateTimer(bEnableSuperDuperJump ? 4.0:2.0, HHHTeleTimer, TIMER_FLAG_NO_MAPCHANGE);

CreateTimer(bEnableSuperDuperJump ? 4.0:2.0, HHHTeleTimer, _, TIMER_FLAG_NO_MAPCHANGE);


* Removed in latest commit.

Also I still have to release 1.52. I suppose I'll work on the telespawn thing then do that... when I have more time.