[Dores]

Originally Posted by Ðiego Right, some bots have joined now. I wasn't watching at the time, but I *think* the human players dropped below 15?

So is it working or not? I need a final answer.

[VulturEMaN]

If I'm not mistaken, just from looking over the code quickly, it seems that it only needs some parenthesis in the right places to make sure the order of operations is right....

maybe (for the first if)

        if((get_pcvar_num(p_bot_quota) && g_playersNum) >= (get_pcvar_num(p_kickat) - get_pcvar_num(p_maxbots) + 1))

and (for the 2nd if)

        if((get_pcvar_num(p_bot_quota) < get_pcvar_num(p_maxbots)) && (g_playersNum < get_pcvar_num(p_kickat) - get_pcvar_num(p_maxbots) + 1))

but once again, i'm just a garden variety n00b ;)

I've got that code running on my server right now, but we'll never get that many normal human players for a while....

[Dores]

@VulturEMaN:

A. It doesn't matter, the calculations will still work as should even without brackets, it's only a matter of optimization(which I guess I lack ).

B. You've misunderstood this part:

PHP Code:

if(get_pcvar_num(p_bot_quota) && g_playersNum >= get_pcvar_num(p_kickat) - get_pcvar_num(p_maxbots) + 1) 


It checks the value of the cvar that is held by p_bot_quota, and make sure it's positive. Then separately by AND(&&), it makes sure that g_playersNum's value is bigger or equal to the other value.

C. If you don't have a big amount of players in your server, change abk_players to a more appropriate value, according to the average amount of players in your server usually.

[vato loco [GE-S]]

is it working now ???

[Ðiego]

It's working for the most part, yes. The bots don't rejoin until the players drop below 15 (or the map changes, naturally), but that isn't a bad thing in any way.

Thank you very much for the most excellent coding


Ð

[Dores]

Fixed.

PHP Code:

#include <amxmodx>

const TASK_ID = 5000;

new p_maxbots;
new p_kickat;
new p_bot_quota;
new g_playersNum;

public plugin_init()
{
    register_plugin("Auto Bot(s) Kick", "1.1", "Dores");
    
    p_maxbots = register_cvar("abk_max", "6");
    p_kickat = register_cvar("abk_players", "20");
    
    p_bot_quota = get_cvar_pointer("bot_quota");
}

public client_putinserver(id) 
{
    if(!is_user_bot(id))
    {
        g_playersNum++;
        
        if(get_pcvar_num(p_bot_quota) && g_playersNum >= get_pcvar_num(p_kickat) - get_pcvar_num(p_maxbots) + 1)
            set_pcvar_num(p_bot_quota, get_pcvar_num(p_bot_quota) - 1);
    }
}
public client_disconnect(id)
{
    if(!is_user_bot(id))
    {
        g_playersNum--;
        
        if(get_pcvar_num(p_bot_quota) < get_pcvar_num(p_maxbots) && g_playersNum < get_pcvar_num(p_kickat))
            set_pcvar_num(p_bot_quota, get_pcvar_num(p_bot_quota) + 1);
    }
}

public plugin_pause()
{
    remove_task(TASK_ID);
    
    g_playersNum = 0;
}

public server_changelevel(map[])
{
    remove_task(TASK_ID);
    
    g_playersNum = 0;
} 


[VulturEMaN]

lol thanks dores....you're truly epic

[Ðiego]

Very much thanks again


Ð

[VulturEMaN]

It seems to mess up on map change. I set the maxbots at 6, and the kickat at 12, and something went awry.

It could have also been messed up from someone manually setting bot_quota to 0....i am unsure...

[Dores]

Yes, bot_quota shouldn't be changed for the code to work properly.
But what happens?