Quote:
Originally Posted by Jamster
whoa damn, what version are you running and what game?
|
At a glance it looks like you should close handles much more frequently than you currently are. In most instances you are running a for-loop or while-loop with an OpenDirectory function inside, yet only closing the handle on the final iteration.
I've edited your CleanServer function, removing any superfluous code for this example, leaving only while/for loops, OpenDirectories and any comments on where you should CloseHandle (and set to INVALID_HANDLE).
As a small addendum you can safely change all instances of Format in your original code to FormatEx for a little extra speed.
PHP Code:
CleanServer(const type)
{
if (type == RPY)
{
for (new i=0;i<=2;i++)
{
if (DirExists(dir))
{
h_dir = OpenDirectory(dir);
//Should CloseHandle(h_dir) and h_dir = INVALID_HANDLE here
}
}
}
else if (type == SPR)
{
if (DirExists(dir))
{
h_dir = OpenDirectory(dir);
//Should CloseHandle(h_dir) and h_dir = INVALID_HANDLE here
}
if (DirExists(dir))
{
h_dir = OpenDirectory(dir);
while (ReadDirEntry(h_dir, subdir, sizeof(subdir)))
{
if (DirExists(fullpath))
{
h_subdir = OpenDirectory(fullpath);
//Should CloseHandle(h_subdir) and h_subdir = INVALID_HANDLE here
}
}
if (h_subdir != INVALID_HANDLE)
CloseHandle(h_subdir); //Remove this
//I'd recommend closing h_dir here, instead of at the end of the function.
//CloseHandle(h_dir) and h_dir = INVALID_HANDLE here
}
}
else
{
if (DirExists(dir))
{
h_dir = OpenDirectory(dir);
//I'd recommend closing h_dir here, instead of at the end of the function.
//CloseHandle(h_dir) and h_dir = INVALID_HANDLE here
}
}
if (h_dir != INVALID_HANDLE)
CloseHandle(h_dir); //Remove if you placed all other recommended CloseHandles
return true;
}
__________________
9: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "servercleanup.smx")
Linear Mode
