[GoRRageBoy]

So I've given up on finishing my Talk Like Bill plugin (it would've changed a Soldier wearing Bill's Hat's voice clips to those of Bill from Left 4 Dead)

Instead, I've decided to use the coding I already did to make a different plugin.

However, I've hit a brick wall in the coding and I require a little assistance.

Here's where I got stuck:

PHP Code:

public Action:Event_HorsemannKilled(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if (IsValidClient(client))
    {
        new TFClassType:class = TF2_GetPlayerClass(client);
        if (class == TFClass_Soldier)
        {
            EmitSoundToAll(SOLDIER_HHHKILLED[GetRandomInt(0, 3)], client, _, _, _, 1.0);
        }
    }
} 


I'm going to code in a separate EmitSoundToAll for all 9 classes. But I don't know whether to do it like this:

PHP Code:

public Action:Event_HorsemannKilled(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if (IsValidClient(client))
    {
        new TFClassType:class = TF2_GetPlayerClass(client);
        if (class == TFClass_Soldier)
        {
            EmitSoundToAll(SOLDIER_HHHKILLED[GetRandomInt(0, 3)], client, _, _, _, 1.0);
        }
        
        if (class == TFClass_Scout)
        {
            EmitSoundToAll(SCOUT_HHHKILLED[GetRandomInt(0, 3)], client, _, _, _, 1.0);
        }
    }
} 


Or like this:

PHP Code:

public Action:Event_HorsemannKilled(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if (IsValidClient(client))
    {
        new TFClassType:class = TF2_GetPlayerClass(client);
        if (class == TFClass_Soldier)
        {
            EmitSoundToAll(SOLDIER_HHHKILLED[GetRandomInt(0, 3)], client, _, _, _, 1.0);
        }
        
        else if (class == TFClass_Scout)
        {
            EmitSoundToAll(SCOUT_HHHKILLED[GetRandomInt(0, 3)], client, _, _, _, 1.0);
        }
    }
} 


Basically, when the event happens, I want the emitsoundtoall function for each class to trigger on every player in the server, and I'm confused about if I'm supposed to use "if" or "else if" for each subsequent "class == TFClass_<class>" thing.

Then again, I'm probably and idiot and overthinking this, and I should just use "if"....but I don't know.

[napalm00]

I'd use a switch

PHP Code:

switch(class)
{
case TFClass_Soldier:
{
//do stuff for solly
}
case TFClass_Scout:
{
//do stuff for scout
}
} 


Can't really indentate it with the phone, I think you got the idea btw.
If you use the "if" example, the game will check ALL the cases and see what's false and what's true.
With the "else if" example, it will skip the false ones and move directly onto the true ones.
It's really all about efficiency, I suggest the "else if" or, better, the switch (much clearer to read).
Hope I helped, correct me if I'm wrong

[GoRRageBoy]

Originally Posted by napalm00 I'd use a switch PHP Code: switch(class) { case TFClass_Soldier: { //do stuff for solly } case TFClass_Scout: { //do stuff for scout } }  Can't really indentate it with the phone, I think you got the idea btw. If you use the "if" example, the game will check ALL the cases and see what's false and what's true. With the "else if" example, it will skip the false ones and move directly onto the true ones. It's really all about efficiency, I suggest the "else if" or, better, the switch (much clearer to read). Hope I helped, correct me if I'm wrong

Why did I not think about that before? Splendid idea!

[hleV]

Use else if. If the first if met its conditions, the else if afterwards won't be checked.

[GoRRageBoy]

Originally Posted by hleV Use else if. If the first if met its conditions, the else if afterwards won't be checked.

I don't want the plugin to not check the next thing.

When the event happens, in this case, the Horsemann spawning, I want all 9 classes to play their respective "HHHSPAWNED" voice clips.

I just made a test version using the switch method, and spawned the Horsemann with the plugin, but the voice clips didn't play.

I think I have to test it on Mann Manor with an actual Horsemann spawning event.

[napalm00]

Originally Posted by GoRRageBoy When the event happens, in this case, the Horsemann spawning, I want all 9 classes to play their respective "HHHSPAWNED" voice clips.

I believe the event you have there is fired when the HHH is killed o0

[DarthNinja]

In this case you would use a switch, but to answer if vs else if:
A player can't be both a scout and a soldier, so:

PHP Code:

if (x == true)
{
code;
}
else if (x == false) // x can't be both true and false, so we use "else"
{
code;
} 


[GoRRageBoy]

Originally Posted by DarthNinja In this case you would use a switch, but to answer if vs else if: A player can't be both a scout and a soldier, so: PHP Code: if (x == true) { code; } else if (x == false) // x can't be both true and false, so we use "else" { code; }

So an else if for each class it is!

[DarthNinja]

Originally Posted by GoRRageBoy So an else if for each class it is!

No.

Originally Posted by DarthNinja In this case you would use a switch

[Powerlord]

Originally Posted by DarthNinja No.

I could have sworn there was somewhere on the Wiki that told you to use switch instead of if/else if, but I can't seem to find it at the moment.