[Kigen]

Is this magical MaxClients variable an actual variable or a function call?

Hopefully, it functions like a variable for performance reasons. I wanna know because I'm updating some plugins that use GetMaxClients() and was figuring if MaxClients is a variable I can kill having to store GetMaxClients()'s value and just use MaxClients in the for loops.

[bl4nk]

MaxClients is a variable that is updated on map change.

[BAILOPAN]

Yes, MaxClients was introduced for two reasons:

1) To automatically propagate GetMaxClients() changes without any extra code needed. This can happen on map change but that's not guaranteed - it can happen at any time in theory.

2) Performance. It's around 27 instructions to enter GetMaxClients just from the VM overhead of "context" switching from the VM state to the machine state. As a variable it's about 2-3 instructions. (note: overhead of entering natives is usually drowned out by the gain in perf from a C++ optimizer on natives, something proven by benchmarks, but in cases like this it's excessive)

These are directly related since people were inappropriately caching the value to get performance - now that shouldn't be an issue.