[taheri6]

All, Im getting this error - I dont know what code in specific does it.

FATAL ERROR (shutting down): MSG_ONE or MSG_ONE_UNRELIABLE with no target entity

I have this piece of code that I use to determine if its a valid client

PHP Code:

public Util_Is_Valid_Player( id )
{
    if( 0 == id || id > MAX_PLAYERS )
    {
        return false;
    }

    if( is_user_connected( id ) && ( pev( id, pev_flags ) & FL_CLIENT ) )
    {
        return true;
    }

    return false;
}

public Util_Should_Msg_Client( id )
{
    if( Util_Is_Valid_Player(id) && !is_user_bot( id ) )
    {
        return true;
    }

    return false;
} 


So I use if( Util_Should_Msg_Client( id ) ) arround every MSG_ONE I have, I dont use MSG_ONE_UNRELIABLE specifically, always MSG_ONE

And yet I have had a crash or two happen becuase of that error.

Is there something else I need to be checking, or something I am doing wrong?

[Drak]

You messed up the Message Parms.

[ConnorMcLeod]

Also you could improve the code like this (i guess):

PHP Code:

new g_iMaxPlayers;

public plugin_cfg() {
    g_iMaxPlayers = get_maxplayers();
}

bool:Util_Is_Valid_Player( id )
{
    if( id < 1 || id > g_iMaxPlayers )
    {
        return false;
    }

    if( is_user_connected( id ) && ( pev( id, pev_flags ) & FL_CLIENT ) )
    {
        return true;
    }

    return false;
}

bool:Util_Should_Msg_Client( id )
{
    if( Util_Is_Valid_Player(id) && !is_user_bot( id ) )
    {
        return true;
    }

    return false;
} 


Why don't you use MSG_ONE_UNRELIABLE ?

May be post the whole code could help.

[taheri6]

Well the code is about 450k worth, so its pretty big

Now I understand that there's a lot missing but I cant post everything as it would be a huge post and would be messy as heck.

[slypanther]

Post sma and peaple would help

Remeber there are some Sma's that are 1100 lines long

[ConnorMcLeod]

Post the whole code.

[hlstriker]

Originally Posted by taheri6 Well the code is about 450k worth, so its pretty big

So it's around 15,000 lines of code?

[taheri6]

It is about that yeah, its a huge plugin that does a lot - its also broken up into about 15 include files so easier readability and editing

In practice, would it be "better" to use MSG_ONE_UNRELIABLE instead of MSG_ONE ?

The error message leads me to beleive that regardless of which one I chose it would have crashed anyways due to an invalid entity.

But if I wrap the Util_Is_Valid_Player( id ) call arround each

PHP Code:

if( Util_Is_Valid_Player( id ) )
{
   message_begin ( ..blah... );
   ..blah... 
   message_end ()
} 


Wouldnt that check to make sure that its a valid client based on the entity flags, or am I misunderstanding how that works?

[hostingguy]

Im with you but I think we should wait for a master to respond

[Komsa]

Help! Who has understood with the given problem? Tell in what the reason?