[Scag]

So I have a large methodmap which inherits from StringMap. Getting and setting properties are fairly copy-paste but I wanted to make it stupidly simpler with macros.
I got these:

PHP Code:

#define IntGet(%1)         public get()\
{\
    int i; this.GetValue(%1, i);\
    return i;\
}
#define IntSet(%1)         public set( const int i )\
{\
    this.SetValue(%1, i);\
}
// And so on with bool and float 


Moving to a property...

PHP Code:

property int iRoundState
{
    IntGet("iRoundState")
    IntSet("iRoundState")
} 


Which compiles just fine, but I wanna make it even simpler with just a single macro. So I tried this:

PHP Code:

#define DoInt(%1)         IntGet(%1)IntSet(%1) 


Which spews "error 155: expected newline, but found 'public'" when used. So after a bunch of variations of the such I was never able to get it to work. Is this "one line wonder" even possible?

And yes I know a lot of people hate macros

[Fyren]

Your problem is somewhere else. This complete example code compiles without error:

PHP Code:

#include <sourcemod>

#define IntGet(%1)         public get()\
{\
            int i; this.GetValue(%1, i);\
            return i;\
}
#define IntSet(%1)         public set( const int i )\
{\
            this.SetValue(%1, i);\
}

#define DoInt(%1)         IntGet(%1)IntSet(%1)

methodmap Foo < StringMap
{
        public Foo() { return view_as<Foo>(new StringMap()); }
        property int iRoundState
        {
                IntGet("iRoundState")
                IntSet("iRoundState")
        }
}

public void OnPluginStart() {
        Foo f = new Foo();
        f.iRoundState = 1;
} 


You can use the -l compiler option to get the preprocessed output without actually compiling. You can use it to see what your macros are actually outputting. It is unfortunately annoying since it'll have substituted all the included files.

[Scag]

Whoops, I guess I didn't explain myself very well with how I used the latter macro. Bouncing off of the code snippet you placed down:

PHP Code:

#include <sourcemod>

#define IntGet(%1)         public get()\
{\
            int i; this.GetValue(%1, i);\
            return i;\
}
#define IntSet(%1)         public set( const int i )\
{\
            this.SetValue(%1, i);\
}

#define DoInt(%1)         IntGet(%1)IntSet(%1)

methodmap Foo < StringMap
{
        public Foo() { return view_as<Foo>(new StringMap()); }
        property int iRoundState
        {
                DoInt("iRoundState") // Error line
        }
}

public void OnPluginStart() {
        Foo f = new Foo();
        f.iRoundState = 1;
} 


Throwing this code snippet down...

PHP Code:

public void function1() { /*Code*/ } public void function2() { /*Code*/ } // Errors

void function1() { /*Code*/ } void function2() { /*Code*/ } // Does not error 


My guess is that the compiler doesn't like more than 1 public function on the same line.

[SZOKOZ]

Didn't know you could make macros like that... Defining a function as a macro and calling it by the macro. Doesn't make sense to me lol. Could you help me understand please.

[Fyren]

It looks like it's specific to methodmaps. You can't have non-public functions inside one and closing braces (for properties, functions, and the methodmap itself) have to have a newline after them. Free functions can be declared on the same line whether public or not.