[hellmonja]

Hi everyone. This has been a project of mine for more than a year now and I humbly seek help optimizing it. It adds an extra weapon in CS 1.6, no surprise there. But I wanted it to behave like a real CS weapon in every way. Now that it's working smoothly in-game I wanted to get it as optimized as possible, something I'm not good at. It's a mish-mash of code I've found around the net so that's why its pretty non-efficient so I hope you could help me.

Please bear with me. I'm not a very good coder and I might ask you to explain things further. For that I apologize in advance.

I think the first order of business is getting rid of fakemeta_util. I know, f*ck me, right? But there's a ton of code relying on that module and I have no idea what to replace some if them with...

[edon1337]

Moving on from fakemeta_util is like the best and easiest choice.

FM_UTIL                      |   FUN          |     ENGINE             |      FAKEMETA                                          |    HAMSANWICH     
                             |                |                        |                                                        |    
fm_give_item                 |   give_item    |     \                  |      \                                                 |    ExecuteHam(Ham_Item_AddToPlayer..)
fm_get_user_weapon_entity    |   \            |      \                 |       \                                                 |    get_pdata_cbase [OFFSET: m_pActiveItem]  
fm_find_ent_by_owner         |    \           |     find_ent_by_owner  |      engfunc(EngFunc_FindEntityByString..) + pev_owner |     \

There's obviously a way to convert give_item to engine and Fakemeta but it's harder.

[hellmonja]

Did I do it right?

From:

PHP Code:

static weapon; weapon = fm_find_ent_by_owner(-1, weapon_bizon, entity) 


To:

PHP Code:

static weapon;
new ent, strtype, classname;
weapon = engfunc(EngFunc_FindEntityByString, ent, strtype, classname) 


From:

PHP Code:

static ent; ent = fm_get_user_weapon_entity(id, CSW_BIZON) 


To:

PHP Code:

const m_pActiveItem = 373;
...
static ent;
ent = get_pdata_cbase(id, m_pActiveItem); 


give_item is pretty easy so I didn't include it...

[edon1337]

Originally Posted by hellmonja PHP Code: static weapon; weapon = fm_find_ent_by_owner(-1, weapon_bizon, entity)  To: PHP Code: static weapon; new ent, strtype, classname; weapon = engfunc(EngFunc_FindEntityByString, ent, strtype, classname)  From:

I'd suggest engine but anyways.

engfunc(EngFunc_FindEntityByString, entity, "classname", weapon_bizon)

[hellmonja]

Thanks. So that's why it can't change the world model. Would engine be a lot better? Someone told me the fewer modules I use the better.

Hmm, when I switch weapons thirdperson, the Bizon player model doesn't go away. Like if I switch to my knife my player holds both knife and bizon. Same goes with pistols etc...

[edon1337]

Originally Posted by hellmonja Thanks. So that's why it can't change the world model. Would engine be a lot better? Someone told me the fewer modules I use the better.

No difference in performance, you tell me, would you rather type

PHP Code:

engfunc(EngFunc_FindEntityByString, entity, "classname", weapon_bizon) 


instead of just

PHP Code:

find_ent_by_class 


Originally Posted by hellmonja Hmm, when I switch weapons thirdperson, the Bizon player model doesn't go away. Like if I switch to my knife my player holds both knife and bizon. Same goes with pistols etc...

It's because m_pActiveItem checks only the weapon you're using. Try with find_ent_by_owner.

[hellmonja]

Hey it works! Player model is now in order. So I guess I'll be using engine as well.

Will come back after dinner. There's still a couple of codes that needs replacing in order for me to get rid of fakemeta_util. All of them with prefix "xs_"...

[edon1337]

Originally Posted by hellmonja Hey it works! Player model is now in order. So I guess I'll be using engine as well. Will come back after dinner. There's still a couple of codes that needs replacing in order for me to get rid of fakemeta_util. All of them with prefix "xs_"...

xs_ natives are from xs module not fakemeta_util.

[hellmonja]

Originally Posted by edon1337 xs_ natives are from xs module not fakemeta_util.

Waw. That was stupid of me. Thanks! I removed fakemeta_util and did a quick test and it works fine.

I guess the next stage is the flow of the plugin itself.

Just curious: What's up with fakemeta_util? Why does it have some functions of other modules and why is it avoided like the plague?...

[edon1337]

Originally Posted by hellmonja Just curious: What's up with fakemeta_util? Why does it have some functions of other modules and why is it avoided like the plague?...

Because it uses the existing natives to do the same thing just in a fakemeta way. So you're basically using 2 natives instead of 1.