Raised This Month: $ Target: $400
 0% 

SDKHooks_TakeDamage BUG?


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
asherkin
SourceMod Developer
Join Date: Aug 2009
Location: OnGameFrame()
Old 12-06-2015 , 05:16   Re: SDKHooks_TakeDamage BUG?
Reply With Quote #1

Quote:
Originally Posted by Dr. Greg House View Post
Great, two months ago he was telling me the exact opposite, basing it on the hook not being done correctly.

Can he please clarify this?
That's not quite what he said. The native bypasses the hook, but it's more of a side-effect of how the native is implemented than intentionally planned at the time - that behaviour will never be changed and is generally useful and relied upon.
__________________
asherkin is offline
Dr. Greg House
Professional Troll,
Part-Time Asshole
Join Date: Jun 2010
Old 12-08-2015 , 19:53   Re: SDKHooks_TakeDamage BUG?
Reply With Quote #2

Quote:
Originally Posted by asherkin View Post
That's not quite what he said. The native bypasses the hook, but it's more of a side-effect of how the native is implemented than intentionally planned at the time - that behaviour will never be changed and is generally useful and relied upon.
Thank you for clarifying this. His explanation came off kind of as an approach to saying what is wrong.
Given your notion, is there no chance this will ever get extended with an optional param?
I wouldn't mind doing it "right", and also updating the unclear documentation (which does not say if it triggers the hooks, to me it honestly implies that it does not go around the hook - why should it?), but given that my last pr, the simple hudmessage bugfix, hasn't been accepted or commented so far, I'm wondering if I should even bother? I'm not sure how fast and if the wheels turn here.
__________________
Santa or Satan?

Watch out when you're paying people for private requests! Most stuff already exists and you can hardly assess the quality of what you'll get, and if it's worth the money.
Dr. Greg House is offline
Chdata
Veteran Member
Join Date: Aug 2012
Location: Computer Chair, Illinois
Old 12-09-2015 , 08:44   Re: SDKHooks_TakeDamage BUG?
Reply With Quote #3

Well you could use OTDA



... if it actually does catch it which I still haven't really re-tested


And actually having an option for OTD to catch it would be neato. It's kinda silly to have to manually call OnTakeDamage after TakeDamage sometimes.
__________________

Last edited by Chdata; 12-09-2015 at 08:44.
Chdata is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 13:28.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode