[devilicioux]

So i have this code which is spitting errors in console !

PHP Code:

[AMXX] Displaying debug trace (plugin "test.amxx")
[AMXX] Run time error 3: stack error 
[AMXX]    [0] level.sma::Event_TeamInfo_All (line 3354) 


Line 3354 is marked in RED comment in the below code.

PHP Code:

public Event_TeamInfo_All()
{
    new id,iTeam 
    id = read_data( TeamInfo_PlayerID )
    if( !g_isAlive[id] && g_isConnected[id] )
    { 
        iTeam = get_pdata_int(id, m_iTeam, XO_PLAYER)      
        if( iTeam != get_user_team(id) )  //LINE 3354 
        {
            emessage_begin(MSG_BROADCAST, gmsgScoreInfo)
            ewrite_byte( id )
            ewrite_short( get_user_frags(id) )
            ewrite_short( get_pdata_int(id, m_iDeaths, XO_PLAYER) )
            ewrite_short( 0 )
            ewrite_short( iTeam )
            emessage_end()
        }
    }
} 


So i searched and found it to be associated with memory allocation issues.

Case 1 :
I put #pragma dynamic 32768 .. Crashes the server (No idea why !)

Case 2 :
So alternatively i decided to bring the stack/heap value below the default memory stack (16KB (16384 bytes) in our case) and decreased array / variable sizes and all possible things i could .
SO after i was done .. COmpiled the plugin ..

PHP Code:

Welcome to the AMX Mod X 1.8.1-300 Compiler.
Copyright (c) 1997-2013 ITB CompuPhase, AMX Mod X Team
Header size:           4812 bytes
Code size:           101968 bytes
Data size:            80944 bytes
Stack/heap size:      16384 bytes; max. usage is unknown, due to recursion
Total requirements:  204108 bytes
Done. 


But the problem still persists .. Same error thrown at the same line .. Any Alternatives or maybe can someone tell me what i am doing wrong ?
Suggestions / Alternatives / Solutions / Possibilities xD Anything will be helpful

Thanks in Advance

[^SmileY]

PHP Code:

        iTeam = get_pdata_int(id, m_iTeam, XO_PLAYER)      
        if( iTeam != get_user_team(id) )  //LINE 3354 


Why you are comparing if player has same team? does not make any sense, its using same as

if(get_user_team(id) != get_user_team(id))

LOL

[aron9forever]

Originally Posted by ^SmileY PHP Code:         iTeam = get_pdata_int(id, m_iTeam, XO_PLAYER)               if( iTeam != get_user_team(id) )  //LINE 3354  Why you are comparing if player has same team? does not make any sense, its using same as if(get_user_team(id) != get_user_team(id)) LOL

I think this is supposed to be a fix for get_user_team returning false team if player is moved till 1 round after he's moved

[^SmileY]

Originally Posted by aron9forever I think this is supposed to be a fix for get_user_team returning false team if player is moved till 1 round after he's moved

But this is not working, and their problem is not pragma dynamic

He simple can use get_pdata directly

[devilicioux]

Yes right .. Thats get_user_team fix .. So i had no other choice but to remove the code for now to stop the errors.

But still i dont get the point .. why #Pragma dynamic is crashing the server when it shouldnt even if the heap size require is lesser than default heap (16 KB).

Also WITHOUT #Pragma dynamic the plugin is working perfectly. No errors. No crashes.

[aron9forever]

I run #pragma dynamic 32768 in one of my larger plugins and it works fine
build 5787 , amxx 1.8.1, latest metamod_p

here's a little suggestion: change the heaps to normal, remove pragma, and on line 3354 change "new" to "static"

[devilicioux]

Originally Posted by aron9forever I run #pragma dynamic 32768 in one of my larger plugins and it works fine build 5787 , amxx 1.8.1, latest metamod_p here's a little suggestion: change the heaps to normal, remove pragma, and on line 3354 change "new" to "static"

Thanks for actively suggesting possible solutions

Back to the point..

Havent tried on 5787 .. This crash is occuring on hlds build 6153 , amxx 1.8.2 .. not sure about metamod version as the server isnt mine.

Unfortunately , I already tried changing new to static .. but the errors remained as it is.


Currently, i removed the get_user_team fix code as well as #pragma .. and plugin works fine now.
So until i find the actual fix to this .. i cant put the code back in my plugin..

[Arkshine]

Would be ueful to have a test plugin or whatever the plugin, ready as it is, and giving reproductible steps to crash the server.