[ezio_auditore]

O.K

I made the update.

I will have to go out.

I will publish the update soon.

[hornet]

Originally Posted by ezio_auditore It means it could be approved after a few necessary changes?

Your missing my point. Read the rest of my post. How can you apply this "standalone power" to gameplay?

[ezio_auditore]

Ok.. Done..
SEE CHANGELOG

Spoiler

============================================= ================================
v1.00 : Initial Release
============================================= ================================
v1.1 : Minor Fixes
Removed Force Bind of +rupture key
Added Gold Color Instead of Red
============================================= ================================
v1.2 : Added new sounds for
1.) Calling a Rupture
2.) Getting Ruptured by an enemy
3.) Killing an enemy by Rupture
4.) Death by Rupture

Added Fun Module
Removed fakemeta_util, used fakemeta in place of that for FM_CmdStart
============================================= ================================

I changed the category to Fun Stuff

[EthicalHacker007]

It would be better if you would make a mod. I've an idea, but it's much difficult because you've to create your own models, sprites, etc.

[ezio_auditore]

MOD? What is the idea?

[ezio_auditore]

As you wish. But I will still like this to be reviewed...

[Jhob94]

Instead of use use a bind, why dont you use a cvar and then people choose what key to use?
I mean something like this:
0 - People would have to do bind x +rupture
1 - Rupture would be use on +USE
2 - Rupture would be use on Reload (A server with only knife could run this)
3 - Rupture would be use on flashlight (You would have to register the impulse)
And there are more keys you can use...

[ezio_auditore]

Updated.

See this

.:: Changelog ::.

Spoiler

============================================= ================================
v1.00 : Initial Release
============================================= ================================
v1.1 : Minor Fixes
Removed Force Bind of +rupture key
Added Gold Color Instead of Red
============================================= ================================
v1.2 : Added new sounds for
1.) Calling a Rupture
2.) Getting Ruptured by an enemy
3.) Killing an enemy by Rupture
4.) Death by Rupture

Added Fun Module
Removed fakemeta_util [**will still keep fakemeta to detect movement keys**]
============================================= ================================
v1.3 : Added CVar for bind of +rupture key (JHob94)
amx_rupture_key [0/1/2]
0 : +USE key will be used.
1 : +RELOAD key will be used (For Knife Servers)
2 : Custom Bind
============================================= ================================

[hornet]

Originally Posted by ezio_auditore I will still like this to be reviewed...

You have still misunderstood my post. I'm referring to this plugin as a standalone feature that really does not serve much purpose and does not run in conjunction with any other known plugins.
In regards to your code, it looks like you have not updated it / or made necessary changes.

• Your still using CmdStart to hook a few button presses as well as to detect movement which is a very inefficient way.
• You need to cache cvars where applicable and other native values ( particularly in loops ).
• Player indexes should never be looped through, you should be using get_players() and use the output array.
• You have used both ExecuteHam() and ExecuteHamB(), but have no Ham forwards in your plugin. Why should the calling of one of those virtual functions be important and not the other ( and vice versa )? Are you sure you understand the difference?

This shows that you still lack a lot of the necessary understanding here.

[ezio_auditore]

Ahh. I was missing that point. Thanks.