Good idea, like it!
But I want to ask you something. Why do you define three different thing, when they are all the same?
PHP Code:
//Menu Key Definitions
#define KeysBankMenu (1<<0)|(1<<1)|(1<<9) //Bank Main Menu
#define KeysSavings (1<<0)|(1<<1)|(1<<9) //Savings A/C
#define KeysLoan (1<<0)|(1<<1)|(1<<9) //Loan Scheme
You can define something like 'keys' and use it everywhere.
--------------------------------------------------------------------------------------------
Also you may register not only "say" commands, but say_team, and maybe with a slash ( / ) in each type say.
--------------------------------------------------------------------------------------------
And why you formatex szWarnings twice, when you can put the first format directly in the second vie the same method. In other words:
PHP Code:
formatex(szWarnings, charsmax(szWarnings), "%i", g_WrnTime[id] <= iMaxWarns ? g_WrnTime[id] : iMaxWarns)
formatex(szWarnings, charsmax(szWarnings), "%s of %i", szWarnings, iMaxWarns)
--->
PHP Code:
formatex(szWarnings, charsmax(szWarnings), "%i of %i", g_WrnTime[id] <= iMaxWarns ? g_WrnTime[id] : iMaxWarns, iMaxWarns)
--------------------------------------------------------------------------------------------
And this
PHP Code:
client_cmd(id, "disconnect")
is holly slowhacking, AFAIK.
Better use
PHP Code:
//before the switch
new name[32]
get_user_name(id, name, charsmax(name))
//In case 4
case 4:{
server_cmd("kick %s", name)
}
In this case, when the user is kicked, you try to display him a HUD message anyways. This will cause errors. So, put a check if the user is connected and then show the message. Example:
PHP Code:
set_hudmessage(200, 0, 0, 0.0, -1.0, 0, 6.0, 12.0)
if(is_user_connected(id))
show_hudmessage(id, "You Have Been Punished For Not Paying Your Loan^nWe Owe You $%i", g_Debt[id])
--------------------------------------------------------------------------------------------
And I think is better to use the new style menu. Not sure, but AFAIK is more efficient and working more properly. Anyways, leave this if you want. But why you put empty "case 9"s? Put some return value, if you want to stop the function, but it's pointless to leave it empty.
--------------------------------------------------------------------------------------------
I think these are the improvements I can tell. Look, I can't get that old menu style, so someone else should take a look. Keep working on this, it's a great idea!!!
Linear Mode
