[ArabicMan]

Not working when i write /knife show me 1-Seal Knife and 0-Exit

[DavidJr]

Have you put cs_knife.ini in configs?

[ArabicMan]

Originally Posted by DavidJr Have you put cs_knife.ini in configs?

I was forget it now it's works fine but in commands say knife in chat not work. Add messages when i try buy it and i don't have money print message in chat say that you haven't money to buy this knife. Also make the price (ex: 1000$) color in menu yellow or red that will be much better.

[DavidJr]

Originally Posted by ArabicMan I was forget it now it's works fine but in commands say knife in chat not work.

It works fine in me.

Originally Posted by ArabicMan Add messages when i try buy it and i don't have money print message in chat say that you haven't money to buy this knife. Also make the price (ex: 1000$) color in menu yellow or red that will be much better.

Thank you, I'll add it asap.

[ArabicMan]

Originally Posted by DavidJr It works fine in me.

I test it many times say /knife and in team say /knife works fine but knife in chat and team say not work try it again to see.

[DavidJr]

What do you mean knife in chat? The commands just look like these:

PHP Code:

    register_clcmd("say /knife", "ClCmd_Menu");
    register_clcmd("say_team /knife", "ClCmd_Menu");
    register_clcmd("knife", "ClCmd_Menu"); 


[ArabicMan]

Originally Posted by DavidJr What do you mean knife in chat? The commands just look like these: PHP Code:     register_clcmd("say /knife", "ClCmd_Menu");     register_clcmd("say_team /knife", "ClCmd_Menu");     register_clcmd("knife", "ClCmd_Menu");

Sorry i was write it in chat not console. It works fine in CONSOLE.

[HamletEagle]

As BackStabNoob pointed this is different from his API. API requiere a coder to make the knife, while this allow the end user to make his own knives so I won't mind having both of them, but before some things needs to be fixed:

1.Instead of CurWeapon event use Ham_Item_Deploy. To get weapon csw index from weapon ent index use cs_get_weapon_id.
2.In OnCBase_WpnPrimaryAttack_Pre and OnCBase_WpnSecondaryAttack_Pre make sure the entity is valid before doing something. Also checking the weapon index is reduntant, you already registered the hook only for knife.
3.In task_DelayAttack:

• checking trFraction two times seems weird, just put Play_EmitSound in the first check.
• get_maxplayers should be cached in a place like init, because it will never change during run time.
• you are freeing an empty trace handle: free_tr2(hTrace)

4.In ClCmd_Menu:

• PHP Code:

  equal(cName[i], "") 

  . Checking like this should be enough: !cName[i]
• Do not create variables inside loop
• Use formatex, not format if you are not formatting into the same buffer from where you get values. It's faster.

5.Give_Weapon is just a dummy function which should be removed, call directly Set_Weapon
6.

PHP Code:

new szWpnName[32];
    get_weaponname(CSW_KNIFE, szWpnName, sizeof szWpnName - 1); 


Really ? You already know it's weapon_knife.
7.Don't use fakemeta_util in plugins, use it only for learning purpose. Instead of it you should use functions from engine/fun/fakemeta/cstrike etc. So, instead of fm_give_item use give_item.
8.The trace from Draw_ScratchDecal is already empty so you should not free it again.
9.In LoadWpnConfig:

• When dealing with strings use charsmax() instead sizeof - 1 for readability.
• PHP Code:

  fgets(szFile, szLineData, sizeof szLineData) 

  that's wrong, you forgot to substract -1, but as I said, use charsmax.
• PHP Code:

  replace(szLineData, sizeof szLineData - 1, "^n", ""); 

  it's not needed.
• You should trim szLineData before working with it, that way you will remove empty unneded spaces. Without this your check can fail: szLineData[0] == ';'
• I am not sure to like much your file parsing method, but that's something to see later.

A suggestion would be to do not limit the user to only 32 knives, you could use dynamic arrays to store the content of the file.

You should start with this, later we'll check in deep every function.

[HamletEagle]

15 days have passed and I don't see any changes from the author. Since section needs to be cleaned I'll unapprove this for now, but don't worry, your plugin can be reviewed at any time. PM a plugin approver after you made the changes.