[ReZy]

Originally Posted by Bara Memory Leak:

Going to fix that in v1.1.0

[ReZy]

~-1.1.0-~
Added ProcessTargetString
Added 4 ConVars
Fixed memory leak issue
Fixed warnings

[necavi]

The memory leak will still be there, and whenever any cvar is changed, it will screw over the values of every single other cvar. Also your Float convar will be screwed up if it is changed at all.

[ReZy]

Originally Posted by necavi The memory leak will still be there, and whenever any cvar is changed, it will screw over the values of every single other cvar. Also your Float convar will be screwed up if it is changed at all.

Will fix it later.

[Civiccod PRO]

The memory leak will still be there, and whenever any cvar is changed, it will screw over the values of every single other cvar. Also your Float convar will be screwed up if it is changed at all.

How about closing handle instead of killtimer??

and instead for OnPluginStart for GetConVarBool, use OnSettingsChange??

public Action:Timer_Slap(Handle:timer, any:iBuffer)
{
	new iClient = GetClientFromSerial(iBuffer);

	if (IsPlayerAlive(iClient) && (1 <= iClient <= MaxClients))
	{
		SlapPlayer(iClient, g_iSlapDamage, true);
    }
	else
	{
		timer = INVALID_HANDLE;
		
		CloseHandle(Handle:timer);
	}
}

public OnSettingsChange(Handle:cvar, const String:oldvalue[], const String:newvalue[])
{
    if (cvar == g_hEnabled)
    {
        g_bIsEnabled = GetConVarBool(g_hEnabled);
        g_iSlapDamage = GetConVarInt(g_hDamage);
        g_iMaxSlaps = GetConVarInt(g_hMaxSlap);
        g_fSlapInterval = GetConVarFloat(g_hSlapSpeed);
    }
}

[necavi]

You do not need to close the handle of a timer. The issue is that you're creating a fuckton of timers at once, if the command is used more than a few times in a row it can trigger that error.

[TnTSCS]

Here's my contribution to your plugin - take what you want, or take nothing... just had a hankering to help

code

PHP Code:

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>

#define PLUGIN_VERSION "1.1.0a"

new Handle:g_hEnabled = INVALID_HANDLE;
new Handle:g_hDamage = INVALID_HANDLE;
new Handle:g_hMaxSlap = INVALID_HANDLE;
new Handle:g_hSlapSpeed = INVALID_HANDLE;

new bool:g_bIsEnabled = false;
new g_iSlapDamage;
new g_iMaxSlaps;
new Float:g_fSlapInterval;

public Plugin:myinfo =
{
        name = "BitchSlap",
        author = "ReZy",
        description = "Bitchslap a Person",
        version = PLUGIN_VERSION,
        url = ""
}

 
public OnPluginStart()
{
        g_hEnabled = CreateConVar("sm_enable_bitchslap", "1", "This enabled or disabled the bitchslap command (0 = Off : 1 = On).", FCVAR_NONE, true, 0.0, true, 1.0);
        HookConVarChange(g_hEnabled, OnSettingsChange);
        g_hDamage = CreateConVar("sm_bitchslap_damage", "10", "This changes the damage of bitchslap", FCVAR_NONE, true, 0.0, true, 300.0);
        HookConVarChange(g_hDamage, OnSettingsChange);
        g_hMaxSlap = CreateConVar("sm_bitchslap_maxspeed", "20", "This changes max slaps bitchslap does", FCVAR_NONE, true, 1.0, true, 20.0);
        HookConVarChange(g_hMaxSlap, OnSettingsChange);
        g_hSlapSpeed = CreateConVar("sm_bitchslap_slapspeed", "0.25", "This changes the slap speed of bitchslap", FCVAR_NONE, true, 0.1, true, 1.0);
        HookConVarChange(g_hSlapSpeed, OnSettingsChange);
 
        g_bIsEnabled = GetConVarBool(g_hEnabled);
        g_iSlapDamage = GetConVarInt(g_hDamage);
        g_iMaxSlaps = GetConVarInt(g_hMaxSlap);
        g_fSlapInterval = GetConVarFloat(g_hSlapSpeed);
 
        RegAdminCmd("sm_bitchslap", Command_BitchSlap, ADMFLAG_ROOT, "Bitchslap a Person");
}

 
public OnSettingsChange(Handle:cvar, const String:oldvalue[], const String:newvalue[])
{
    if (cvar == g_hEnabled)
    {
        g_bIsEnabled = GetConVarBool(cvar);
    }
    else if (cvar == g_hDamage)
    {
        g_iSlapDamage = GetConVarInt(cvar);
    }
    else if (cvar == g_hMaxSlap)
    {
        g_iMaxSlaps = GetConVarInt(cvar);
    }
    else if (cvar == g_hSlapSpeed)
    {
        g_fSlapInterval = GetConVarFloat(cvar);
    }
    
}

 
public Action:Command_BitchSlap(iClient, iArgs)
{
    if (!g_bIsEnabled)
    {
        ReplyToCommand(iClient, "[SM] Error: All the features in this plugin have been disabled.");
        return Plugin_Handled;
    }
    
    if (iArgs < 1)
    {
        ReplyToCommand(iClient, "[SM] Usage: sm_bitchslap <player> <number of times>");
        return Plugin_Handled;
    }
    
    new String:sArg[MAX_NAME_LENGTH];
    new String:sArg2[16];
    GetCmdArg(1, sArg, sizeof(sArg));
    GetCmdArg(2, sArg2, sizeof(sArg2));
 
    new String:target_name[MAX_TARGET_LENGTH];
    new target_list[MAXPLAYERS], target_count, bool:tn_is_ml;
 
    if ((target_count = ProcessTargetString(
        sArg,
        iClient,
        target_list,
        MAXPLAYERS,
        COMMAND_FILTER_DEAD,
        target_name,
        sizeof(target_name),
        tn_is_ml)) <= 0)
    {
        ReplyToTargetError(iClient, target_count);
        return Plugin_Handled;
    }
    
    new SlapTimes = StringToInt(sArg2);
    if (SlapTimes < 1 || SlapTimes > g_iMaxSlaps)
    {
        ReplyToCommand(iClient, "[SM] Error: You must provide a valid number of times to slap the player (1-%i)", g_iMaxSlaps);
        return Plugin_Handled;
    }
    
    // Not sure if this is the best way to achieve your goal...
    #if 0
    new iCount = 0, Float:fDelay = g_fSlapInterval;
    
    while (iCount < SlapTimes)
    {
        CreateTimer(fDelay, Timer_Slap, GetClientSerial(iClient), TIMER_FLAG_NO_MAPCHANGE);
        
        fDelay += g_fSlapInterval;
        iCount++
    }
    #endif
    
    CreateTimer(g_fSlapInterval, Timer_SlapPlayer, GetClientSerial(iClient), TIMER_REPEAT);

    return Plugin_Handled;
}

#if 0
public Action:Timer_Slap(Handle:timer, any:iBuffer)
{
    new iClient = GetClientFromSerial(iBuffer);
    
    if (iClient == 0 || !IsClientInGame(iClient) || !IsPlayerAlive(iClient))
    {
        // Client no longer valid, not in game, or is dead.
        return Plugin_Continue;
    }

    SlapPlayer(iClient, g_iSlapDamage, true);
    
    return Plugin_Continue;
}
#endif

public Action:Timer_SlapPlayer(Handle:timer, any:iBuffer)
{
    new iClient = GetClientFromSerial(iBuffer);
    
    if (iClient == 0 || !IsClientInGame(iClient) || !IsPlayerAlive(iClient))
    {
        return Plugin_Stop;
    }
    
    static NumSlapped = 0;
    
    SlapPlayer(iClient, g_iSlapDamage, true);
    
    NumSlapped++;
    
    if (NumSlapped == g_iMaxSlaps)
    {
        return Plugin_Stop;
    }
    else
    {
        return Plugin_Continue;
    }
} 


Use http://www.quickdiff.com/ to see the changes... I set all 4 spaces (and some 3 spaces) to tabs and adjusted the indentation of the ProcessTargetString...

hope it helps... also, this is untested and I'm not sure if my use of the static is appropriate or if it would even work.