[rodrigo286]

Buy Respawn

.:: Functionality ::.

Allows players to buy respawn to return to play again, it is possible to set the price.

This plugin has been rewritten from the original made ​​by member: Devzirom
Original thread: http://forums.alliedmods.net/showthread.php?t=141345

The cause of rewriting the plugin? It has not been approved.

I removed the cvar sm_buy_relive_buytime, because hardly anyone will die before the end buytime, however I am open to suggestions will.

.:: CVARs ::.

• sm_buyrespawn_enabled = 1/0 - plugin is enabled/disabled (def. 1)
• sm_buyrespawn_cost = 0-16000 - Set the price for the respawn (def. 5000)
• sm_buyrespawn_per_round = 0-99 - Set the max respawns per round (def. 10)
• sm_buyrespawn_message = 1/0 plugin message is enabled/disabled (def. 1)
• sm_buyrespawn_version - current plugin version

.:: Commands ::.

• !buyr
• !respawn
• !revive
• !buyrespawn
• !buyrevive

.:: Changelog ::.

Spoiler

Version 1.0.0

• Initial Release

Version 1.0.1

• ConVar FIX
• sm_ added in commands
• Small optimizations

Version 1.0.2

• Added Cvar sm_buyrespawn_per_round
• Added Automatic .cfg generator
• Added HookConVarChange
• Little optimization

Version 1.0.3

• [STORE] Version Released
• Small fix in uses count

Version 1.0.4

• Some bugs fixed, reported by relicek.
• [STORE] Version updated also.

OFICIAL WORK WITH GAMES

• Counter-Strike Source
• Counter-Strike Global Offensive

.:: Credits ::.

Devzirom

Thanks and please comment !

[CtrlC Developer]

I am using on my server, and is really stable, liked it, thanks for the plugin, Rodrigo286.

[RedSword]

Removed attached .smx as it is not needed.

[RedSword]

Hi,

Just to tell you that you need FCVAR_NOTIFY to your version ConVar, or otherwise it will be useless since your plugin will not be trackable. You could also add that to the "public convar" thing in this thread's post; that way when approved people knows how many time it is used.

Also, you should not use FCVAR_REPLICATED as it can produce errors on the client.

Finally, you should use the prefix "sm_" in all your "commands_respawn" array's strings. This prevent possible conflict in case Valve decide to implement such a console variable. Don't worry, using "sm_command" will still add the "/command" and "!command" chat triggers.

Note that 2nd and 3rd points are not obligatory, but strongly recommended.

Red

[The End Is Near...]

1.

PHP Code:

// Bad
for (new i = 0; i < sizeof(commands_respawn); i++)

// Good
new size = sizeof(commands_respawn);
for (new i = 0; i < size; i++) 


2.

PHP Code:

// Bad
new team = GetClientTeam(client);
if(team != CS_TEAM_CT && team != CS_TEAM_T)

// Good
if (GetClientTeam(client) > 1) 


3. Get cvars (gBuyRespawnEnabled) two times - Bad

4.

PHP Code:

// Doubt
if(!IsValidClient(client)) and if(client < 1) 


[RedSword]

Originally Posted by The End Is Near... 1. PHP Code: // Bad for (new i = 0; i < sizeof(commands_respawn); i++) // Good new size = sizeof(commands_respawn); for (new i = 0; i < size; i++)  2. PHP Code: // Bad new team = GetClientTeam(client); if(team != CS_TEAM_CT && team != CS_TEAM_T) // Good if (GetClientTeam(client) > 1)  3. Get cvars (gBuyRespawnEnabled) two times - Bad 4. PHP Code: // Doubt if(!IsValidClient(client)) and if(client < 1)

1- Small optimization; it is run only once (not that important); but you're right.

2- "<="; not ">"

3- Convars are already cached in SM itself. Caching in a plugin does probably optimize a bit further, but that's far from being important.

4- Look at his function; it is already checking if "< 1" or not.

[The End Is Near...]

1. < 1 two times actually
2. <= confused
thinking about

PHP Code:

if (GetClientTeam(client) > 1)
{
     // Code
} 


[rodrigo286]

Originally Posted by The End Is Near... 1. < 1 two times actually 2. <= confused thinking about PHP Code: if (GetClientTeam(client) > 1) {      // Code }

If team 2 or 3 No
If team 1 Yes

<= Less or equal

Plugin Updated in initial post

[RedSword]

Looks ok. Approved.

[homerjsimpson]

Awesome ... great rewritten