[RedSword]

Hey,

You could replace

#define DEFAULT_BLESSING_LEVEL 4.0
#define DEFAULT_CURSE_LEVEL 4.0

by ConVars. Also

IsClientEntity

a client is always an entity, so your function is sementically incorrect. On L122 you could be using MaxClients instead of MAXPLAYERS; you're over-looping.

You could also change your forum compiler version so people could use the "Get Plugin" button rather than download your .smx.

For approval please fix the following :`

In that same loop, if a blessed/cursed user disconnected, he'll still be considered Cursed/Blessed, so he'll still have his PlayerBlessCurseLevels value != 1.0, meaning you'll be using %N on a disconnected client --> ERROR.

Red

[sneakret]

I forgot I'd even posted this.

You're right about MaxClients. I think that's fixed in the current version, but I don't use it or intend to publish it. If you want to adopt this plugin and maintain it, feel free.

I also agree that having the defaults be cvars would be handy.

I'm on a tablet at the moment, and don't have the code I front of me, but I am pretty sure the %N won't be hit for a disconnected player. It's probably prevented by an "IsClientEntity" check.

IsClientEntity means "is this entity a client?" An entity that is a client can reasonably be called a "client entity." It is not semantically incorrect, but I can see how it could seem that way. I could also write a function called "IsClientUserId", to find out if the given user ID belonged to an active client.

[RedSword]

Originally Posted by sneakret I'm on a tablet at the moment, and don't have the code I front of me, but I am pretty sure the %N won't be hit for a disconnected player. It's probably prevented by an "IsClientEntity" check. [...]

If you look at the OnShowBlessedCmd callback (sm_blessed), you can see that no IsClientEntity is being called. I also got the following error by testing (seems also that your VFormat usage is incorrect) :

Spoiler

L 03/19/2015 - 12:09:07: [SM] Native "VFormat" reported: Client index 5 is invalid
L 03/19/2015 - 12:09:07: [SM] Displaying call stack trace for plugin "textHnZS1X.smx":
L 03/19/2015 - 12:09:07: [SM]   [0]  Line 45, /groups/sourcemod/upload_tmp/textHnZS1X.sp::PluginReplyToCommand()
L 03/19/2015 - 12:09:07: [SM]   [1]  Line 136, /groups/sourcemod/upload_tmp/textHnZS1X.sp::OnShowBlessedCmd()

(note that the line number differ by 1 since I removed TF2 dependency)

and

Originally Posted by sneakret You're right about MaxClients. I think that's fixed in the current version, but I don't use it or intend to publish it. If you want to adopt this plugin and maintain it, feel free.

If I understand correctly by your 2nd & 3rd sentences you mean that you won't update your plugin (instead of just the "MaxClients" thing). I'll unapprove your plugin then.

Red

[RedSword]

Changing status from "Ready for review" to "(none)", since there is no will to correct it & last edit was in 2012.