[tm.]

Hi. I wrote a plugin to list all the maps from the maps folder, but I have a problem with sorting the list. I managed to sort them, using the Exolent's code from here, but I think what I've made looks messy.
I was wondering what's the best way for sorting dynamic string arrays?

Here's the part of the code in question:

PHP Code:

public SortMaps(Array:g_MapsArray, iItem1, iItem2, const iData[])
{
    static iData1[5], iData2[5]; // first 5 elements should be enough

    ArrayGetString(g_MapsArray, iItem1, iData1, charsmax(iData1));
    ArrayGetString(g_MapsArray, iItem2, iData2, charsmax(iData2));

    new iCount1 = iData1[0]; // gets the first letter of the map name('d' for 'de_dust2')
    new iCount2 = iData2[0]; // -//- ('d' for 'de_inferno')

    if(iCount1 != iCount2) // in this example 'd' equals 'd'
    {
        return (iCount1 > iCount2) ? 1 : -1;
    }

    iCount1 = iData1[1];
    iCount2 = iData2[1];

    if(iCount1 != iCount2) // 'e' equals 'e'
    {
        return (iCount1 > iCount2) ? 1 : -1;
    }

    iCount1 = iData1[3];
    iCount2 = iData2[3];

    // 'd' != 'i' but this it's not good cause some maps could have a 3 letter prefix (awp_)
    // then I'd need to repeat the above process
    return (iCount1 > iCount2) ? 1 : ((iCount1 < iCount2) ? -1 : 0);
} 


The entire code it's attached.

[ConnorMcLeod]

Could you explain why you do that 2nd line :

PHP Code:

            ArrayPushString(g_MapsArray, szFileName);
            ArraySetString(g_MapsArray, g_iTotalMaps++, szFileName); 


??


Also, i think that max mapname length is 32, without .bsp extension, so you should make a 36 sized array


About your problem, why don't you log everuy thing the plugin do at plugin start in a specific file, you could figure by yourself what is wrong ;)

[tm.]

Thanks for the reply.

From this:

* The item must already exist, use ArrayPushArray to create a new item within the array.

I've wrongly understood that I need to use ArrayPushArray before I can use ArraySetString.
I thought ArrayPushArray it's some kind of initialization, that it doesn't actually sets the item in the array .
Also I did some debugging but didn't figure out a 'slimmer' way to do the sorting.

LE: Test it without

PHP Code:

ArraySetString(g_MapsArray, g_iTotalMaps++, szFileName); 


Doesn't work that way.

[ConnorMcLeod]

Also, maps names are already sorted by default when reading directory, how are you trying to sort ?

[tm.]

On win it does, on linux the list seems to be random, or listed by a criteria I don't know. I want it sorted alphabetically ascending. As I said, I've managed to do that with that code, but I was just wondering if it's a better way to do it.