[AfteR.]

I'm making a Speed Upgrade menu, and it works. But i would like to know how can I optimize this and also add a prize for each improve. Also, that prize higher than the last one...

Here's the code.

PHP Code:

#include <amxmodx>
#include <amxmisc>
#include <fakemeta>

#define PLUGIN "Upgrade Speed"
#define VERSION "1.0"
#define AUTHOR "AfteR ;)"

const KEYSMENU = (1<<0)|(1<<1)|(1<<2)|(1<<3)|(1<<4)|(1<<5)|(1<<6)|(1<<7)|(1<<8)|(1<<9)

new coins[33], speed[33], upgraded[33]

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    register_menu("Game Menu", KEYSMENU, "menu2")
    register_clcmd("say a" , "menu" )
    register_forward(FM_PlayerPreThink, "fw_PlayerPreThink")

}


// Forward Player PreThink
public fw_PlayerPreThink(id)
{
    // Not alive
    if (!is_user_alive(id))
        return;
    
    set_pev(id, pev_maxspeed, 150.0 + speed[id])
}


public menu(id) menu1(id)


public menu1(id)
{
    static menu[300], len
    len = 0
    
    len += formatex(menu[len], sizeof menu - 1 - len, "\yImprove Speed Menu^n^n")
    
    len += formatex(menu[len], sizeof menu - 1 - len, "Coins: %d^n", coins[id])
    len += formatex(menu[len], sizeof menu - 1 - len, "Upgraded Times: %d^n^n", upgraded[id])
    
    len += formatex(menu[len], sizeof menu - 1 - len, "\r1. \wImprove Speed^n^n")
    
    len += formatex(menu[len], sizeof menu - 1 - len, "\r0. \wExit")
    
    show_menu(id, KEYSMENU, menu, -1, "Game Menu")
}

public menu2(id, key)
{
    switch (key)
    {
        case 0: 
        {
            if (upgraded[id] <= 4)
            {
                speed[id] += 30
                upgraded[id]++
            }
            else
                client_print(id, print_chat, "Max Upgrades.")
            
        }
        
    }
} 


Coins are the prize

[01101101]

PHP Code:

public menu(id) menu1(id) 


public menu1(id) 
{ 


WTF

[AfteR.]

Originally Posted by 01101101 PHP Code: public menu(id) menu1(id)  public menu1(id)  {  WTF

Anybody else?

[Seta00]

Originally Posted by 01101101 PHP Code: public menu(id) menu1(id)  public menu1(id)  {  WTF

WTF++

You've asked for optimizations. Removing WTFs from your code might be useful.

[fysiks]

I thought you were supposed to set speed in CurrentWeapon. I also thought you could use set_user_maxspeed() instead of using fakemeta.

[AfteR.]

Originally Posted by fysiks I thought you were supposed to set speed in CurrentWeapon. I also thought you could use set_user_maxspeed() instead of using fakemeta.

I just asked that to know which was better, but now i i'd like to know if there would be a better method to set the speed upgrade stuff.

I mean: coins[33], speed[33], upgraded[33]

[Doc-Holiday]

use curwep event and set_user_maxspeed from fun. Also use a set speed dont add speed unless some one knows how to keep curwep to only fire on weapon switch (hamdeploy?)

Example:

PHP Code:

public curwep(id)
{
      set_user_maxspeed(id, Float:Speed);
}

Not!!!!
public Curwep(id)
{
       set_user_maxspeed(id, get_user_maxspeed(id) + Float:Speed)
} 


The second example adds that speed each time the event is fired. how ever you could do

PHP Code:

set_user_maxspeed(id, 250 + Float:Speed) 


Which is about the average speed

[Max!]

Originally Posted by NcB_Sav unless some one knows how to keep curwep to only fire on weapon switch

PHP Code:

new g_iLastWeapon[33]

public curweapon(iClient)
{
    new iWeapon = get_user_weapon(iClient)
    if(iWeapon != g_iLastWeapon[iClient])
    {
        g_iLastWeapon[iClient] = iWeapon
        // do stuff
    }
} 


[Doc-Holiday]

Originally Posted by Max! PHP Code: new g_iLastWeapon[33] public curweapon(iClient) {     new iWeapon = get_user_weapon(iClient)     if(iWeapon != g_iLastWeapon[iClient])     {         g_iLastWeapon[iClient] = iWeapon         // do stuff     } }

Hmm ill have to give that a shot haha.. Thanks much.

[ConnorMcLeod]

Best place to set max speed : http://forums.alliedmods.net/showthr...202#post853202