Raised This Month: $51 Target: $400
 12% 

Fixed mapsmenu.sma


Post New Thread Reply   
 
Thread Tools Display Modes
Plugin Info:     Modification:   ALL        Category:   Technical/Development       
Flasher
Senior Member
Join Date: Apr 2008
Old 09-20-2009 , 03:43   Fixed mapsmenu.sma
Reply With Quote #1

Here is a patched version of base AMXX plugin.
It contains fix for a bug that lead to "bad load" error for all plugins. And AMXX totally stop working (while you can play on server, AMXX commands don't work).
Here how "amxx plugins" output looks (all plugins have same status so I cut them of):
PHP Code:
Currently loaded plugins:
       
name                    version     author            file            
status
 
[  3unknown                 unknown     unknown           admincmd.amxx   
bad load

(  3Load failsPlugin file open error (plugin "admincmd.amxx"
This bug affects all AMXX installations. It exists in 1.8.0 and 1.8.1 versions (doesn't checked other versions).
While we are waiting for next AMXX release I decided to post patched version here.
So it can help you to get your server more stable.
More info about the bug can be found here: https://bugs.alliedmods.net/show_bug.cgi?id=3957
Attached Files
File Type: sma Get Plugin or Get Source (mapsmenu.sma - 1371 views - 15.1 KB)

Last edited by Flasher; 10-12-2009 at 21:38.
Flasher is offline
Exolent[jNr]
Veteran Member
Join Date: Feb 2007
Location: Tennessee
Old 09-20-2009 , 03:48   Re: Patched mapsmenu.sma
Reply With Quote #2

Explain how this error happens, and what you did to fix it.

Also, it's nice to know that you are using Non-Steam supported server.
Did you make sure that this bug occurs on Steam servers?
__________________
No private work or selling mods.
Quote:
Originally Posted by xPaw View Post
I love you exolent!
Exolent[jNr] is offline
Flasher
Senior Member
Join Date: Apr 2008
Old 09-20-2009 , 03:54   Re: Patched mapsmenu.sma
Reply With Quote #3

How error happens is described here: https://bugs.alliedmods.net/show_bug.cgi?id=3957
Yes, I am sure. Not closed file handle affects any type of server.

Last edited by Flasher; 10-12-2009 at 21:34.
Flasher is offline
Xevious
Senior Member
Join Date: Sep 2009
Location: Computer Chair
Old 09-20-2009 , 04:09   Re: Patched mapsmenu.sma
Reply With Quote #4

nice , another bug have been fixed , nice work
__________________
Nothing possible when you are not hardworking
Xevious is offline
Send a message via MSN to Xevious
Flasher
Senior Member
Join Date: Apr 2008
Old 09-20-2009 , 04:10   Re: Patched mapsmenu.sma
Reply With Quote #5

Just amazing how it has lived so long.
Flasher is offline
ConnorMcLeod
Veteran Member
Join Date: Jul 2006
Location: France (95)
Old 09-20-2009 , 04:18   Re: Patched mapsmenu.sma
Reply With Quote #6

PHP Code:
    if (!file_exists(filename))
        return 
0
This is useless because fopen returns 0 if the file doesn't exist.
Only fclose is needed.
__________________
- tired and retired -

- my plugins -

Last edited by ConnorMcLeod; 09-20-2009 at 04:25.
ConnorMcLeod is offline
Contrenature
Member
Join Date: Nov 2008
Location: Latvia, Liepaya, Riga
Old 09-20-2009 , 04:20   Re: Patched mapsmenu.sma
Reply With Quote #7

Verry strange, our community servers 3 working years, newer ever happen this bug.. o_O
And we have to Steam and Non-Steam servers...
Contrenature is offline
Send a message via Skype™ to Contrenature
Flasher
Senior Member
Join Date: Apr 2008
Old 09-20-2009 , 05:01   Re: Patched mapsmenu.sma
Reply With Quote #8

Quote:
Originally Posted by ConnorMcLeod View Post
PHP Code:
    if (!file_exists(filename))
        return 
0
This is useless because fopen returns 0 if the file doesn't exist.
Only fclose is needed.
Ic. I took this code from mapchooser.sma. So I think you can go and make a proposal on bug tracker. May be AMXX developers will consider this.

Quote:
Originally Posted by Contrenature View Post
Verry strange, our community servers 3 working years, newer ever happen this bug.. o_O
And we have to Steam and Non-Steam servers...
You can get this bag easily: set mp_timelimit to 1. File maps.ini is opened after each map change. You can use monitoring tools to see that handle count is increased each map change and look at file handles list.
And there is simple explanation why it isn't get spotted: server from valve is so buggy so it can't work so long for this error could happen.

Last edited by Flasher; 09-20-2009 at 05:07.
Flasher is offline
meigyoku
BANNED
Join Date: Apr 2009
Old 09-20-2009 , 05:31   Re: Patched mapsmenu.sma
Reply With Quote #9

My non steam server some time has been crased when change map!
I have to use nonsteam because all people use it!
Can your plugin fix bug when map is changed?
meigyoku is offline
Flasher
Senior Member
Join Date: Apr 2008
Old 09-20-2009 , 05:48   Re: Patched mapsmenu.sma
Reply With Quote #10

Patch in this topic isn't related to total crash at map change. Only AMXX is stop working. So I think answer is: no, it can't. But anyway anyone should use this patch because it fixes a bug. If you server will no longer crash at map changes - post here about this.

Last edited by Flasher; 04-28-2010 at 23:53. Reason: typo
Flasher is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:11.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode