[NiHiLaNTh]

--- Intro ---
This plugin adds new weapon - M79 Grenade Launcher.You'll have 10 grenades.To launch grenade press attack1 button.To buy grenade launcher say /m79.

--- Credits ---
NiHiLaNTh - Plugin
Cheap_Suit - Adding new weapon
meTaLiCroSS - Weapon touch
joaquimandrade - helped to optimize

--- Changelog ---
v1.0 - First release
v1.1 - Little code optimization

--- Screenshots ---

--- Have Fun ---

[KadiR]

looks cool

[Jon]

Looks good, although from the picture it looks like you should add an offset to the Z-axis before setting the origin of the grenade (correct me if I'm wrong, could be the model animation).

[Arkshine]

There are severals things you could change/improve :

- You should write directly the weapon in register_event(), it will avoid the callback to be called for all weapons, each shots, thus avoiding unnecessary check.

register_event("CurWeapon", "Event_CurrentWeapon", "be", "1=1", "2=5") // 5 = CSW_XM1014 

But I would prefer to use Ham_Item_Deploy from Hamsandwich since it's more appropriate and readable to change the model and play the animation at this time.

- Where are the weapon animations ? Reload, deploy, throw and pullpin ? To play an animation, you should use something (I use fakemeta but feel free to use engine) :

UTIL_SendWeaponAnimation ( const Player, const Animation )
{
    set_pev( id, pev_weaponanim, i_Animation );

    message_begin( MSG_ONE_UNRELIABLE, SVC_WEAPONANIM, .player = Player );
    write_byte( Animation );
    write_byte( pev( Player, pev_body ) );
    message_end();
}

You could use an enum to list the animation :

enum
{
    m79_idle,
    m79_pullpin,
    m79_throw,
    m79_deploy
};

// [...]

// For example :
UTIL_SendWeaponAnimation( Player, m79_throw );

- To block efficiently the original weapon animation and sounds, you should use m_flNextPrimaryAttack (46) offset instead of using the forward FM_UpdateClientData. The ideal is to use this offset in Ham_Item_Deploy one time. This offset is reset automatically when you switch on another weapon, so no need to reset manually.

const m_flNextPrimaryAttack = 46;
[...]
set_pdata_float( Player, m_flNextPrimaryAttack, 9999.0, 4 );

- Why do you use FM_PlayerPostThink when you use already FM_CmdStart ? Just use your code in this one and remove FM_PlayerPostThink.
- Why do you an ugly task and StatusText instead of using the original HUD ammo ?? You should use CurWeapon and AmmoX here. It will be far more efficient and readable. Plus the position of StatusText depends of a client cvar either in left bottom either in the center of your screen which is a pain.
-Instead of using FM_Touch/pfn_touch(), use register_touch() which allow you to register directly the toucher and touched classname. Classname which can be customs. So you can avoid a lot of unnecessary calls.
- For TE_EXPLOSION, use MSG_PAS. No need to show something to players who don't hear the explosion.
- For TE_SMOKE, use MSG_PVS, no need to show something to players who don't see the provided origin.
- get_maxplayers() ; save in a global var the value, because each time in the for(), this native is called.
- ScreenShake ; use MSG_ONE_UNRELIABLE. Also I think it's a bad idea to shake always whatever the distance. You should shake considering the distance and damage done by the explosion.
- To make damage, you should use Ham_TakeDamage and/or Ham_TraceAttack to show some blood.I see you calculate the distance but damage is still the same whatever the distance, it's wrong. And to killed someone use Ham_Killed with the last param 'ShouldGib' set to 2 ( It's GIB_ALWAYS in the HLSDK ). This way you don't need to emulate the explosion gib and blood, it will be done automatically and it's a lot better to let the engine doing its job.
- You should add more cvars to customize the plugin.

That's all for the moment. If you have questions, tell me.

[edit] By the way, since it's for Cs only, you should modify the "Modification".

[crazyeffect]

Do what Arkshine sais

I think it's a cool idea

[NiHiLaNTh]

Originally Posted by Arkshine - Why do you an ugly task and StatusText instead of using the original HUD ammo ?? You should use CurWeapon and AmmoX here. It will be far more efficient and readable. Plus the position of StatusText depends of a client cvar either in left bottom either in the center of your screen which is a pain.

Can you explain more about this(with example)
About other: I'm working on all you've said above

[eforie]

nice job.
But how can i modify *.sma to work with only CT buying ?
Only CT could buy this weapon.
Thank`s

[NiHiLaNTh]

Originally Posted by eforie nice job. But how can i modify *.sma to work with only CT buying ? Only CT could buy this weapon. Thank`s

open SMA and find following lines

// Buy attempt
public CmdBuyIt(id)
{
    // Plugin not enabled
    if (get_pcvar_num(pOn) == 0)
        return PLUGIN_CONTINUE
    
    // Ignore dead
    if (!is_user_alive(id))
        return PLUGIN_CONTINUE
        
    // Not in buyzone
    if (!cs_get_user_buyzone(id))
    {
        client_print(id, print_center, "You are not in buyzone")
        return PLUGIN_CONTINUE
    }

and after that add lines

if (cs_get_user_team(id) != CS_TEAM_CT)
      return PLUGIN_CONTINUE

[Arkshine]

Originally Posted by NiHiLaNTh Can you explain more about this(with example) About other: I'm working on all you've said above

I mean, if you weapon has 10 grenades, it should work and show in the Ammo HUD like :

1 | 9
I shoot.
0 | 8
I reload.
1 | 7
I shoot.
0 | 6
I reload.
1 | 5
etc..

And to update in the HUD, Clip (Ammo1) use CurWeapon message and for BpAmmo (Ammo2) use AmmoX message.

message_begin( MSG_ONE_UNRELIABLE, gMsgCurWeapon, .player = Player );
write_byte( true );
write_byte( CSW_XM1014 );
write_byte( Ammo1 )
message_end();

message_begin ( MSG_ONE_UNRELIABLE, gMsgAmmoX, .player = Player );
write_byte( CSW_XM1014 );
write_byte( Ammo2 );
message_end();

[tuty]

Originally Posted by Arkshine There are severals things you could change/improve : - You should write directly the weapon in register_event(), it will avoid the callback to be called for all weapons, each shots, thus avoiding unnecessary check. Code: register_event("CurWeapon", "Event_CurrentWeapon", "be", "1=1", "2=5") // 5 = CSW_XM1014 But I would prefer to use Ham_Item_Deploy from Hamsandwich since it's more appropriate and readable to change the model and play the animation at this time. - Where are the weapon animations ? Reload, deploy, throw and pullpin ? To play an animation, you should use something (I use fakemeta but feel free to use engine) : Code: UTIL_SendWeaponAnimation ( const Player, const Animation ) { set_pev( id, pev_weaponanim, i_Animation ); message_begin( MSG_ONE_UNRELIABLE, SVC_WEAPONANIM, .player = Player ); write_byte( Animation ); write_byte( pev( Player, pev_body ) ); message_end(); } You could use an enum to list the animation : Code: enum { m79_idle, m79_pullpin, m79_throw, m79_deploy }; // [...] // For example : UTIL_SendWeaponAnimation( Player, m79_throw ); - To block efficiently the original weapon animation and sounds, you should use m_flNextPrimaryAttack (46) offset instead of using the forward FM_UpdateClientData. The ideal is to use this offset in Ham_Item_Deploy one time. This offset is reset automatically when you switch on another weapon, so no need to reset manually. Code: const m_flNextPrimaryAttack = 46; [...] set_pdata_float( Player, m_flNextPrimaryAttack, 9999.0, 4 ); - Why do you use FM_PlayerPostThink when you use already FM_CmdStart ? Just use your code in this one and remove FM_PlayerPostThink. - Why do you an ugly task and StatusText instead of using the original HUD ammo ?? You should use CurWeapon and AmmoX here. It will be far more efficient and readable. Plus the position of StatusText depends of a client cvar either in left bottom either in the center of your screen which is a pain. -Instead of using FM_Touch/pfn_touch(), use register_touch() which allow you to register directly the toucher and touched classname. Classname which can be customs. So you can avoid a lot of unnecessary calls. - For TE_EXPLOSION, use MSG_PAS. No need to show something to players who don't hear the explosion. - For TE_SMOKE, use MSG_PVS, no need to show something to players who don't see the provided origin. - get_maxplayers() ; save in a global var the value, because each time in the for(), this native is called. - ScreenShake ; use MSG_ONE_UNRELIABLE. Also I think it's a bad idea to shake always whatever the distance. You should shake considering the distance and damage done by the explosion. - To make damage, you should use Ham_TakeDamage and/or Ham_TraceAttack to show some blood.I see you calculate the distance but damage is still the same whatever the distance, it's wrong. And to killed someone use Ham_Killed with the last param 'ShouldGib' set to 2 ( It's GIB_ALWAYS in the HLSDK ). This way you don't need to emulate the explosion gib and blood, it will be done automatically and it's a lot better to let the engine doing its job. - You should add more cvars to customize the plugin. That's all for the moment. If you have questions, tell me. [edit] By the way, since it's for Cs only, you should modify the "Modification".

it takes 10 mins for me to read this =]