[Potato Uno]

So I have this code that is ran every so often in a plugin:

PHP Code:

stock void UpdateWaveNumbers(bool update)
{
    while( ( iEnt = FindEntityByClassname(iEnt, "tf_objective_resource") ) != -1 )
    {
        CurrentWaveTemp = GetEntProp(iEnt, Prop_Send, "m_nMannVsMachineWaveCount");
        TotalWavesTemp = GetEntProp(iEnt, Prop_Send, "m_nMannVsMachineMaxWaveCount");
        GetEntPropString(iEnt, Prop_Send, "m_iszMvMPopfileName", PopFilePath, sizeof(PopFilePath));        
        break;
    }
} 


However, is it possible to do:

PHP Code:

public void OnMapStart()
{
    ObjectiveEntity = FindEntityByClassname(-1, "tf_objective_resource");
} 


So that I can ditch the while loop and do:

PHP Code:

stock void UpdateWaveNumbers(bool update)
{
    CurrentWaveTemp = GetEntProp(ObjectiveEntity, Prop_Send, "m_nMannVsMachineWaveCount");
    TotalWavesTemp = GetEntProp(ObjectiveEntity, Prop_Send, "m_nMannVsMachineMaxWaveCount");
    GetEntPropString(ObjectiveEntity, Prop_Send, "m_iszMvMPopfileName", PopFilePath, sizeof(PopFilePath));        
} 


In other words, from the map startup, is it possible for the tf_objective_resource entity index to change within a map? (Or possibly when the mvm mission is changed or wave is failed?)

Thanks!

[SoulSharD]

I doubt it'll change during map time.

However, all entities are reset on round start, so I'd move the 'FindEntityByClassname' to a round_start event just to be sure.

[Powerlord]

A few things:

1. As far as I'm aware, there's only going to be one tf_objective_resource entity at a time.
2. If you're concerned with the entity changing, you can store an entity reference instead by using EntIndexToEntRef. To check if a reference is still valid, use EntRefToEntIndex and see if it returns INVALID_ENT_REFERENCE.

[Mehis]

It shouldn't change. Not all entities are reset each round start. E.g, CSS ents

[Potato Uno]

In MvM a mapper told me that the map effectively resets if players fail a wave, and after doing some further inspection it looks like I was at the verge of falling into a premature optimization trap (messier code for a very negligible speed boost). So I decided to say "screw it" and not bother caching the entity index.

However this was useful:

Originally Posted by Powerlord A few things: As far as I'm aware, there's only going to be one tf_objective_resource entity at a time.

At least now I can do:

PHP Code:

stock void UpdateWaveNumbers(bool update) 
{ 
    int ObjectiveEntity = FindEntityByClassname(-1, "tf_objective_resource");
    CurrentWaveTemp = GetEntProp(ObjectiveEntity, Prop_Send, "m_nMannVsMachineWaveCount"); 
    TotalWavesTemp = GetEntProp(ObjectiveEntity, Prop_Send, "m_nMannVsMachineMaxWaveCount"); 
    GetEntPropString(ObjectiveEntity, Prop_Send, "m_iszMvMPopfileName", PopFilePath, sizeof(PopFilePath));         
} 


instead of a while loop, which now results in neater code. Thanks Ross!

[Benoist3012]

And complet what said powerlord, every entities related with the logic can be found in a map only one time if it's not a makers error, or halloween minigames, or payload hud