Originally Posted by Shao
An issue was found with godframes in game, I'll post the video here to be seen.
In short, the first clip and last have the plugin while the second doesn't use it. It seems that the plugin ignore certain situations. Getting fully pinned it doesn't happen but if saved quickly enough, godframes are ignored and friendly fire kicks in.
Smoker tongue pulls and Charger carries normally cause friendly-fire damage if you shoot the player being pulled/carried. I'm referring to the time when a Smoker is pulling a player but before they start choking them, and when a Charger is carrying a player but before they start pummeling them. Without a plugin, once the Smoker starts choking a player, or once the Charger starts pummeling a player, friendly-fire no longer happens, but it does happen before that while being pulled/carried.
In your first video clip it appears the Smoker was killed before it started choking the player, and although it is very close, it also appears in your third video clip the Charger was killed before it started pummeling the player. This means the grace period I put in for friendly-fire when choked/pummeled was not triggered and friendly-fire was reversed.
To be clear, the relevant hooks I used are "choke_stopped" and "charger_pummel_end". I did not put in a grace period for pulls and carries since those normally cause friendly-fire, so I just reverse it like any other friendly-fire.
In your second video clip it appears the engine is temporarily blocking damage to the victim immediately following the Smoker being killed without shooting the victim...even though I'm pretty sure it still triggered SDKHook_OnTakeDamage with a damage value.
It sounds like you would like an option for a brief grace period when pull/carry is interrupted before choke/pummel begins. Maybe also an option to disable ReverseFF when the victim is shot while being pulled/carried. Is this correct?