[ApoziX]

Hello

I got this code and I want the priority will be like that

If An Admin has entered the game then admin menu comes up

If VIP has entered the game then vip menu comes up

If Player has enter the game then menu comes up
+rep for helpers thanks

PHP Code:

#include <sourcemod>

public OnClientPutInServer(client)  
{ 
    CreateTimer(2.0, Timer_AutoShow, GetClientUserId(client), TIMER_FLAG_NO_MAPCHANGE);
} 

public IsValidClient( client ) 
{ 
    if ( !( 1 <= client <= MaxClients ) || !IsClientInGame(client) ) 
        return false; 
     
    return true; 
}
public Action:Timer_AutoShow(Handle:timer, any:userid) 
{ 
    new client = GetClientOfUserId(userid); 
    if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_kick", ADMFLAG_BAN))
    { 
        FakeClientCommandEx(client, "sm_admin");
    }
    
    if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_tag", ADMFLAG_CUSTOM6))
    { 
        FakeClientCommandEx(client, "sm_vip");
    }

    if(!IsPlayerAlive(client) || !IsValidClient(client))
    { 
        FakeClientCommandEx(client, "sm_menu");
    }
    return Plugin_Handled; 
} 


[HvG Community]

So whats wrong with this?

Just put else if on the last 2, instead of if statements and its all good.

[shanapu]

...or an return Plugin_Handled; behind the FakeClientCommandEx

edit: btw try to use new syntax

[ApoziX]

Originally Posted by shanapu ...or an return Plugin_Handled; behind the FakeClientCommandEx edit: btw try to use new syntax

I am not a pro coder bro I am tiny one

[ApoziX]

Originally Posted by HvG Community So whats wrong with this? Just put else if on the last 2, instead of if statements and its all good.

Not working

[shanapu]

No need to "be a pro" just put some afford in searching, reading & learning.

return Plugin_Handled;

Spoiler

PHP Code:

#include <sourcemod>

public void OnClientPutInServer(int client) // new syntax
{
    CreateTimer(2.0, Timer_AutoShow, GetClientUserId(client), TIMER_FLAG_NO_MAPCHANGE);
}

bool IsValidClient(int client) // new syntax
{
    if ( !( 1 <= client <= MaxClients ) || !IsClientInGame(client) )
        return false;

    return true;
}

public Action Timer_AutoShow(Handle timer, int userid) // new syntax
{
    int client = GetClientOfUserId(userid); // new syntax
    if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_kick", ADMFLAG_BAN))
    {
        FakeClientCommandEx(client, "sm_admin");
        return Plugin_Handled; // end function here, don't check later
    }

    if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_tag", ADMFLAG_CUSTOM6))
    {
        FakeClientCommandEx(client, "sm_vip");
        return Plugin_Handled; // end function here, don't check later
    }

    if(!IsPlayerAlive(client) || !IsValidClient(client))
    {
        FakeClientCommandEx(client, "sm_menu");
        return Plugin_Handled;
    }

    return Plugin_Handled;
} 


or
else if

Spoiler

PHP Code:

#include <sourcemod>

public void OnClientPutInServer(int client) // new syntax
{
    CreateTimer(2.0, Timer_AutoShow, GetClientUserId(client), TIMER_FLAG_NO_MAPCHANGE);
}

bool IsValidClient(int client) // new syntax
{
    if ( !( 1 <= client <= MaxClients ) || !IsClientInGame(client) )
        return false;

    return true;
}

public Action Timer_AutoShow(Handle timer, int userid) // new syntax
{
    int client = GetClientOfUserId(userid); // new syntax
    if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_kick", ADMFLAG_BAN))
    {
        FakeClientCommandEx(client, "sm_admin");
    }
    else if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_tag", ADMFLAG_CUSTOM6))
    {
        FakeClientCommandEx(client, "sm_vip");
    }
    else if(!IsPlayerAlive(client) || !IsValidClient(client))
    {
        FakeClientCommandEx(client, "sm_menu");
    }

    return Plugin_Handled;
} 


btw "Not working" (without any other info) is a very useless reply...

[ApoziX]

Originally Posted by shanapu No need to "be a pro" just put some afford in searching, reading & learning. return Plugin_Handled; Spoiler PHP Code: #include <sourcemod> public void OnClientPutInServer(int client) // new syntax {     CreateTimer(2.0, Timer_AutoShow, GetClientUserId(client), TIMER_FLAG_NO_MAPCHANGE); } bool IsValidClient(int client) // new syntax {     if ( !( 1 <= client <= MaxClients ) || !IsClientInGame(client) )         return false;     return true; } public Action Timer_AutoShow(Handle timer, int userid) // new syntax {     int client = GetClientOfUserId(userid); // new syntax     if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_kick", ADMFLAG_BAN))     {         FakeClientCommandEx(client, "sm_admin");         return Plugin_Handled; // end function here, don't check later     }     if(!IsPlayerAlive(client) || !CheckCommandAccess(client, "sm_tag", ADMFLAG_CUSTOM6))     {         FakeClientCommandEx(client, "sm_vip");         return Plugin_Handled; // end function here, don't check later     }     if(!IsPlayerAlive(client) || !IsValidClient(client))     {         FakeClientCommandEx(client, "sm_menu");         return Plugin_Handled;     }     return Plugin_Handled; }  That Thing did not work

[HvG Community]

Make the timer bit longer.
Also I noticed there are ! in the if statements. Why would you negate it?
Just check if he is alive OR has access to a command.
Also make sure you have VIP command installed that works so VIP can be opened to begin with (this is bit obvious one).

Same with the menu I gave you. It works with !help and !helpmenu not !menu, so change it to that.

And I would put && instead of || so both of them need to be correct.

Change sm_kick to sm_ban and sm_tag whatever that is to sm_vip.


IsValidClient, you dont even need that shit.

[ApoziX]

Originally Posted by HvG Community Make the timer bit longer. Also I noticed there are ! in the if statements. Why would you negate it? Just check if he is alive OR has access to a command. Also make sure you have VIP command installed that works so VIP can be opened to begin with (this is bit obvious one). Same with the menu I gave you. It works with !help and !helpmenu not !menu, so change it to that. And I would put && instead of || so both of them need to be correct. Change sm_kick to sm_ban and sm_tag whatever that is to sm_vip. IsValidClient, you dont even need that shit.

Bro I appreciate your work but On the other thread I wanted MY menu to be opened
I have configured the menu to be opened when typing !menu