[decowboy]

Hi guys,

I wrote a plugin and posted it on the forum yesterday.

This is the link:
https://forums.alliedmods.net/showthread.php?t=273251

I wrote some CS 1.6 plugins for AMX Mod X back in the day, but this is my first SourceMod plugin and my return to Pawn after many years.

I've been using the plugin on my own server for a couple of days and everything seems to work fine. Still there might be things that you would've done differently.

That's why I'm hoping that there are people out there who might be willing to briefly look through the code and give me feedback on it.

I'd be very thankful for your time.

[SoulSharD]

Looks nicely written to me.

One point, although there is absolutely NOTHING wrong with this: there's more comments than code.
Again, nothing wrong with that, very useful for someone who's learning from your source.

[Potato Uno]

My private plugins have a MINIMIUM comment:code ratio of 2:1. It is mandatory to prevent me from going insane with pawn.

[thecount]

I rarely use comments. I usually only use comments to help others that might read it. But your code seems good. I didn't see anything wrong in the quick look I took.

[decowboy]

Thanks for taking a look, guys! Really appreciate it.
I would agree the commenting is pretty extensive. I figured that if I was going to ask other people to have a look at the code, it'd be nice to at least make it easy to comprehend.

Do you see any reason why this code wouldn't work for CS:Source? I unfortunately have no experience with that game, so I can't tell for sure.

[Drixevel]

I don't bother to comment out code unless I need to remember something in particular of I need to remember what my mindset while making the code was.

[Maxximou5]

For work and for sourcemod, my rule is as following: If your code needs a comment, code it again so it doesn't need that comment.

There are always exceptions though.

[headline]

Originally Posted by Maxximou5 For work and for sourcemod, my rule is as following: If your code needs a comment, code it again so it doesn't need that comment. There are always exceptions though.

I like that, thank you

[Miu]

At lines 83 and 91 you save the same cvar twice.

You can register a new command at line 207, and although you can't unregister the old one, you can find the command used to call the command callback with GetCmdArg on the 0th argument and do nothing if it's not the current command.

At line 222 you check if PluginActive() is nonzero before announcing, but I'm guessing you want to check if PluginActive() == TOGGLE_ACTIVE, since two other inactive states are also nonzero.

At line 703 you use the constant 1 rather than TOGGLE_ACTIVE, although your comment retains the information.

At line 744 you unnecessarily retrieve the toggle command from the cvar.

At lines 753 and 758 the 1 char long string togglePrepend is referenced as a zero-terminated string, but if it holds only '!', it's not zero-terminated, and it'll overrun the buffer. It needs to be at least 2 chars long to hold a character and a null. You can also use an inline ternary:

PHP Code:

PrintToChat(client, ">> Want to play without bots? Say: %s%s", GetConVarInt(sm_bot_toggle_chat) != 1 ? "!" : "", toggleCommand); 


You can do the same thing around line 435 instead of incrementing it:

PHP Code:

PrintToChat(client, "You need to wait %d second%s before disabling bots.", cooldownRemaining, cooldownRemaining > 1 ? "s" : ""); 


At line 414 processToggle never needs to return different values, so there's no point in having a return value.

You also sorta mix new and old syntax all over but it doesn't matter I guess.

[SM9]

It seems you are using a mixture of transitional and old syntax. Over use of spaces, Could improve the variable names, Too many comments.

#include <sourcemod> is not required.

Hope that's some help.