[Depresie]

So i am wondering about couple things regarding efficiency
Any idea which method listed in each case would be more efficient?

Case 1

PHP Code:

//Called once for 32 players at spawn
public HamSpawn(id)
{
    if(!task_exists(id))
    {
        set_task(0.1, "handle_function", id)
    }
}

// Not being called often
public HamKilled(id)
{
    if(!task_exists(id))
    {
        set_task(0.1, "handle_function", id)
    }
}

// Called alot for 32 players
public HamDamage(id)
{
    if(!task_exists(id))
    {
        set_task(0.1, "handle_function", id)
    }
}

public handle_function(id)
{
    cs_set_user_money(id, 1500, 1)
} 


VS

PHP Code:

public plugin_cfg()
{
    set_task(0.1, "handle_function", TASKID, _, _, "b")
}

// Called once every 0.1 seconds
public handle_function(TASKID)
{
    new iPlayers[32] , iNum , Player;
    get_players( iPlayers , iNum , "h" );
    
    for ( new i = 0 ; i < iNum ; i++ )
    {    
        Player = iPlayers[i];
        
        cs_set_user_money(Player, 1500, 1)
    }
} 


Case 2

PHP Code:

// 32 Tasks on full server
public client_putinserver(id)
{
    set_task(0.1, "handle_function", id, _,_, "b")
}

// Called 32 times every 0,1 seconds
public handle_function(id)
{
    function(id)
} 


VS

PHP Code:

// 1 Task at any time
public plugin_cfg()
{
    set_task(0.1, "handle_function", TASKID, _,_, "b")
}

// Called once every 0,1 seconds
public handle_function(TASKID)
{
    new iPlayers[32] , iNum , Player;
    get_players( iPlayers , iNum , "h" );
    
    for ( new i = 0 ; i < iNum ; i++ )
    {    
        Player = iPlayers[i];
        
        // Called 32 times
        function(Player)
    }
} 


[Bos93]

if you want always 1500 money, more efficient set in AddAccount

[Depresie]

I do not want to set always 1500 money, it was just an example

[HamletEagle]

You need to define "a lot". Anything that is not called per frame is not a lot. 0.1 task is purely overkill. Also a task in which you loop all players is better than 32 tasks.

But this is general information, you better tell us what you exactly want to do.

[Depresie]

Ahm, kind of complicated to explain..

I need to update the cs money with values stored in an array ( g_Money[33] )

I need to update it often since players recieves money everytime they damage or kill other players

I also need to do it with a little delay to avoid some inconviniences

I will try to write below the full story in the following minutes

[Bos93]

Update in Ham_TakeDamage, Ham_Killed, Round_Start

[Depresie]

I don't know how to explain it with words in order for you guys to understand, but this may give you an idea

PHP Code:

new g_Money[33]

new g_MsgMoney

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    register_event("Money", "event_money", "b")
    g_MsgMoney = get_user_msgid("Money")
}

public handle_money_event(id)
{
    // This will block any engine money rewards
    set_msg_block(g_MsgMoney, BLOCK_SET)
}

// We update the money hud with a little delay to avoid having written in the money flash hud incorrect values
public client_putinserver(id)
{
    g_Money[id] = get_cvar_num("mp_startmoney")
    set_task(0.1, "UpdateMoney", id)
}

public OnDamage(victim, attacker, etc)
{
    g_Money[attacker] += damage
    set_task(0.1, "UpdateMoney", id)

}

public OnKill(victim, attacker, etc)
{
    g_Money[attacker] += 500
    set_task(0.1, "UpdateMoney", id)
    
}

public OnSpawn(id)
{
    // This will manually update the money hud at spawn, since the automatic update is blocked above in the money event
    set_task(0.1, "UpdateMoney", id)
}

public UpdateMoney(id)
{
    cs_set_user_money(id, g_Money[id], 1)
} 


I am wondering if it wouldn't be better to do it with a global task and player loop since to avoid the big number of frequent tasks and checks from the take damage event

PHP Code:


new g_Money[33]

new g_MsgMoney

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    register_event("Money", "event_money", "b")
    g_MsgMoney = get_user_msgid("Money")
}

public plugin_cfg()
{
    set_task(0.1, "UpdateMoney", id, _,_, "b")
}

public handle_money_event(id)
{
    set_msg_block(g_MsgMoney, BLOCK_SET)
}

public client_putinserver(id)
{
    g_Money[id] = get_cvar_num("mp_startmoney")
}

public OnDamage(victim, attacker, etc)
{
    g_Money[attacker] += damage
}

public OnKill(victim, attacker, etc)
{
    g_Money[attacker] += 500
}


public UpdateMoney()
{
    new iPlayers[32] , iNum , Player;
    get_players( iPlayers , iNum , "h" );
    
    for ( new i = 0 ; i < iNum ; i++ )
    {    
        Player = iPlayers[i];
       cs_set_user_money(Player, g_Money[Player], 1)
    }
    
} 


[klippy]

Why don't you just hook Money message and alter it to display your preferred value and then set money in there?

[Depresie]

Because i need to set rewards for damage and kill using cs_set_user_money and it doesn't trigger the money event or message, i have tried

Also above i went with the looping every 0.25 seconds, it's cleaner, and i think its better than 32 tasks and checks for task existence in take damage

I know it's an overkill to call a task so often, but i want to keep the money hud flash effect in sync