[Benjamin1995]

Hello,

i made a Plugin for Roleplay and other server it is a Admin Connect Plugin with sound there are just 3 Command



//Dont use sound/ just the supfolder!!!

sm_deletejoinsound <name>
example: sm_deletejoinsound benni

//For Admins:
sm_setjoinsound <name> <sound>
example: sm_setjoinsound benni "bennisounds/admingsb.mp3"

//For every player Players:
sm_setcustomjoinsound <name> <sound>
example: sm_setcustomjoinsound benni "bennisounds/admingsb.mp3"

//For Roleplay:
sm_setcopjoinsound <name> <sound>
example: sm_setcopjoinsound benni "bennisounds/admingsb.mp3"

//Picture:

PHP Code:

-->Fixed Warnings<-- 


I think it will work for every Mod

Have Fun
Benni

[almcaeobtac]

Nice plugin

[exvel]

You should use zip instead of rar.
Anyway, plugin looks good.

[Benjamin1995]

Mhhhhh
Ok ichange it to Zip

[kiwi87]

//For Admins:
sm_setjoinsound <name> <sound>
example: sm_setjoinsound benni "bennisounds/admingsb.mp3"

//For every player Players:
sm_setcustomjoinsound <name> <sound>
example: sm_setcustomjoinsound benni "bennisounds/admingsb.mp3"


I don't under stand. For all player join sound why is it sm_setcustomjoinsound <name??> <sound>

[Benjamin1995]

mhhh ya mhhh
sm_setjoinsound = just for admin
and custom are for all that you want give a join sound

[kiwi87]

So for every player is it like this?
//For every player Players:
sm_setcustomjoinsound <name> <sound>
example: sm_setcustomjoinsound @all "bennisounds/admingsb.mp3" ???

[berni]

• Sounds are not getting downloaded when you connect, so it's useless.
• This plugin is bloated and uses the same code again and again, you should encapsulate in functions
• What is the difference between the commands ?
• You should make a config for the joinsounds
• Path variables should use the constant PLATFORM_MAX_PATH
• use MaxClients instead of GetMaxClients() in loops
• There are 16 warnings on compile that should be fixed.

connect.sp(60) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(61) : warning 203: symbol is never used: "ClientName" connect.sp(157) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(15 : warning 203: symbol is never used: "ClientName" connect.sp(257) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(25 : warning 203: symbol is never used: "ClientName" connect.sp(355) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(356) : warning 203: symbol is never used: "ClientName" connect.sp(477) : warning 219: local variable "SteamId" shadows a variable at a preceding level connect.sp(47 : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(49 : warning 219: local variable "SteamId" shadows a variable at a preceding level connect.sp(499) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(517) : warning 217: loose indentation connect.sp(519) : warning 219: local variable "SteamId" shadows a variable at a preceding level connect.sp(520) : warning 219: local variable "Sound" shadows a variable at a preceding level connect.sp(24) : warning 203: symbol is never used: "Sound"

Greetings, ~Berni

[Benjamin1995]

Mkay its true but this plugin was a thing from 25 mins........
I need to add a autodownloader i just made it for my server......
than a friend said to me upload it^^

[berni]

Well, you either fix it or it get's unapproved, it's your choice