Raised This Month: $51 Target: $400
 12% 

ChatLog v1.3.7 (Extended)


Post New Thread Reply   
 
Thread Tools Display Modes
cns
Junior Member
Join Date: Apr 2009
Old 05-24-2009 , 16:16   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #41

Quote:
Originally Posted by muukis View Post
Can you run that query from your MySQL console?
I ran the query on my MySQL database and the entry got added to the table without any problems.

Quote:
Originally Posted by muukis
What version of SourceMod are you running?
Code:
SourceMod Version Information:
             SourceMod Version: 1.2.0
             SourcePawn Engine: SourcePawn 1.1, jit-x86 (build 1.2.0)
             SourcePawn API: v1 = 4, v2 = 3
             Compiled on: Mar  5 2009 02:18:22
             Build ID: 2652:0ae7d8ab1de7
             http://www.sourcemod.net/
Same as you.
cns is offline
Icettiflow
Senior Member
Join Date: Jan 2009
Old 06-09-2009 , 15:31   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #42

Code:
L 06/09/2009 - 10:02:14: SourceMod error session started
L 06/09/2009 - 10:02:14: Info (map "l4d_hospital01_apartment") (file "errors_20090609.log")
L 06/09/2009 - 10:02:14: [SM] Native "GetEventString" reported: Invalid game event handle 2ab02a0 (error 5)
L 06/09/2009 - 10:02:14: [SM] Displaying call stack trace for plugin "chatlogex.smx":
L 06/09/2009 - 10:02:14: [SM]   [0]  Line 299, /home/groups/alliedmodders/forums/files/5/2/0/8/2/42128.attach::LogPlayerConnect()
L 06/09/2009 - 10:02:14: [SM] Native "GetEventString" reported: Invalid game event handle 2a902a2 (error 5)
L 06/09/2009 - 10:02:14: [SM] Displaying call stack trace for plugin "chatlogex.smx":
L 06/09/2009 - 10:02:14: [SM]   [0]  Line 299, /home/groups/alliedmodders/forums/files/5/2/0/8/2/42128.attach::LogPlayerConnect()
L 06/09/2009 - 11:57:11: SourceMod error session started
L 06/09/2009 - 11:57:11: Info (map "l4d_hospital01_apartment") (file "errors_20090609.log")
L 06/09/2009 - 11:57:11: [chatlogex.smx] ChatLogEx: Cannot log message, handle hdatabase is not set!
L 06/09/2009 - 11:57:14: Error log file session closed.
L 06/09/2009 - 11:57:17: SourceMod error session started
L 06/09/2009 - 11:57:17: Info (map "l4d_airport01_greenhouse") (file "errors_20090609.log")
L 06/09/2009 - 11:57:17: [SM] Native "GetEventString" reported: Invalid game event handle 2b602a1 (error 5)
L 06/09/2009 - 11:57:17: [SM] Displaying call stack trace for plugin "chatlogex.smx":
L 06/09/2009 - 11:57:17: [SM]   [0]  Line 299, /home/groups/alliedmodders/forums/files/5/2/0/8/2/42128.attach::LogPlayerConnect()
L 06/09/2009 - 11:57:17: [SM] Native "GetEventString" reported: Invalid game event handle 2b402a3 (error 5)
L 06/09/2009 - 11:57:17: [SM] Displaying call stack trace for plugin "chatlogex.smx":
L 06/09/2009 - 11:57:17: [SM]   [0]  Line 299, /home/groups/alliedmodders/forums/files/5/2/0/8/2/42128.attach::LogPlayerConnect()
L 06/09/2009 - 12:02:02: Error log file session closed.
Icettiflow is offline
muukis
Veteran Member
Join Date: Apr 2009
Old 06-10-2009 , 03:19   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #43

Quote:
Originally Posted by Icettiflow View Post
...
I know about this problem already, but thanks anyways . Currently the player counter fails at the beginning of a map. I am looking in to it...
muukis is offline
HSFighter
Veteran Member
Join Date: Aug 2007
Location: Flensburg - Germany
Old 06-16-2009 , 13:07   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #44

For the First: Nice work Nephyrin & muukis

The Sourcemod Webadmin supporting now this Plugin:

__________________



Sorry for my very bad english
Greetings HSFighter

Last edited by HSFighter; 06-16-2009 at 13:30.
HSFighter is offline
Send a message via ICQ to HSFighter
krolus
Senior Member
Join Date: May 2009
Location: Russia, Omsk
Old 06-18-2009 , 00:12   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #45

i think by default in cfg\sourcemod\sm_chatlogex.cfg string sm_chatlogex_id "" must be commented, because it's overwriting sm_chatlogex_id in server.cfg

[edit]
Why you don't use variable MaxClients instead of 4 cvar's (sm_chatlogex_mpcoop,sm_chatlogex_mpversus and others)?

[edit2]
remove logerrors on invalid srvid, it's spamming in logs. I think one LogError on plugin start is enough.

Last edited by krolus; 06-18-2009 at 03:23.
krolus is offline
muukis
Veteran Member
Join Date: Apr 2009
Old 06-18-2009 , 03:36   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #46

Quote:
Originally Posted by krolus View Post
i think by default in cfg\sourcemod\sm_chatlogex.cfg string sm_chatlogex_id "" must be commented, because it's overwriting sm_chatlogex_id in server.cfg

[edit]
Why you don't use variable MaxClients instead of 4 cvar's (sm_chatlogex_mpcoop,sm_chatlogex_mpversus and others)?

[edit2]
remove logerrors on invalid srvid, it's spamming in logs. I think one LogError on plugin start is enough.
I'm not sure how to comment an autogenerated configuration or is it possible. Leaving it completely out of the config will probably cause more trouble than leaving it in uncommented (at least for the new users)? I should probably write a comment about where to edit the value in the error log?

MaxClients gives me 64 all the time... I think? I knew there was a cvar for this but never found it... I will try this though - thanks!

You are right about the errorlog spamming: I will modify that.
muukis is offline
krolus
Senior Member
Join Date: May 2009
Location: Russia, Omsk
Old 06-18-2009 , 04:29   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #47

Yeah, you should write a comment about it. But if you can remove cvar's like _mpcoop then cfg file will be unnecessary.

Huh. In tf2 MaxClients gives me correct number. Check cvar sv_visiblemaxplayers.

Btw, on my server (tf2) message about connected players writing in log 2 times(duplicate), about disconnected 1 time(it's normal). I don't know how to fix it and just remove hooks on player_connect and player_disconnect. Maybe you shoud add cvar to enable/disable logging player connect/dissconnect.

Last edited by krolus; 06-18-2009 at 05:06.
krolus is offline
muukis
Veteran Member
Join Date: Apr 2009
Old 06-18-2009 , 09:05   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #48

MaxClients gives me a value of 16 on my L4D server. sv_visiblemaxplayers = "-1".

Here's a new version for you to test. On my server it seems to be doing it's job well enough. I don't have currently the time to test it more properly.

New feature:
L4D: Show set difficulty level of a co-op map. => "Map started (coop:impossible:l4d_hospital01_apartment)"

Fixed:
No more error spamming when the sm_chatlogex_id is not set.

New cvars:
Code:
sm_chatlogex_showplayercon = CreateConVar("sm_chatlogex_showplayercon", "1", "1 [default] causes ChatLogEx to log server messages when player connects or disconnects. Effects the visibility of showing how many players are connected to the server. Does not override sm_chatlogex_srvmsgs.");
sm_chatlogex_mpusemaxclients = CreateConVar("sm_chatlogex_mpusemaxclients", "1", "1 [default] max players are taken from MaxClients property. This value is displayed on 'players online' messages.");

Last edited by muukis; 06-22-2009 at 06:28. Reason: Removed attachment (read first post)
muukis is offline
dekken
Veteran Member
Join Date: Jul 2007
Old 06-21-2009 , 06:34   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #49

Please fix the XSS issues and what not..
by typing <script>alert(5555)</script>
In the game chat it would pop up an alert in the web interface.
If I would understand sourcemod scripting I would strip everything myself...but I have no idea

So a simple fix for the php is:
PHP Code:
    $text $R['text'];
    
$text htmlspecialchars($textENT_QUOTES); 
in the "function formatRow($R)" section.
below the database settings.
__________________
Signature Goes Here
dekken is offline
muukis
Veteran Member
Join Date: Apr 2009
Old 06-22-2009 , 02:59   Re: ChatLog v1.3.4 (Extended)
Reply With Quote #50

Quote:
Originally Posted by dekken View Post
...
You are correct. The player names were vulnerable as well. Thanks for bringing this out.

It's best to do in the PHP and not manipulate messages or the player names before storing them in DB.

First post updated.
muukis is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 04:37.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode