[n0br41ner]

Nice suggestion. Maybe i eill add this but you have to wait until the 6th January since i will traveling abroad from today till the 6th.

[DPT]

I understand from your code that auto blackout should be triggered by amx_scanips.. Am I correct?

In other words, the blackout of same ips won't work unless someone issues the amx_scanips... So, blacking out same ip players wouldnt start automatically unless someone issues the amx_scanips command. Right?

[n0br41ner]

It will automatically blackout players that have the same ip only if the correct cvar is set to one. Amx_scanips will only print the names of the players, it has nothing to do with blacking out the players.

[DPT]

I don't know why its not blacking out players who have the same ip in my server. I have set amx_blackout 1 but still nothing happens.

From your code:

PHP Code:

 public BlackoutOnDeath( ) {
 g_iDeadPlayer = read_data( 2 );
 
 if( g_Blackout && g_bSameIPs[g_iDeadPlayer] && !is_user_alive( g_iDeadPlayer ) ) { 


the if condition mentions the g_bSameIPs[g_iDeadPlayer] variable. I don't see any other part in the whole code that initiates and assigns a value to g_bSameIPs except in the ScanIP procedure. This means that if amx_scanips wasn't executed, the g_bSameIPs variable would remain blank meaning that the automatic blackout wouldnt work.

Do you know what I mean?

If there's something that im missing out, please let me know.

Thanks

[n0br41ner]

Yes i know what you meant. If i recall correctly i tested it the first time i made this and it worked. But then later i tries to use bits instead instead bools to try and make it more efficient but i did not succeed. Maybe thats where i have made a mistake. Anyway, when i get back from france i will be checking this again and make it better and add some of the suggestions.

By the way can you please tell me how did you try and test it?

By the way thank tou for your report.

[DPT]

Alright I just tested your plugin again in the server, there are two problems in your code.

First, change this:

PHP Code:

get_user_ip( tempid, g_iPlayersIPs[tempid], charsmax( g_iPlayersIPs[] ) ); 


To this:

PHP Code:

get_user_ip( tempid, g_iPlayersIPs[tempid], charsmax( g_iPlayersIPs[] ), 1 ); 


This will remove the port from the ip address (sometimes players join from different remote ports).. Now IP matching will be correct.

For example:

Player A ip is: 217.60.21.5:27005

Player B ip is: 217.60.21.5:27006

Your code sees that those ips are not identical because of the port number. With the new code i gave you above, it will solve this problem by removing the port from the ip address.


Second, as I told you previously, the blacking out will only work if someone issues the amx_scanips command.

You want the plugin to automatically black out screens of same ips even if no one issues the amx_scanips command.

You need to do something like including the ScanIPs procedure in the Refresh procedure or anything similar.

If you allow me, I will correct your code and post it here and then you may update your thread with the new fixed code. Overall, nice job

[n0br41ner]

Thank you very much. And yes please do so as a temporary fix until i get home one the 6th. I am no where near a computer at this time, i am posting from iPhone right now.

Again thank you ver much.

[DPT]

Alright.. I already fixed the problems.. Do you want me to include an option (cvar) to avoid admins from being blacked out?

[n0br41ner]

Sure why not.
Thanks again

[isotonic]

It is a huge disappointment for me All that time from previous release I was sure that everything works fine.
Please post the fix ASAP. Otherwise I have to make it by my own. Players with the same IPs play too frequently on our servers.