[Owyn]

here, i uploaded my custom files, mb with it demo will play. if not i'll make fraps, but which quality? if high it will be a lot of megabytes
http://webfile.ru/2602199

[Bugsy]

I found a bug that may have been causing the plugin to not detect an aimbot. This bug is not linked to my plugin, it looks like its a bug within amxmodx in get_user_attacker hitzones.

I was doing testing today and noticed, at times, I can shoot the bot multiple times, yet I go undetected. The bot is definitely being shot because blood pours out with each shot. I added a line of code to output where the bot is shot and each time it is HIT_GENERIC. I can then reconnect or do a mapchange, and the hitzones register properly and show the actual hitzone. I have attached a demo to show you. Place in your cstrike dir to play

This is the print code

PHP Code:

public fw_HamTakeDamage(victim, inflictor, attacker, Float:fDamage, bitDamage) 
{     
    if( !g_PlayerToWatch || !g_BotID || !( 1 <= attacker <= g_MaxPlayers ) || !( 1 <= victim <= g_MaxPlayers ) || is_user_bot(attacker) || !get_pcvar_num(g_pcvar_enabled) )
        return HAM_IGNORED
    
    //If bot exists, the person issuing the damage is the watched player, and damage is done via bullet.
    if( ( victim == g_BotID ) && (attacker == g_PlayerToWatch)  && (bitDamage & DMG_BULLET))
    {
        new iGun
        new iHitzone

        //This function is called to retrieve what body-parts of the bot shot and the weapon the attacker was using.
        get_user_attacker( victim , iGun, iHitzone )
        
        #if defined TESTING
            switch( iHitzone )
            {
                case 0: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Generic" )
                case 1: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Head" )
                case 2: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Chest" )
                case 3: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Stomach" )
                case 4: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Left Arm" )
                case 5: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Right Arm" )
                case 6: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Left Leg" )
                case 7: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = Right Leg" )
                default: client_print( g_PlayerToWatch , print_chat,"*[Testing] Hit = ?????" )
            } 


[Bugsy]

Version 1.1 in the main page.

[flintridge]

Originally Posted by Bugsy Version 1.1 in the main page.

Sweet, just dl'ed it and installed it now, i let you know if i have any issues to report.

[Bugsy]

I am experimenting with preventing a bot spawn if the bot will be spawned in a location where there is a wall\object between watched player and the bot. (the bots origin is victim origin). If the origin comes back as not in line of sight, does that mean that not a single part of the object is visible or just the center of it?

Can anyone comment on if this is the proper\efficient way to do it?

PHP Code:

if( !is_in_line_of_sight( iVictimOrigin, iWatchedOrigin , 1 ))
{
    //cannot spawn bot, wall\object in the way
                        
    return HAM_IGNORED
} 


PHP Code:

public is_in_line_of_sight(origin1[3], origin2[3], ignore_players)
{
    new Float:fOrigin1[3];
    new Float:fOrigin2[3];
    new trace = 0
    IVecFVec(origin1,fOrigin1 );
    IVecFVec(origin2,fOrigin2 );
    
    engfunc(EngFunc_TraceLine, fOrigin1, fOrigin2, (ignore_players ? IGNORE_MONSTERS : DONT_IGNORE_MONSTERS), 0, trace)
    
    new Float:fraction
    get_tr2(trace, TR_flFraction, fraction)
    
    return (fraction == 1.0) ? 1 : 0
} 


[flintridge]

Originally Posted by Bugsy I am experimenting with preventing a bot spawn if the bot will be spawned in a location where there is a wall\object between watched player and the bot. (the bots origin is victim origin). If the origin comes back as not in line of sight, does that mean that not a single part of the object is visible or just the center of it? Can anyone comment on if this is the proper\efficient way to do it?

I am curious why would you want to stop the bot from spawning if there was a wall or object inbetween, would not the aim bot FoV still shoot it even if there was something inbetween?

I do understand that if your above the the person you would not want it to spawn since you would kill it anyways.

[Bugsy]

Originally Posted by flintridge I am curious why would you want to stop the bot from spawning if there was a wall or object inbetween, would not the aim bot FoV still shoot it even if there was something inbetween? I do understand that if your above the the person you would not want it to spawn since you would kill it anyways.

Because not all weapons can shoot through walls and the bot needs to be hit for a detection to occur. If it is not possible for the bot to be shot, I don't want to spawn the it and possibly let the player become aware that something is going on.

[leonardofilipemartins]

To improve your plugin performance (you all can use this as a good programming habits lesson):

1 - Add these globals

PHP Code:

new HamHook:g_Ham_TakeDamage;
new HamHook:g_Ham_Killed_Player; 


2 - Change your plugin_init from:

PHP Code:

RegisterHam(Ham_Killed,     "player",  "func_Ham_Killed_Player")
RegisterHam(Ham_TakeDamage, "player" , "func_Ham_TakeDamage") 


to:

PHP Code:

g_Ham_Killed_Player = RegisterHam(Ham_Killed,"player",  "func_Ham_Killed_Player")
g_Ham_TakeDamage = RegisterHam(Ham_TakeDamage, "player" ,"func_Ham_TakeDamage")
    
DisableHamForward(g_Ham_Killed_Player);
DisableHamForward(g_Ham_TakeDamage); 


3 - Add to your Addbot function after checking if the bot was sucessful created:

PHP Code:

EnableHamForward(g_Ham_TakeDamage) 


4 - Change your RemoveBot function:

PHP Code:

if( g_BotID )
    {
        DisableHamForward(g_Ham_TakeDamage);
    ... 


5 -Create these functions:

PHP Code:

doWatchPlayer(id)
{
  g_PlayerToWatch = id
  EnableHamForward(g_Ham_Killed_Player);
}
undoWatchPlayer(id)
{
 g_PlayerToWatch = 0;
 DisableHamForward(g_Ham_Killed_Player);
} 


6 - Use the above functions

[Pamaliska]

BTW, I believe this is the right ban string for AMXBANS:

server_cmd( "amx_ban %d #%d Aimbot Detected" , BAN_TIME , get_user_userid( attacker))

for some reason "amx_aimstatus" only returned 14 players (there were 30 on the server)

[Owyn]

I believe this is the right ban string for AMXBANS:

is not ;) cuz there are 4 arguments in your string