[Doc-Holiday]

So using my battle field plugin when i plant/defuse/explode the bomb it lags. and then it resumes where it left off.

Below is all the code involved with the bomb planting.

PHP Code:

public ePlanted()
{
    if(!g_Cvar2[CVAR_ENABLED])
        return PLUGIN_HANDLED;
        
    for(new i = 1; i <= g_iMaxPlayers; ++i)
    {
        if(!IsPlayer(i))
            return PLUGIN_HANDLED;
        
        if(is_user_alive(i) && get_user_team(i) == 1)
        {
            is_alive[i] = true;
            g_XP[i][XP][g_XP[i][Class]] += get_pcvar_num(g_Cvar2[CVAR_PLANTBONUS]);
            set_hudmessage(0, 255, 50, 0.50, 0.33, 1, 2.0, 2.0);
            ShowSyncHudMsg(i, gHudSyncXp, "+ %d", get_pcvar_num(g_Cvar2[CVAR_PLANTBONUS]));
        }
        bBombPlanted = true;
        CheckLevel(i);
    }
    return PLUGIN_CONTINUE;
}

public eDefused()
{
    if(!g_Cvar2[CVAR_ENABLED])
        return PLUGIN_HANDLED;
        
    for(new i = 1; i <= g_iMaxPlayers; ++i)
    {
        if(!IsPlayer(i))
            return PLUGIN_HANDLED;
            
        if(is_user_alive(i) && get_user_team(i) == 2)
        {
            g_XP[i][XP][g_XP[i][Class]] +=  get_pcvar_num(g_Cvar2[CVAR_DEFUSEBONUS]);
            is_alive[i] = false;
            ShowSyncHudMsg(i, gHudSyncXp, "+ %d", get_pcvar_num(g_Cvar2[CVAR_DEFUSEBONUS]));
        }
        CheckLevel(i);
    }
    return PLUGIN_CONTINUE;
}

public eExplosion()
{
    if(!g_Cvar2[CVAR_ENABLED])
        return PLUGIN_HANDLED;
        
    for(new i = 1; i <= g_iMaxPlayers; ++i)
    {
        if(!IsPlayer(i))
            return PLUGIN_HANDLED;
        
        if(is_alive[i] && get_user_team(i) == 1)
        {
            g_XP[i][XP][g_XP[i][Class]] +=  get_pcvar_num(g_Cvar2[CVAR_EXPBONUS]);
            is_alive[i] = false;
            ShowSyncHudMsg(i, gHudSyncXp, "+ %d", get_pcvar_num(g_Cvar2[CVAR_EXPBONUS]));
        }
        CheckLevel(i);
    }
    return PLUGIN_CONTINUE;
}

public eTargetSaved()
{
    if(!g_Cvar2[CVAR_ENABLED])
        return PLUGIN_HANDLED;
        
    for(new i = 1; i <= g_iMaxPlayers; ++i)
    {
        if(!IsPlayer(i))
            return PLUGIN_HANDLED;
            
        if(is_user_alive(i) && get_user_team(i) == 2)
        {
            g_XP[i][XP][g_XP[i][Class]] +=  get_pcvar_num(g_Cvar2[CVAR_TARGSAVBONUS]);
            ShowSyncHudMsg(i, gHudSyncXp, "+ %d", get_pcvar_num(g_Cvar2[CVAR_TARGSAVBONUS]));
        }
        CheckLevel(i);
    }
    return PLUGIN_CONTINUE;
} 


[Sylwester]

I grant you an award for the most inefficient way of saving data of the year:

PHP Code:

public ePlanted(){  //, eDefused(), eExplosion(), eTargetSaved()
    for(new i = 1; i <= g_iMaxPlayers; ++i){
        //...
        CheckLevel(i); // <---- THIS
    }
} 

public CheckLevel(id){
    //...
    SaveData(id); // <------ THIS
}

public SaveData( id ){
    if(sqlv_connect(g_hVault)){
        new iPos, szSave[(XPDATA * 10) + 1];
        for (new i = 0 ; i < XPDATA ; i++){
            iPos += formatex(szSave[iPos] ,charsmax(szSave) , "%10d" , g_XP[id][i]);
            sqlv_set_data(g_hVault, g_szAuthID[id], szSave); // < ------ THIS
            //seriously, why is sqlv_set_data in this loop?
        }
        sqlv_disconnect(g_hVault);
    }
    //...
} 


If you don't understand, then (for example on 32 players server) in each of those functions (ePlanted, eDefused, eExplosion, eTargetSaved) you send 320 (non-threaded) queries to sql database...

[Doc-Holiday]

Originally Posted by Sylwester I grant you an award for the most inefficient way of saving data of the year: PHP Code: public ePlanted(){  //, eDefused(), eExplosion(), eTargetSaved()     for(new i = 1; i <= g_iMaxPlayers; ++i){         //...         CheckLevel(i); // <---- THIS     } }  public CheckLevel(id){     //...     SaveData(id); // <------ THIS } public SaveData( id ){     if(sqlv_connect(g_hVault)){         new iPos, szSave[(XPDATA * 10) + 1];         for (new i = 0 ; i < XPDATA ; i++){             iPos += formatex(szSave[iPos] ,charsmax(szSave) , "%10d" , g_XP[id][i]);             sqlv_set_data(g_hVault, g_szAuthID[id], szSave); // < ------ THIS             //seriously, why is sqlv_set_data in this loop?         }         sqlv_disconnect(g_hVault);     }     //... }  If you don't understand, then (for example on 32 players server) in each of those functions (ePlanted, eDefused, eExplosion, eTargetSaved) you send 320 (non-threaded) queries to sql database...

That would explain the lag haha... I dont know anything about sql or vault for that matter. The saving stuff is from bugzy and my original xp mod.

PHP Code:

public SaveData( id )
    {
        if(sqlv_connect(g_hVault))
        {
            new iPos, szSave[(XPDATA * 10) + 1];
            
            for (new i = 0 ; i < XPDATA ; i++)
            {
                iPos += formatex(szSave[iPos] ,charsmax(szSave) , "%10d" , g_XP[id][i]);
            }
            sqlv_set_data(g_hVault, g_szAuthID[id], szSave);
            
            sqlv_disconnect(g_hVault);
        }
        else
        {
            set_fail_state("Error Connecting to SQLVault");
        }
    } 


Removed it from the loop and it seems to be working fine now. Thank you.

[Emp`]

First thing you should do is only CheckLevel when someone's xp is changed. That will reduce about half of the saving.

If you need to use sql saving, then you should change to Threaded Queries. This will allow your sql queries to be run in the background and not freeze the server waiting for responses from all your queries.

If you do not need to use sql, I would suggest you change to a non-sql vault; it will highly reduce the time to save data.

[Doc-Holiday]

Originally Posted by Emp` First thing you should do is only CheckLevel when someone's xp is changed. That will reduce about half of the saving. If you need to use sql saving, then you should change to Threaded Queries. This will allow your sql queries to be run in the background and not freeze the server waiting for responses from all your queries. If you do not need to use sql, I would suggest you change to a non-sql vault; it will highly reduce the time to save data.

Only reason I used SQL is due to the fact that nvault seems to save in error. and then crashes the server.

and eventually i wanna try working with web ranking.