[Ja-Forces]

Сhange line 14 to:

int ent_table[128][2];

[Grey83]

Mika Misori, try this version

[Mika Misori]

Originally Posted by Grey83 Mika Misori, try this version

Thank you so much! Put it on the server and will keep an eye on the errors in logs. I'll report back later.

[Mika Misori]

Originally Posted by Grey83 Mika Misori, try this version

Well, server started crashing after I installed this version of the plugin.
And before that, it worked stably for months without a single crash.

Over the past few days, there have been 3 crashes on different maps, with different errors. Full logs in attachment.

Accelerator crash links:
https://crash.limetech.org/uhrngfenxj4o
https://crash.limetech.org/oy4zdx4lt6ug
https://crash.limetech.org/epfd6x56g37r

I would be glad if someone could help with this.

[Silvers]

Originally Posted by Grey83 Mika Misori, try this version

PHP Code:

AcceptEntityInput(entid, "Kill") ResetUseCount(entid); 


This won't compile on SM < 10, missing semicolon.

PHP Code:

int ent = MaxClients+1; 


Start at -1 instead.

- Usual things like "public" not required for custom named callbacks.
- Stock shouldn't be used in this context, only if a function isn't use or include files.


Can't see any reason for it to crash, other than round_start can be called before OnMapStart. So you should set a bool to determine if the map has started or not, and only delete in round_start when it has started.

[Grey83]

Originally Posted by Silvers PHP Code: AcceptEntityInput(entid, "Kill") ResetUseCount(entid);  This won't compile on SM < 10, missing semicolon.

AcceptEntityInput(entid, "Kill") ResetUseCount(entid); ==> if(AcceptEntityInput(entid, "Kill")) ResetUseCount(entid);

Originally Posted by Silvers PHP Code: int ent = MaxClients+1;  Start at -1 instead.

PHP Code:

Parameters
int startEnt
The entity index after which to begin searching from. Use -1 to start from the first entity. 


We don't need to start with the first entity (world).

Originally Posted by Silvers - Usual things like "public" not required for custom named callbacks. - Stock shouldn't be used in this context, only if a function isn't use or include files.

Will cause warnings when compiled with SM1.9 or older.

[little_froy]

Originally Posted by Grey83 AcceptEntityInput(entid, "Kill") ResetUseCount(entid); ==> if(AcceptEntityInput(entid, "Kill")) ResetUseCount(entid); PHP Code: Parameters int startEnt The entity index after which to begin searching from. Use -1 to start from the first entity.  We don't need to start with the first entity (world). Will cause warnings when compiled with SM1.9 or older.

FindEntityByClassname Function
Searches for an entity by classname.

int FindEntityByClassname(int startEnt, const char[] classname)
Parameters
int startEnt
A valid entity's index after which to begin searching from. Use -1 to start from the first entity.

const char[] classname
Classname of the entity to find.

Return Value
Entity index >= 0 if found, -1 otherwise.

Errors
Invalid start entity or lack of mod support.

[Grey83]

Originally Posted by little_froy i think it should be "int ent = MaxClients; ".

No, weapon spawners have much larger indexes.

PHP Code:

public void OnMapStart()
{
    char cls[32];
    for(int i = 1, max = GetMaxEntities(); i <= max; i++)
        if(IsValidEdict(i) && IsValidEntity(i)
        && GetEntityClassname(i, cls, sizeof(cls)) && !strncmp(cls, "weapon_", 7, false))
        {
            PrintToServer("\n    Entity '%s' (Id: %i, MaxClients: %i)\n", cls, i, MaxClients);
            break;
        }
} 


[little_froy]

Originally Posted by Grey83 No, weapon spawners have much larger indexes. PHP Code: public void OnMapStart() {     char cls[32];     for(int i = 1, max = GetMaxEntities(); i <= max; i++)         if(IsValidEdict(i) && IsValidEntity(i)         && GetEntityClassname(i, cls, sizeof(cls)) && !strncmp(cls, "weapon_", 7, false))         {             PrintToServer("\n    Entity '%s' (Id: %i, MaxClients: %i)\n", cls, i, MaxClients);             break;         } }

sorry, i was stupid.

[Grey83]

Originally Posted by little_froy that's for FindEntityByClassname(), not for the loop.

This is for finding the first entity whose classname starts with "weapon_" (and to compare how much its index is greater than MaxClients).