[rambomst]

I am trying to make a votemenu only show up for people that are on CT and I have been having issues getting this to work correctly. Sometimes it will work, other times it wont. So I think it has something to do with the way I am putting the CT players into the Clients[] variable or that I shouldn't be using MaxClients as the array size but when I tried to use GetArraySize it just refused to work.

SimonMenu(client)
{
    new Clients[32];
    if (IsVoteInProgress())
    {
        return;
    }
    g_ClientVote[0] = client;
    PrintToChatAll("\x01[\x03Trident-Gaming\x01] \x04A vote for simon says has been initiated.");
    new Handle:menu = CreateMenu(Handle_VoteMenu);
    SetMenuTitle(menu, "%N wants to start simon says: ", client);
    AddMenuItem(menu, "yes", "Yes");
    AddMenuItem(menu, "no", "No");
    SetMenuExitButton(menu, false);
    for(new i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i) && GetClientTeam(i) == 3)
        {
            Clients[i] = i; 
        }
    }
    VoteMenu(menu, Clients, MaxClients, 25);
}

[Monkeys]

Any errors in your console?

And perhaps make your Clients[] a bit larger, as MaxClients is probably 32, which will leave you one place short.

Does VoteMenu support the 0 client (server) as a valid client?

[rambomst]

I completely forgot I increased the size of my server and 32 wasn't enough, thanks Monkeys.

[BrutalGoerge]

that's not the problem XD
the clients array should not be incrementing by i, but every time it finds a CT, cuz assuming everyone isn't going to be ordered by what team they're on, that array is guna have gaps in it

client 1 is team 2
clean 2 is team 2
client 3 is team 3

then u got
Clients[0] = 0
Clients[1] = 0
Clients[2] = some client index #

you want the array to have nothing but valid indexes
and you were passing 32 to the voteMenu function every time... you want to pass the number of valid clients in the array
lookie

PHP Code:

SimonMenu(client)
{
    new Clients[MaxClients], iCount;
    if (IsVoteInProgress())
    {
        return;
    }
    g_ClientVote[0] = client;
    PrintToChatAll("\x01[\x03Trident-Gaming\x01] \x04A vote for simon says has been initiated.");
    new Handle:menu = CreateMenu(Handle_VoteMenu);
    SetMenuTitle(menu, "%N wants to start simon says: ", client);
    AddMenuItem(menu, "yes", "Yes");
    AddMenuItem(menu, "no", "No");
    SetMenuExitButton(menu, false);
    for(new i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i) && GetClientTeam(i) == 3)
        {
            Clients[iCount++] = i; 
        }
    }
    VoteMenu(menu, Clients, iCount, 25);
} 


[Monkeys]

Originally Posted by BrutalGoerge that's not the problem XD the clients array should not be incrementing by i, but every time it finds a CT, cuz assuming everyone isn't going to be ordered by what team they're on, that array is guna have gaps in it client 1 is team 2 clean 2 is team 2 client 3 is team 3 then u got Clients[0] = 0 Clients[1] = 0 Clients[2] = some client index # you want the array to have nothing but valid indexes and you were passing 32 to the voteMenu function every time... you want to pass the number of valid clients in the array lookie PHP Code: SimonMenu(client) {     new Clients[MaxClients], iCount;     if (IsVoteInProgress())     {         return;     }     g_ClientVote[0] = client;     PrintToChatAll("\x01[\x03Trident-Gaming\x01] \x04A vote for simon says has been initiated.");     new Handle:menu = CreateMenu(Handle_VoteMenu);     SetMenuTitle(menu, "%N wants to start simon says: ", client);     AddMenuItem(menu, "yes", "Yes");     AddMenuItem(menu, "no", "No");     SetMenuExitButton(menu, false);     for(new i = 1; i <= MaxClients; i++)     {         if (IsClientInGame(i) && GetClientTeam(i) == 3)         {             Clients[iCount++] = i;          }     }     VoteMenu(menu, Clients, iCount, 25); }

True, but that wouldn't call for the random behaviour he had as all ct's would still get added, although with gaps.

[rambomst]

After I increased the array size and made those changes BrutalGoerge suggested everything seems to be working fine and haven't had any complaints.

[Monkeys]

Good to hear.
Oh and simply for nice-coding's sake, try and start filling all your future arrays from index 0. Doesn't take too much trouble and can save a lot of hassle.