Raised This Month: $51 Target: $400
 12% 

[L4D(2)] Survivor Upgrades Reloaded


Post New Thread Reply   
 
Thread Tools Display Modes
thetwistedpanda
Good Little Panda
Join Date: Sep 2008
Old 10-18-2012 , 14:47   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #11

GsiX, the code is still post-lysis and wasn't written well to begin with, so take what you see with a grain of salt.
__________________
thetwistedpanda is offline
darkblades
Junior Member
Join Date: Apr 2012
Old 10-27-2012 , 18:00   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #12

Quote:
Originally Posted by thetwistedpanda View Post
Disclaimer:
  • This plugin is not meant for general public usage. It has not been tested (beyond compiling), and it will likely not be maintained beyond resolving errors and bugs.
  • This plugin was/is being distributed without its source code by Marcus101RR, of the Left 6 Dead "community", an individual above following the terms stated in SourceMod's license. The individual refuses to provide the source, and instead attacks personal of AlliedModders for enforcing the community rules and SourceMod's license. You really should read it, it's quite comical. In any case, I've reconstructed the source using Lysis, a few hours of time, and a large quantity of alcohol.
  • It should be mentioned that this plugin has no business being on a live server; it is poorly written, has several large memory leaks, and has clearly been copy/pasted with no real understanding of the language. I've applied a familiar naming scheme to the plugin and a few of the bugs/memory leaks, but the majority of the issues remain.
  • If there is popular demand, I will properly fix and rewrite this plugin for public consumption. Until then, however, it serves as the source code to a binary without one. And to watch hilarity ensue as a kid has his precious plugin released publicly.
I see no problem, plugin works fine, but this is not the original. You say you use a program, bad is baddie. Program can not code, so this is bad code because of you, not because of author.

Also, is not against rules to bash, racism, and create hate topics? Or does you allow this?

Also, why you allow others to remove credit where credit is needed?
http://code.google.com/p/sky-plugins...loaded.sp?r=20

This is people who should be banned not, people who make good plugins and you hate them. Very bad for business. Please fix this, tell guy to put credit where it is or ask to remove it. It is rules of alliedmodders.
darkblades is offline
thetwistedpanda
Good Little Panda
Join Date: Sep 2008
Old 10-28-2012 , 00:56   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #13

As you're likely posting on behalf of the individual that was banned... Lysis isn't a 1:1 decompile; it does create a variety of issues. There are no for loops (instead being constructed as broken while loops that tend to increment too fast), #defines use their defined value, comments are left out, switches become giant if structures, etc. It doesn't create usable code, but with basic knowledge of the language, it can be recreated to some degree of accuracy. With enough time, a 1:1 reproduction is possible, sans comments, at least of the time at decompile.

That being said, the issues found in this plugin were most likely not the result of Lysis' decompiling quirks due to the nature of such mistakes. Based on the appearance of several different code styles and variable naming schemes, existence of memory leaks that would have been caught by any plugin approver here (and most coders), and just generally poor methods, it appeared to me to be the result of copy/paste and basic language mastery. Whether it was the result of Marcus, prevous coders, or magical voodoo hermits living inside the ram, the end result is that even the reconstructed binary had little reason being on a server due to the issues. Lysis quirks generally don't create such issues, but you're free to test this theory yourself by taking Lysis and the available source for any plugins on the forums. As the original source was never released, and now that the offending binary is no longer being distributing, all points and your additional claims are rather moot. It dissolves into he said / she said and it's just meh.
__________________

Last edited by thetwistedpanda; 10-28-2012 at 01:01.
thetwistedpanda is offline
darkblades
Junior Member
Join Date: Apr 2012
Old 10-28-2012 , 01:44   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #14

Quote:
Originally Posted by thetwistedpanda View Post
As you're likely posting on behalf of the individual that was banned... Lysis isn't a 1:1 decompile; it does create a variety of issues. There are no for loops (instead being constructed as broken while loops that tend to increment too fast), #defines use their defined value, comments are left out, switches become giant if structures, etc. It doesn't create usable code, but with basic knowledge of the language, it can be recreated to some degree of accuracy. With enough time, a 1:1 reproduction is possible, sans comments, at least of the time at decompile.

That being said, the issues found in this plugin were most likely not the result of Lysis' decompiling quirks due to the nature of such mistakes. Based on the appearance of several different code styles and variable naming schemes, existence of memory leaks that would have been caught by any plugin approver here (and most coders), and just generally poor methods, it appeared to me to be the result of copy/paste and basic language mastery. Whether it was the result of Marcus, prevous coders, or magical voodoo hermits living inside the ram, the end result is that even the reconstructed binary had little reason being on a server due to the issues. Lysis quirks generally don't create such issues, but you're free to test this theory yourself by taking Lysis and the available source for any plugins on the forums. As the original source was never released, and now that the offending binary is no longer being distributing, all points and your additional claims are rather moot. It dissolves into he said / she said and it's just meh.
I no nothing of a Lysis, I see rules and you enforce them on the wrong people. You say this is programs fault, but tell me why two version have different credits then. Yours has Author of Marcus credit. Sky removes credit. The author sky is violating rules, and you ignore. How you expect trust if you show bad work?

PHP Code:
public Plugin:myinfo = {
     
name "[L4D2] Survivor Upgrades Reloaded",
     
description "Survivor Upgrades Reloaded",
     
author "Whosat & Jerrith",
     
version "1.5.0",
     
url "http://forums.alliedmods.net"
 
}; 
This is from sky website, no marcus, no official code. You agree that you choose who wants to follow rules then ,yes?
darkblades is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 10-28-2012 , 02:00   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #15

darkblades:

This is simply an in-progress reverse-engineering of a closed-source plugin that was posted on Marcus' website. Panda didn't write this beyond cleaning up some Lysis output and isn't taking credit for it.
__________________
Dr. McKay is offline
thetwistedpanda
Good Little Panda
Join Date: Sep 2008
Old 10-28-2012 , 11:25   Re: [L4D(2)] Survivor Upgrades Reloaded
Reply With Quote #16

darkblades, the GPL, unfortunately, does not require attribution for code. It is also not a forum rule, which you can easily confirm for yourself by reading them again. What that individual has done, while frowned upon, isn't breaking any laws/rules. Plugins that want to be approved however, that clearly borrow/use another person's plugin/code, must provide proper credits on these forums.

Defer future discussion of this matter to the other topic https://forums.alliedmods.net/showth...59#post1828059 as this isn't the place for it.
__________________

Last edited by thetwistedpanda; 10-28-2012 at 12:28.
thetwistedpanda is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:30.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode