[Nightfall1]

- Improved the Light on the dark map -

Description

• Autor: Night Dreamer - (Nightfall1)
• Release Day: 16/06/2011
• Version: 2.6 b1
• Info: Improved the Light on the dark map

Cvar's

• fake_lampa2.6_b1.amxx http://www.game-monitor.com/search.php?search=FLE_VERSION&type=variable
  FKADD - Insert the lamp on that place
  FKDEL - Delet the lamp from that place
  FKSAVE - Save all lamp on the place
  FKMENU - Open the lampa menu

fake_lampa_max " " //Who many lamap you can put per map default "5"

fake_lampa_dmg " " //Lampa take dmg ? 1 yes, 0 no default 1
FK_RADIUS " " //value default "20"
FK_COLOR_R " " //value default "102"
FK_COLOR_G " " //value default "89"
FK_COLOR_B " " //value default "87"

Who to enable grab on fake lampa uncomment//#define WG_SUPPORT Delete "//"
You can add hamsandwich accuracy on fake lampa uncomment//#define WR_HAM Delete "//"

NEW UPDATE WILL BE RELASE SOON

Changelog's

• 1.0 UP first release
  
• 2.3 BIG UPDATE FIX MENU + added customize radius color + added engine +better save system + optimization added
• 2.4 FIX NON Admin Remove all the fake lampa and use grab + Change admin_cvar with admin_kick, plugin optimization
• 2.5 Remove fm_get_aim_origin also cache point_content TNXC TO: ConnorMcLeod, added limitation of lampa's also added cvar that lampa can take dmg
• 2.6 Added fakelampa touch + WR_HAM for ham hooks instead using engine

[bibu]

Difference to lazarevs light creater?

[Arkshine]

Please attach the sma separately.

[GXLZPGX]

Originally Posted by bibu Difference to lazarevs light creater?

It's a fucking lamp. What ISN'T different?

[ConnorMcLeod]

Pre-review :

• Don't use static when absolutely not justified (like in plugin_cfg for example)
• Use properly register_clcmd and register_concmd
• Use precache_model instead of EngFunc_PrecacheModel
• Don't use inconsistent returns
• Destroy non-global menus, or make the menu global.
  If you keep the menu not global, then don't make the menu index variable globale, it can allow some issues if 2 players use the menu.
• Use get_user_origin instead of fm_get_aim_origin
• Avoid stupid code

      marfa[0] = fAngles[0] - fAngles[0]

• Remove stock label from private functions
• Fix indentation

[Nightfall1]

Originally Posted by ConnorMcLeod Pre-review : Don't use static when absolutely not justified (like in plugin_cfg for example) Use properly register_clcmd and register_concmd Use precache_model instead of EngFunc_PrecacheModel Don't use inconsistent returns Destroy non-global menus, or make the menu global. If you keep the menu not global, then don't make the menu index variable globale, it can allow some issues if 2 players use the menu. Use get_user_origin instead of fm_get_aim_origin Avoid stupid code Code:     marfa[0] = fAngles[0] - fAngles[0] Remove stock label from private functions Fix indentation

• What do you mean with "Use properly register_clcmd and register_concmd"
• Why precache_model ?
• "Don't use inconsistent returns" Example?... what does all this return's mean?
• "Destroy non-global menus, ....."I do not understand what you mean by that
• i don't want to use get_user_origin
• This
  marfa[0] = fAngles[0] - fAngles[0] // = 0 is 0
• What indentation?

New Version Coming Soon

[ConnorMcLeod]

- i mean don't mess up client commands and console commands.
+grab shouldn't be used from server console.

- because it is the appropriated native, even if the one use used do the same, you used both of them, it's inconsistent.

- i mean don't use fakameta returns in other places than fakemeta hooks, and don't use default amxx returns in fakemeta hooks.

- that's not my job to learn you how to use menu, by releasing a plugin using new menu system you assume that you know how to use it. See tutorials section.

- this fm_get_aim_origin is not justified

- Yes, this is stupid, just set it to 0, or don't even set it if it's already equal to 0

- ...

[ConnorMcLeod]

Still fm_get_aim_origin remaining, use get_user_origin + IVecFVec would be more efficient.
Also cache point_content result.

new Float:cool[3],Float:marfa[3]
Those 2 arrays are not needed, you can directly you aim origin and angles arrays.


You could consider creating menus such as g_FKlen only once at plugin_init, then you don't need to destroy it, if you still destroy it each time, there is no point in using a global var.

[ConnorMcLeod]

No changes, unapproved.

[Nightfall1]

Tnx for advices ConnorMcLeod