Rules Menu w/ Accept or Deny

derptestt · **Author**

I'm trying to make a simple rules menu that pops up when the player joins the server. I would like it to give an Accept or Deny. Accept = enter server. Deny = kicks user from server. I'm also trying to figure out how to freeze the player until he presses accept or deny.

The menu and sm_rules does work. Deny does not seem to kick from teh server. It doesn't popup on join, and the accept/deny choice are on the wrong numbers. Am I going about it the wrong way?

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_End | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules");
    AddMenuItem(rules, "1", "Testing", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "2", "Da", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "3", "Rules", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "4", "Testing", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{

    char name[32];
    int target = -1;
    GetCmdArg(1, name, sizeof(name));
 
    for (int i=1; i<=MaxClients; i++)
    {
        if (!IsClientConnected(i))
        {
            continue;
        }
        char other[32];
        GetClientName(i, other, sizeof(other));
        if (StrEqual(name, other))
        {
            target = i;
        }
    }
    
    switch(action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if(StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if(StrEqual(item_name, "DENY"))
            {
                ServerCommand("kickid %d", GetClientUserId(target));
            }
        }
    }
}

Powerlord · *Last edited by Powerlord; 08-13-2015 at 14:45.*

Code:

ServerCommand("kickid %d", GetClientUserId(target));

See also: KickClient.

You also need to remove the menu's exit button.

Incidentally, isn't there already a plugin that does this?

derptestt · *Last edited by derptestt; 08-13-2015 at 15:13.*

I haven't seen a plugin that implements an Accept or Deny function that kicks you.

Is this better?

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules");
    AddMenuItem(rules, "1", "Testing", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "2", "Da", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "3", "Rules", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "4", "Testing", ITEMDRAW_DISABLED);
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public OnClientPostAdminCheck(client)
{
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{    
    switch(action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if(StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if(StrEqual(item_name, "DENY"))
            {
                KickClient(client, "You didn't accept the rules.");
            }
        }
    }
}

Potato Uno · *Last edited by Potato Uno; 08-13-2015 at 16:14.*

Check the TF2BWR source code on how they do the client freezing thing.

If a player joins the robots team then they are frozen unless the sm_tf2bwr_freeze cvar is set to 0. Using that info, trace their source code to see how they made a client frozen and unable to move.

Also, don't use servercommand if there is already a native (KickClient) to do the same thing since it's a security hazard. You only touch servercommand if you want to run a console command that there is no other alternative way of running (and even then, sanitize your input string prior to running it).

derptestt · 08-13-2015 , 16:54 Re: Rules Menu w/ Accept or Deny

Thx Potato Uno, I can just freeze the movement of the client entity now that I think about it.

PHP Code:


			
public OnClientPostAdminCheck(client)
{
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

This line code not work, any idea why?
Also, is there a way to not display the number of the rules in the menu. For example

|Rules Menu Title|
Rule 1
Rule 2
Rule 3
1. Accept
2. Deny
(1 accepting and 2 denying)

Miu · 08-13-2015 , 17:12 Re: Rules Menu w/ Accept or Deny

try this

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    ShowRules(client);
}

public OnClientPostAdminCheck(client)
{
    ShowRules(client);
}

public ShowRules(client)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules\nTesting\nDa\Rules\nTesting");
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{
    switch (action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if (StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if (StrEqual(item_name, "DENY"))
            {
                KickClient(client, "You didn't accept the rules.");
            }
        }
    }
}

derptestt · *Last edited by derptestt; 08-13-2015 at 17:19.*

Quote:

Originally Posted by Miu

try this

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    ShowRules(client);
}

public OnClientPostAdminCheck(client)
{
    ShowRules(client);
}

public ShowRules(client)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules\nTesting\nDa\Rules\nTesting");
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{
    switch (action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if (StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if (StrEqual(item_name, "DENY"))
            {
                KickClient(client, "You didn't accept the rules.");
            }
        }
    }
}

plugin.sp(23) : error 027: invalid character constant
I'm going to try it w/o the \n

EDIT 1: Worked kind of w/o the \n. The kick function and accept function works, but it doesn't pop up when you join the server. Does public OnClientPostAdminCheck(client) conflict with CS:GO or kztimer mod? I already tried OnClientAuthorization too.

Miu · 08-13-2015 , 17:33 Re: Rules Menu w/ Accept or Deny

ok! try this maybe

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    ShowRules(client);
}

public OnClientPostAdminCheck(client)
{
    CreateTimer(5.0, Timer_ShowRules, client);
}

public Action:Timer_ShowRules(Handle:Timer, client)
{
    ShowRules(client);
}

public ShowRules(client)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules\nTesting\nDa\nRules\nTesting");
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{
    switch (action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if (StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if (StrEqual(item_name, "DENY"))
            {
                KickClient(client, "You didn't accept the rules.");
            }
        }
    }
}

derptestt · *Last edited by derptestt; 08-13-2015 at 17:49.*

Quote:

Originally Posted by Miu

ok! try this maybe

PHP Code:


			
#include <sourcemod>

#pragma semicolon 1

public OnPluginStart()
{
    RegConsoleCmd("sm_rules", Rules);
}

public Action:Rules(client, args)
{
    ShowRules(client);
}

public OnClientPostAdminCheck(client)
{
    CreateTimer(5.0, Timer_ShowRules, client);
}

public Action:Timer_ShowRules(Handle:Timer, client)
{
    ShowRules(client);
}

public ShowRules(client)
{
    new Handle:rules = CreateMenu(RulesFunction, MenuAction_Select | MenuAction_DisplayItem);
    SetMenuTitle(rules, "Server Rules\nTesting\nDa\nRules\nTesting");
    AddMenuItem(rules, "ACCEPT", "Accept");
    AddMenuItem(rules, "DENY", "Deny");
    DisplayMenu(rules, client, MENU_TIME_FOREVER);
}

public RulesFunction(Handle:menu, MenuAction:action, client, item)
{
    switch (action)
    {
        case MenuAction_Select:
        {
            decl String:item_name[64];
            GetMenuItem(menu, item, item_name, sizeof(item_name));
            if (StrEqual(item_name, "ACCEPT"))
            {
                CloseHandle(menu);
            }
            else if (StrEqual(item_name, "DENY"))
            {
                KickClient(client, "You didn't accept the rules.");
            }
        }
    }
}

I tried that too haha! I tried to set a timer. I think the KZTimer menu just overrides every menu. Oh well

NOt that important of a plugin. Thanks for trying.

EDIT: NVM, the server rules titles worked. It just doesn't pop up when you join the game. Also, it displays the exit menu option. I thought I deleted that, hmm.

Miu · 08-13-2015 , 18:00 Re: Rules Menu w/ Accept or Deny

isn't there an exceptions list kinda thing for kztimer?