[EDUTz]

Originally Posted by pokemonmaster Totally wrong. The first one was the best

I must agree if you say so, but why isn't better ?

[xClient]

Is this script better? (See charsmax & szSteamID)

PHP Code:

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init()
    register_plugin(PLUGIN, VERSION, "Blend");

public client_putinserver(id){
    new szName[32];
    new szStatus[8];
    new szSteamID[16];
    new szIp[16];

    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id, szName, charsmax(szName));
    get_user_ip(id, szIp, charsmax(szIp), 1);
    formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "ADMIN" : "USER");
    server_print("] Name: %s - SteamID: %s - IP: %s ^n] [%s]", szName, szSteamID, szIp, szStatus);
} 


[YamiKaitou]

Originally Posted by xClient szSteamID[32]; -> szSteamID[8]; then?

No, 32 is fine. You could use 20, but if the IDs ever get longer than 8 digits, your script will break.

[xClient]

Originally Posted by YamiKaitou No, 32 is fine. You could use 20, but if the IDs ever get longer than 8 digits, your script will break.

Okay, so like "32" isn't related to MaxPlayers? Good.

How is the charsmax?

[YamiKaitou]

Originally Posted by xClient Okay, so like "32" isn't related to MaxPlayers? Good.

In a 1D array for a String, no it is the string length.

How is the charsmax?

Huh?



Also, 16 is too short, your script won't like anyone with more than a 4 digit SteamID

[xClient]

PHP Code:

    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id, szName, charsmax(szName));
    get_user_ip(id, szIp, charsmax(szIp), 1);
    formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "ADMIN" : "USER"); 


I did write charsmax instead of like "31"

[YamiKaitou]

There is not a performance gain by doing that, it just makes it easier if you ever decide to change the length of the array.

[xOscar]

Originally Posted by YamiKaitou There is not a performance gain by doing that, it just makes it easier if you ever decide to change the length of the array.

Yeah.

[xOscar]

Originally Posted by xOscar Hey, I wonder how to make this script even better! When a player joins, it should print to server console. PHP Code: #include < amxmodx > #include < amxmisc > #define PLUGIN "justJoined" #define VERSION "0.1" public plugin_init() {     register_plugin(PLUGIN, VERSION, "Blend"); } public client_putinserver(id) {     new szSteamID[32];     new szName[32];     new szStatus[32];          if (is_user_admin(id))         status = "[ADMIN]";     else         status = "[USER]";          get_user_authid(id, szSteamID, charsmax(szSteamID));     get_user_name(id,szName,31);     server_print("---^n--- Name: %s - SteamID: %s, just joined %s^n---", szName, szSteamID, szStatus); }

Updated Code (Compiling without errors)

PHP Code:

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init()
    register_plugin(PLUGIN, VERSION, "Blend");

public client_putinserver(id){
    new szName[32];
    new szStatus[8];
    new szSteamID[22];
    new szIp[16];

    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id, szName, charsmax(szName));
    get_user_ip(id, szIp, charsmax(szIp), 1);
    formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "ADMIN" : "USER");
    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", szName, szStatus, szSteamID, szIp);
} 


Description: Printing out Player Name, SteamID & IP to the servers console when a player is put in to server.

[Magnificent]

Why u guys making a formatex? -_-

PHP Code:

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init()
    register_plugin(PLUGIN, VERSION, "Blend");

public client_putinserver(id)
{
    new szInfo[4][32]
    get_user_name(id, szInfo[0], 31)
    get_user_authid(id, szInfo[1], 31)
    get_user_ip(id, szInfo[2], 31, 1)
    
    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", szInfo[0], is_user_admin(id) ? "ADMIN" : "USER", szInfo[1], szInfo[2]);
} 


Beat that newbies.