[iclassdon]

Thank you for the sniper edition. It's awesome.

[41aaa41]

Originally Posted by Napoleon_be Call of Duty: HitMarkers Description. A simple plugin displaying a symbol inside your crosshair everytime you hit an enemy, just like in Call of Duty. Made this plugin since there aren't any of this kind yet. I have published 2 versions, 1 that works with all guns and 1 that only works with sniper rifles. Plugin Cvars. The whole hitmarker has a bunch of settings that can be changed by cvars, listed below amx_hitmarkers "1" - Enables/disables the plugin. amx_hmrainbow "1" - Enables/disables rainbow colors. amx_hmrandom "1" - Enables/disables random hitmarker symbols. amx_hmrcolor "165" - Sets the RGB Red code. (This won't work when amx_hmrainbow = 1) amx_hmgcolor "165" - Sets the RGB Green code. (This won't work when amx_hmrainbow = 1) amx_hmbcolor "165" - Sets the RGB Blue code. (This won't work when amx_hmrainbow = 1) amx_hmxpos "-1.0" - Sets the x position. amx_hmypos "-1.0" - Sets the y position. amx_hmholdtime "0.5" - Sets the holdtime of the hitmarker Hitmarker Symbols. When amx_hmrandom is "1", a random symbol will be picked to display inside your crosshair. When it's "0", a simple "x" will be displayed. "-" "\" "|" "/" "*" "+" "x" Updates. 1.0: First release 1.1: Implented DJEarthQuake's idea Added rainbow colors + cvars Added random symbols + cvars 1.2: Released a version which only works for Sniper rifles. Credits. DJEarthQuake: random color & random symbol idea. Bugsy: Thanks for showing me how to use bitsums, comes in very handy. For the people who wonder why i didn't make an extra cvar to change the hitmarker symbol, here's the reason. I tried it and tested it out, the problem is that when i use a pcvar for that, the symbol moves to the right and so the position isn't centered anymore. Please, if any bugs occure, let me know. Suggestions and improvements are always welcome too.

hello sir
Can you add pictures about the plugin?

[Napoleon_be]

Okay, so i've updated my plugin and adjusted everything nessecary to optimize, and get the sniper cvar to work.

@HamletEagle - Thanks for showing me on how to get that cvar fixed, should've thought about using a bool for that.
@Bugsy - Thanks for optimizing my code a lot. I see what you've done and i understand the whole thing. My problem is that i just keep on writing and when my code is done, i start thinking about optimizations. Allthough not the way you do.
@iclassdon - I would suggest using my updated version of the plugin. There's a new cvar called "amx_hmsnipers" which allow you to enable/disable snipers only.
@41aaa41 - I will add pictures when i get back home from work, won't be any time soon though. I'd say, test it out and see for yourself

Again thanks for all the help, much appreciated.

[Midnight Kid]

Yeah, that's it. I've taken this.
Thanks, Napoleon_be.

[DJEarthQuake]

Originally Posted by Napoleon_be cvars are there to be changed immediatly, i won't be changing my code which will lead the plugin to require a map change in order for the cvars to change, even though that would optimize my code.

1 script again nice. It looks a lot cleaner. How many times do you predict admins to change the cvars per map?

new gWeaponList = (1 << CSW_SCOUT) | (1 << CSW_AWP) | (1 << CSW_SG550) | (1 << CSW_G3SG1)

    if (get_pcvar_num(g_cvar_iHitSym) == 1 && CSW_ALL_SNIPERRIFLES & (1 << get_user_weapon(iInflictor)) ||

What is wrong with CSW_ALL_SNIPERRIFLES or Inflictor? gWeaponList is already defined with CSW_ALL_SNIPERRIFLES in cstrike_const.inc.

const CSW_ALL_SNIPERRIFLES = (1<<CSW_SCOUT | 1<<CSW_AWP   | 1<<CSW_G3SG1   | 1<<CSW_SG550);

Starting the color wheel at 10 instead of 0? It does not cause transparency. That's what alpha does. RGB all zeros is black.

Also I donated a matrices so if you want a 'spinner' for counter-strike it is there instead of this overly basic set of symbols that I only use on mods that cannot support real symbols like Counter-Strike.

I tested it last night. These are symbols off my weather plugin that were there for future use. Thank you again for sharing your X script as this was so much more fun than checking the weather!!

[OciXCrom]

Originally Posted by DJEarthQuake What is wrong with CSW_ALL_SNIPERRIFLES or Inflictor? gWeaponList is already defined with CSW_ALL_SNIPERRIFLES in cstrike_const.inc.

What's wrong is that these constants are defined in 1.9 and not available in 1.8.2.

Originally Posted by DJEarthQuake Starting the color wheel at 10 instead of 0? It does not cause transparency. That's what alpha does. RGB all zeros is black.

There are no black HUD messages in CS. All zeros is completely invisible.

[Napoleon_be]

Originally Posted by DJEarthQuake 1 script again nice. It looks a lot cleaner. How many times do you predict admins to change the cvars per map?

I don't think about that, i think about the efficiency of the plugin. cvars changing immediatly are way more efficient.

Originally Posted by DJEarthQuake What is wrong with CSW_ALL_SNIPERRIFLES or Inflictor? gWeaponList is already defined with CSW_ALL_SNIPERRIFLES in cstrike_const.inc.

What Ocixcrom said.

Originally Posted by DJEarthQuake Starting the color wheel at 10 instead of 0? It does not cause transparency. That's what alpha does. RGB all zeros is black.

Also what ocixcrom said. I've mentioned this earlier when all 3 colorcodes are 0, the hudmessage will be transparent and unable to be seen.

Originally Posted by DJEarthQuake Also I donated a matrices so if you want a 'spinner' for counter-strike it is there instead of this overly basic set of symbols that I only use on mods that cannot support real symbols like Counter-Strike. I tested it last night. These are symbols off my weather plugin that were there for future use. Thank you again for sharing your X script as this was so much more fun than checking the weather!!

I won't be using those symbols, my only purpose was showing an x and this plugin has transformed in something bigger than that already. Thanks for the feedback though

[Bugsy]

Not a functional improvement but you can reduce code:

PHP Code:

public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits)
{
    new iRed, iGreen, iBlue;
    
    if(get_pcvar_num(pPlugin) && is_user_connected(iAttacker) && (get_user_team(iVictim) != get_user_team(iAttacker)))
    {
        new iSnipersOnly = get_pcvar_num(pSnipersOnly);

        if( ( iSnipersOnly && ( gWeaponList & (1 << get_user_weapon(iAttacker))) ) || !iSnipersOnly )
        {
            if(get_pcvar_num(pRainbow))
            {
                iRed = iRainbow;
                iGreen = iRainbow;
                iBlue = iRainbow;
            }
            else
            {
                iRed = get_pcvar_num(pColorRed);
                iGreen = get_pcvar_num(pColorGreen);
                iBlue = get_pcvar_num(pColorBlue);
            }
        
            set_hudmessage(iRed, iGreen, iBlue, get_pcvar_float(pXPosition), get_pcvar_float(pYPosition) , 0, 2.0, get_pcvar_float(pHoldTime) , 0.0, 0.0, -1);
            show_hudmessage(iAttacker, "%s" , get_pcvar_num(pRandomHitmarkers) ? szSymbols[random(sizeof(szSymbols))] : "x");
        }
    }
} 


[Napoleon_be]

Originally Posted by Bugsy Not a functional improvement but you can reduce code: PHP Code: public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits) {     new iRed, iGreen, iBlue;          if(get_pcvar_num(pPlugin) && is_user_connected(iAttacker) && (get_user_team(iVictim) != get_user_team(iAttacker)))     {         new iSnipersOnly = get_pcvar_num(pSnipersOnly);         if( ( iSnipersOnly && ( gWeaponList & (1 << get_user_weapon(iAttacker))) ) || !iSnipersOnly )         {             if(get_pcvar_num(pRainbow))             {                 iRed = iRainbow;                 iGreen = iRainbow;                 iBlue = iRainbow;             }             else             {                 iRed = get_pcvar_num(pColorRed);                 iGreen = get_pcvar_num(pColorGreen);                 iBlue = get_pcvar_num(pColorBlue);             }                      set_hudmessage(iRed, iGreen, iBlue, get_pcvar_float(pXPosition), get_pcvar_float(pYPosition) , 0, 2.0, get_pcvar_float(pHoldTime) , 0.0, 0.0, -1);             show_hudmessage(iAttacker, "%s" , get_pcvar_num(pRandomHitmarkers) ? szSymbols[random(sizeof(szSymbols))] : "x");         }     } }

Seriously you're a god, i would've never thought of using it that way. But should i use it? I mean my plugin wouldn't be my plugin anymore if i just use codes that get posted here. I would just be copying..

[Bugsy]

It's still your plugin logic/flow, all I am doing is shortening the amount of code/redundancy.