[impossible_cc]

I have this code, but it doesn't work... I have no idea why. Is something wrong with me?

PHP Code:

public void OnClientPutInServer(int client) 
{ 
    SDKHook(client, SDKHook_OnTakeDamage, Hook_OnTakeDamage);
}
public Action Hook_OnTakeDamage(int victim, int& attacker, int& inflictor, float& damage, int& damagetype) 
{
    if(ValidPlayer(victim) && ValidPlayer(attacker))
    {
        if(GetClientTeam(attacker) == GetClientTeam(victim))
        {
            int heal = 20;
            int oldhp = GetClientHealth(victim);
            
            if(oldhp + heal > 100)
            {
                SetEntityHealth(victim,100);
            }
            else
            {
                SetEntityHealth(victim, heal + oldhp);
            }
            
            PrintToChat(attacker, "You healed your teammate!");
            PrintToChat(victim, "Your teammate healed you!");
        }
    }
    return Plugin_Continue;
} 


[ThatKidWhoGames]

Post your ValidPlayer() function.

EDIT: Change the ValidPlayer to IsClientInGame.

[Cruze]

Originally Posted by impossible_cc PHP Code: else {     SetEntityHealth(victim, heal + oldhp); }

[shanapu]

SetEntityHealth(heal + oldhp);

should throw an error on compile...
...so you couldn't have tested it to see if it worked!?

[impossible_cc]

Originally Posted by shanapu SetEntityHealth(heal + oldhp); should throw an error on compile... ...so you couldn't have tested it to see if it worked!?

I didn't get an error on compile. I'm just using another functions void HealToMaxHP(int client, int heal).
Function is very simple. Just checks maxHp, then compares it with current hp, and if current hp + heal more then maxHp, set to maxHp. Else SetEntityHealth(client, maxHp)
It's correct in the code, I'm sure. Made a mistake when rewriting.

[impossible_cc]

Okay. Here is full code. I'm sure that War3 function is correct, I'm also sure about ValidPlayer(client).

PrintToChat(attacker, "You healed...");
this message displays correctly, but the next one doesn't...

I tried to do heal manually, without war3 funct, doesnt work anyways
I tried to use timer with short delayy, but it sucks anyways. I guess something is wrong with victim index, but I don't understand WHY/

PHP Code:

public Action Hook_OnTakeDamage(int victim, int& attacker, int& inflictor, float& damage, int& damagetype) 
{
    if(ValidPlayer(victim) && ValidPlayer(attacker))
    {
        if(GetClientTeam(attacker) == GetClientTeam(victim))
        {
            if(War3_GetRace(attacker)==thisRaceID)
            {
                if(FORM_CURRENT[attacker] == FORM_TREE)
                {
                    int skill_level_tree = War3_GetSkillLevel(victim,thisRaceID,SKILL_TREE);
                    int heal = FORMTREE_HEAL_TEAMMATE_ATTACK[skill_level_tree];
                    
                    
                    War3_HealToMaxHP(victim, heal);
                    
                    EmitSoundToAll(SOUND_ATTACK_HEAL_TREE, victim);
                    PrintToChat(attacker, "You healed...");
                    PrintToChat(victim, "you've been healed...");
                }
            }
        }
    }
    return Plugin_Continue;
}