Raised This Month: $51 Target: $400
 12% 

[CS:GO] Kewaii Library (1.2.1, 9 September, 2017)


Post New Thread Reply   
 
Thread Tools Display Modes
Author
KewaiiGamer
Junior Member
Join Date: Aug 2017
Plugin ID:
5817
Plugin Version:
1.2.1
Plugin Category:
Technical/Development
Plugin Game:
Counter-Strike: GO
Plugin Dependencies:
    Servers with this Plugin:
     
    Plugin Description:
    Dependency for my mods
    Unapprover:
    Reason for Unapproving:
    https://forums.alliedmods.net/showpost.php?p=2547559&postcount=6
    Old 09-08-2017 , 14:17   [CS:GO] Kewaii Library (1.2.1, 9 September, 2017)
    Reply With Quote #1

    This plugin is a dependency to most of my mods however you are free to use it
    Features
    • Check if player is VIP, Mod or Admin
    Instructions
    • Download the kewaii_lib.sp file and drop it into addons/sourcemod/scripting/ (Optional)
    • Download the kewaii_lib.inc file and drop it into addons/sourcemod/scripting/include/
    Attached Files
    File Type: sp Get Plugin or Get Source (kewaii_lib.sp - 221 views - 1.5 KB)
    File Type: inc kewaii_lib.inc (108 Bytes, 259 views)

    Last edited by KewaiiGamer; 09-09-2017 at 13:38.
    KewaiiGamer is offline
    Pelipoika
    Veteran Member
    Join Date: May 2012
    Location: Inside
    Old 09-08-2017 , 14:34   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #2

    ��️
    __________________
    Pelipoika is offline
    Rachnus
    Senior Member
    Join Date: Jun 2016
    Location: Funland
    Old 09-08-2017 , 14:41   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #3

    __________________
    Github: https://github.com/jimppan
    Steam: http://steamcommunity.com/id/jimppan
    _____________________________________________ _________
    Taking private requests

    Last edited by Rachnus; 09-08-2017 at 14:42.
    Rachnus is offline
    Technoblazed
    Senior Member
    Join Date: May 2016
    Location: United Kingdom
    Old 09-08-2017 , 14:49   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #4

    Technoblazed is offline
    ESK0
    BANNED
    Join Date: May 2014
    Location: Czech Republic
    Old 09-08-2017 , 14:59   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #5

    ESK0 is offline
    headline
    SourceMod Moderator
    Join Date: Mar 2015
    Old 09-08-2017 , 15:11   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #6

    I see this plugin got quite some attention...

    This plugin provides no benefit to others, and making what could be a single function into a native hurts all of the plugins who use this.

    My suggestion: Update your original posts to just use a function, and get rid of this plugin. Otherwise, if you TRUELY wish to keep this plugin for whatever reason. Here's what needs to be fixed for it to even be considered for approval.
    1. Your current lines are a mixture of spaces and tabs of various lengths. Keep it consistent
    2. Readability is really poor for each native body. Less lines isn't better.
    3. Your include file should really have double include prevention and the optional requirements. View the wikis relating to these here and here.

    Also, avoid interacting with flag bits dirrectly and use CheckCommandAccess

    Last edited by headline; 09-08-2017 at 15:12.
    headline is offline
    KewaiiGamer
    Junior Member
    Join Date: Aug 2017
    Old 09-09-2017 , 08:00   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #7

    Ok so, regarding the first topic I am now gonna fix that, however I don't see the problem with readability on the native bodies. It seems pretty simple to me how it works and I don't get what I could do to make it more easy to read.

    Last edited by KewaiiGamer; 09-09-2017 at 12:30.
    KewaiiGamer is offline
    headline
    SourceMod Moderator
    Join Date: Mar 2015
    Old 09-10-2017 , 03:24   Re: [CS:GO] Kewaii Library (1.2.0, 8 September, 2017)
    Reply With Quote #8

    Quote:
    Originally Posted by KewaiiGamer View Post
    Ok so, regarding the first topic I am now gonna fix that, however I don't see the problem with readability on the native bodies. It seems pretty simple to me how it works and I don't get what I could do to make it more easy to read.
    idk why I thought it was unreadable. On a second glance it looks ok. Oh well!
    headline is offline
    Reply



    Posting Rules
    You may not post new threads
    You may not post replies
    You may not post attachments
    You may not edit your posts

    BB code is On
    Smilies are On
    [IMG] code is On
    HTML code is Off

    Forum Jump


    All times are GMT -4. The time now is 20:04.


    Powered by vBulletin®
    Copyright ©2000 - 2024, vBulletin Solutions, Inc.
    Theme made by Freecode