[edon1337]

Hi,

I have this stock that finds the highest point on the map by adding velocity until we reach CONTENTS_SKY, but sometimes it randomly spawns me on the ground. Are there any better stocks or any improvements to be done to this stock? I believe it spawns me to the ground because neither of the loops happen and return 0.0 is the return value, but why?

PHP Code:

Float:GetMaxHeight( id ) 
{ 
    new Float:fOrigin[ 3 ], Float:fDist; 
    pev( id, pev_origin, fOrigin ); 
    
    fDist = fOrigin[ 2 ]; 
    
    while( engfunc( EngFunc_PointContents, fOrigin ) == CONTENTS_EMPTY ) 
    fOrigin[ 2 ] += 5.0; 
    
    if( engfunc( EngFunc_PointContents, fOrigin ) == CONTENTS_SKY ) 
    return ( fOrigin[ 2 ] - fDist ); 
    
    return 0.0;
} 


[Ghosted]

As code says, if you go upwards before reach other than CONTENTS_EMPTY, you will then check if that place is CONTENTS_SKY & if not it will return zero. I think you need to add some content checks.

[CrazY.]

You can try to convert this util to amxx and work with sky instead.

Spoiler

float UTIL_WaterLevel(const Vector &position, float minz, float maxz)
{
    Vector midUp;
    float diff;

    midUp = position;
    midUp.z = minz;

    if (UTIL_PointContents(midUp) != CONTENTS_WATER)
        return minz;

    midUp.z = maxz;
    if (UTIL_PointContents(midUp) == CONTENTS_WATER)
        return maxz;

    diff = maxz - minz;
    while (diff > 1)
    {
        midUp.z = minz + diff / 2;
        if (UTIL_PointContents(midUp) == CONTENTS_WATER)
            minz = midUp.z;
        else
            maxz = midUp.z;

        diff = maxz - minz;
    }

    return midUp.z;
}

// Code using the util
void UTIL_BubbleTrail(Vector from, Vector to, int count)
{
    float flHeight = UTIL_WaterLevel(from, from.z, from.z + 256.0f) - from.z;
    if (flHeight < 8.0f)
    {
        flHeight = UTIL_WaterLevel(to, to.z, to.z + 256.0f) - to.z;

        if (flHeight < 8.0f)
            return;

        flHeight = flHeight + to.z - from.z;
    }

    if (count > 255)
        count = 255;

    MESSAGE_BEGIN(MSG_BROADCAST, SVC_TEMPENTITY);
        WRITE_BYTE(TE_BUBBLETRAIL);
        WRITE_COORD(from.x);
        WRITE_COORD(from.y);
        WRITE_COORD(from.z);
        WRITE_COORD(to.x);
        WRITE_COORD(to.y);
        WRITE_COORD(to.z);
        WRITE_COORD(flHeight);
        WRITE_SHORT(g_sModelIndexBubbles);
        WRITE_BYTE(count);
        WRITE_COORD(8);
    MESSAGE_END();
}

[edon1337]

Originally Posted by CrazY. You can try to convert this util to amxx and work with sky instead. Spoiler Spoiler float UTIL_WaterLevel(const Vector &position, float minz, float maxz) {     Vector midUp;     float diff;     midUp = position;     midUp.z = minz;     if (UTIL_PointContents(midUp) != CONTENTS_WATER)         return minz;     midUp.z = maxz;     if (UTIL_PointContents(midUp) == CONTENTS_WATER)         return maxz;     diff = maxz - minz;     while (diff > 1)     {         midUp.z = minz + diff / 2;         if (UTIL_PointContents(midUp) == CONTENTS_WATER)             minz = midUp.z;         else             maxz = midUp.z;         diff = maxz - minz;     }     return midUp.z; } // Code using the util void UTIL_BubbleTrail(Vector from, Vector to, int count) {     float flHeight = UTIL_WaterLevel(from, from.z, from.z + 256.0f) - from.z;     if (flHeight < 8.0f)     {         flHeight = UTIL_WaterLevel(to, to.z, to.z + 256.0f) - to.z;         if (flHeight < 8.0f)             return;         flHeight = flHeight + to.z - from.z;     }     if (count > 255)         count = 255;     MESSAGE_BEGIN(MSG_BROADCAST, SVC_TEMPENTITY);         WRITE_BYTE(TE_BUBBLETRAIL);         WRITE_COORD(from.x);         WRITE_COORD(from.y);         WRITE_COORD(from.z);         WRITE_COORD(to.x);         WRITE_COORD(to.y);         WRITE_COORD(to.z);         WRITE_COORD(flHeight);         WRITE_SHORT(g_sModelIndexBubbles);         WRITE_BYTE(count);         WRITE_COORD(8);     MESSAGE_END(); }

Is vector an array in Pawn? How do we even convert this to Pawn..

PHP Code:

    Vector midUp;
    float diff;

    midUp = position; 


[HamletEagle]

new Float:sth[3]

[edon1337]

Originally Posted by HamletEagle new Float:sth[3]

yea but we don't simply do this in Pawn

PHP Code:

new Float:sth[3]
new Float:sth2[3]

sth = sth2 


Should I just loop and pass values like

PHP Code:

sth[ 0 ] = sth2[ 0 ] 


with a loop?

[Ghosted]

Not loop just use 0,1,2 or use xs. You can't assign Vector to Vector cause theres no = operator, but they are same (VecA = VecB & VecA[0] = VecB[0]...)

[edon1337]

Originally Posted by Ghosted Not loop just use 0,1,2 or use xs. You can't assign Vector to Vector cause theres no = operator, but they are same (VecA = VecB & VecA[0] = VecB[0]...)

Do you even read what I write or you just post unknowingly? I basically just stated that I'm aware you can't assign values as in C++ here in Pawn and that we need to go through both of the arrays dimensions at the same time and assign values.

PHP Code:

public MyFunction( )
{
    new aArray[ 3 ], bArray[ 3 ];
    MixArrays( aArray, bArray );
}

MixArrays( aArray[ ], bArray[ ] )
{
    for( new i; i < 3; i++ )
    {
        aArray[ i ] = bArray[ i ];
    }
} 


[edon1337]

I pretty much converted the first stock, all left is to test it, Crazy where did you find these stocks?

PHP Code:

Float:UTIL_SkyLevel( const iOrigin[ 3 ], Float:iMinZ, Float:iMaxZ )
{
    new iMidUp[ 3 ], iMidUpZ[ 3 ];
    Float:fDiff;

    MixArrays( iMidUp, iOrigin );
    MixArrays( iMidUpZ, iMinZ );

    if( engfunc( EngFunc_PointContents, iMidUp ) != CONTENTS_SKY )
    return iMinZ;

    iMidUpZ = iMaxZ;
    
    if( engfunc( EngFunc_PointContents, iMidUp ) == CONTENTS_SKY )
    return iMaxZ;

    fDiff = iMaxZ - iMinZ;
    
    while( fDiff > 1 )
    {
        iMidUpZ = iMiNZ + fDiff / 2;
        
        if( engfunc( EngFunc_PointContents, iMidUp ) == CONTENTS_SKY )
            iMinZ = iMidUpZ;
            
        else
            iMaxZ = iMidUpZ;

        fDiff = iMaxZ - iMinZ;
    }
    return iMidUpZ;
}

MixArrays( aArray[ ], bArray[ ] )
{
    for( new i; i < 3; i++ )
    {
        aArray[ i ] = bArray[ i ];
    }
} 


[klippy]

You can actually just assign an array to another one that's greater or equal in size.