[n3Oh112]

I have this error

L 01/03/2018 - 23:54:53: [ZP] Invalid Player (0)
L 01/03/2018 - 23:54:53: [AMXX] Displaying debug trace (plugin "zp_celmaibun.amxx", version "1.0")
L 01/03/2018 - 23:54:53: [AMXX] Run time error 10: native error (native "zp_get_user_ammo_packs")
L 01/03/2018 - 23:54:53: [AMXX] [0] 17yx1kg3.sma.p::logevent_round_end (line 35)
L 01/03/2018 - 23:54:58: [ZP] Invalid Player (0)
L 01/03/2018 - 23:54:58: [AMXX] Displaying debug trace (plugin "zp_celmaibun.amxx", version "1.0")
L 01/03/2018 - 23:54:58: [AMXX] Run time error 10: native error (native "zp_get_user_ammo_packs")
L 01/03/2018 - 23:54:58: [AMXX] [0] 17yx1kg3.sma.p::event_newround (line 25)

source

#include <amxmodx> 
#include <amxmisc> 
#include <zombieplague> 
#include <dhudmessage> 

#define PLUGIN   "EDITAT" 
#define AUTHOR   "EDITAT" 
#define VERSION   "1.0" 

new ammoinceput[32], ammosfarsit[32], rezultat[32] 
new maxplayers, aintrat[32] 
public plugin_init() 
{ 
   register_plugin(PLUGIN, VERSION, AUTHOR) 
   register_event("HLTV", "event_newround", "a", "1=0", "2=0") 
   register_logevent("logevent_round_end", 2, "1=Round_End") 
} 

public event_newround() 
{ 
   maxplayers = get_maxplayers() 
   for(new i = 0; i < maxplayers; i++) 
   { 
      aintrat[i] = 0 
      ammoinceput[i] = zp_get_user_ammo_packs(i) 
   } 
} 

public logevent_round_end() 
{ 
   for(new i = 0; i < maxplayers; i++) 
   { 
      if(aintrat[i] == 0) 
      { 
         ammosfarsit[i] = zp_get_user_ammo_packs(i) 
         rezultat[i] = ammosfarsit[i] - ammoinceput[i] 
      } 
      else 
      { 
         ammosfarsit[i] = 0 
         rezultat[i] = 0 
      } 
   } 
    
   arata_mesaj() 
} 

public arata_mesaj() 
{ 
   new iBestPlayer = get_best_player()    
   new szName[32]    
   get_user_name(iBestPlayer, szName, charsmax(szName)) 
    
   for(new i = 0; i < get_maxplayers(); i++) 
   { 
      if(is_user_connected(i)) 
      { 
         set_dhudmessage( 0, 160, 0, -1.0, 0.25, 0, 1.0, 3.0, 0.1, 1.5 ); 
         show_dhudmessage( i, "Runda aceasta, cel mai bun a fost^n%s, facand %i credite.^n^nRunda aceasta tu ai facut^n%i credite.", szName, rezultat[iBestPlayer], rezultat[i] ); 
      } 
   } 
} 

public get_best_player()    
{    
    new players[32], num;    
    get_players(players, num);    
    SortCustom1D(players, num, "sort_bestplayer")    
        
    return players[0]    
}  

public sort_bestplayer(id1, id2)    
{    
    if(rezultat[id1] > rezultat[id2])    
        return -1;    
    else if(rezultat[id1] < rezultat[id2])    
        return 1;    
        
    return 0;    
}  

public client_disconnect(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 0 
} 

public client_putinserver(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 1 
}

Can help me?
Please...

[E1_531G]

Check if player is online: is_user_connected()

[n3Oh112]

Originally Posted by E1_531G Check if player is online: is_user_connected()

Can you help me with this?
i don`t know how...

[OciXCrom]

If you don't know how, go to the requests section. This one requires basic scripting knowledge.

[eyal282]

Originally Posted by OciXCrom If you don't know how, go to the requests section. This one requires basic scripting knowledge.

No.

The index IDs of players starts from 1, not 0. Index id 0 is reserved for the entire "world" of the map.

Replace every writing of this:

PHP Code:

for(new i = 0; i < maxplayers; i++) 


with this:

PHP Code:

for(new i = 1; i < maxplayers; i++) 


Take a note: I didn't script for Amx Mod X for a while and I think it should be i <= maxplayers. Make a check and give me your answer, because I think that if you use i < maxplayers, the last player ID gets excluded. I use get_players if I wanna loop all players, rather than your method of looping index IDs.

[edon1337]

Originally Posted by eyal282 I use get_players if I wanna loop all players, rather than your method of looping index IDs.

And how is that method of yours if not looping through player indexes?

[Adomaz1]

#include <amxmodx> 
#include <amxmisc> 
#include <zombieplague> 
#include <dhudmessage> 

#define PLUGIN   "EDITAT" 
#define AUTHOR   "EDITAT" 
#define VERSION   "1.0" 

new ammoinceput[32], ammosfarsit[32], rezultat[32] 
new maxplayers, aintrat[32] 
public plugin_init() 
{ 
   register_plugin(PLUGIN, VERSION, AUTHOR) 
   register_event("HLTV", "event_newround", "a", "1=0", "2=0") 
   register_logevent("logevent_round_end", 2, "1=Round_End") 
} 

public event_newround(id) {
	if(!is_user_connected(id))
		return
	
	maxplayers = get_maxplayers() 
	for(new i = 0; i < maxplayers; i++) {
		aintrat[i] = 0 
		ammoinceput[i] = zp_get_user_ammo_packs(i) 
    } 
} 

public logevent_round_end(id) 
{
	if(!is_user_connected(id))
		return
		
	for(new i = 0; i < maxplayers; i++) 
	{
		if(aintrat[i] == 0 && i) { 
			ammosfarsit[i] = zp_get_user_ammo_packs(i) 
			rezultat[i] = ammosfarsit[i] - ammoinceput[i] 
		} 
		else { 
			ammosfarsit[i] = 0 
			rezultat[i] = 0 
		} 
	} 
   arata_mesaj() 
} 

public arata_mesaj() 
{ 
   new iBestPlayer = get_best_player()    
   new szName[32]    
   get_user_name(iBestPlayer, szName, charsmax(szName)) 
    
   for(new i = 0; i < get_maxplayers(); i++) 
   { 
      if(is_user_connected(i)) 
      { 
         set_dhudmessage( 0, 160, 0, -1.0, 0.25, 0, 1.0, 3.0, 0.1, 1.5 ); 
         show_dhudmessage( i, "Runda aceasta, cel mai bun a fost^n%s, facand %i credite.^n^nRunda aceasta tu ai facut^n%i credite.", szName, rezultat[iBestPlayer], rezultat[i] ); 
      } 
   } 
} 

public get_best_player()    
{    
    new players[32], num;    
    get_players(players, num);    
    SortCustom1D(players, num, "sort_bestplayer")    
        
    return players[0]    
}  

public sort_bestplayer(id1, id2)    
{    
    if(rezultat[id1] > rezultat[id2])    
        return -1;    
    else if(rezultat[id1] < rezultat[id2])    
        return 1;    
        
    return 0;    
}  

public client_disconnect(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 0 
} 

public client_putinserver(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 1 
}

[DjSoftero]

Here you go, next time come back with some knowledge. Otherwise use suggestions/requests section.

Spoiler

PHP Code:

#include <amxmodx> 
#include <amxmisc> 
#include <zombieplague> 
#include <dhudmessage>

#define PLUGIN   "EDITAT" 
#define AUTHOR   "EDITAT" 
#define VERSION   "1.0" 

new ammoinceput[32], ammosfarsit[32], rezultat[32] 
new aintrat[32] 
public plugin_init() 
{ 
   register_plugin(PLUGIN, VERSION, AUTHOR) 
   register_event("HLTV", "event_newround", "a", "1=0", "2=0") 
   register_logevent("logevent_round_end", 2, "1=Round_End") 
} 

public event_newround() 
{
   new players[32], index, num
   get_players(players, num)
   for(new i; i < num; i++)
   {
      index = players[i]
      aintrat[index] = 0 
      ammoinceput[index] = zp_get_user_ammo_packs(index) 
   } 
} 

public logevent_round_end() 
{
   new players[32], index, num
   get_players(players, num)
   for(new i; i < num; i++)
   { 
      index = players[i]
      if(aintrat[index] == 0) 
      { 
         ammosfarsit[index] = zp_get_user_ammo_packs(index) 
         rezultat[index] = ammosfarsit[index] - ammoinceput[index] 
      } 
      else 
      { 
         ammosfarsit[index] = 0 
         rezultat[index] = 0 
      }
   }
    
   arata_mesaj() 
}

public arata_mesaj() 
{ 
   new iBestPlayer = get_best_player()    
   new szName[32]    
   get_user_name(iBestPlayer, szName, charsmax(szName)) 
    
   for(new i = 0; i < get_maxplayers(); i++) 
   { 
      if(is_user_connected(i)) 
      { 
         set_dhudmessage( 0, 160, 0, -1.0, 0.25, 0, 1.0, 3.0, 0.1, 1.5 ); 
         show_dhudmessage( i, "Runda aceasta, cel mai bun a fost^n%s, facand %i credite.^n^nRunda aceasta tu ai facut^n%i credite.", szName, rezultat[iBestPlayer], rezultat[i] ); 
      } 
   } 
} 

public get_best_player()    
{    
    new players[32], num;    
    get_players(players, num);    
    SortCustom1D(players, num, "sort_bestplayer")    
        
    return players[0]    
}  

public sort_bestplayer(id1, id2)    
{    
    if(rezultat[id1] > rezultat[id2])    
        return -1;    
    else if(rezultat[id1] < rezultat[id2])    
        return 1;    
        
    return 0;    
}  

public client_disconnect(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 0 
} 

public client_putinserver(id) 
{ 
   ammoinceput[id] = 0 
   ammosfarsit[id] = 0 
   rezultat[id] = 0 
   aintrat[id] = 1 
} 


[eyal282]

Originally Posted by edon1337 And how is that method of yours if not looping through player indexes?

It doesn't loop through player indexes, not directly at least.

[edon1337]

Originally Posted by eyal282 It doesn't loop through player indexes, not directly at least.

And how do you loop through player indexes indirectly?