[psychonic]

Originally Posted by WildCard65 Um, according to the implementation of OnTakeDamageAlivePost, your unable to change params in post hooks(ref: https://github.com/alliedmodders/sou...sion.cpp#L1149)

Hrmph, you're right.

There's no technical reason why changing them shouldn't be allowed in OnTakeDamagePost or OnTakeDamageAlivePost since all of the damage info is by ref. That's a bit of an API failure. We should fix that.

[WildCard65]

Originally Posted by psychonic That's a bit of an API failure. We should fix that.

Must of been some oversight since Feb 7 2013/earlier (ref: https://github.com/alliedmodders/sou...57bcc00a40840c)

[psychonic]

It's not particularly useful for OnTakeDamagePost, and the hook on OnTakeDmage_Alive didn't exist then, but yes.

[WildCard65]

Originally Posted by psychonic It's not particularly useful for OnTakeDamagePost, and the hook on OnTakeDmage_Alive didn't exist then, but yes.

if I recall, you just made the original "OnTakeDamage"/"OnTakeDamagePost" hook into Handling methods and just routed OnTakeDamage/OnTakeDamageAlive/OnTakeDamagePost/OnTakeDamageAlivePost to aforementioned methods.

[psychonic]

Yes, I'm aware of the changes that I authored... because I authored them.

[Accelerator]

So, TakeDamage will be fixed in newer versions?

[psychonic]

There's nothing broken. It just does not have the ability to change the damage amount in a OnTakeDamageAlivePost hook.