How to execute server command and get the output in extension?

CDboy · **Author**

Hi I am writing an extension and I want to execute server commands using C++.
I know that

Code:

IGameHelpers::ServerCommand()

can be used for executing, but I also want to get the command output.
How can I get this done?

Bacardi · *Last edited by Bacardi; 12-12-2021 at 03:55.*

Try look ServerCommandEx ? https://sm.alliedmods.net/new-api/co...erverCommandEx
https://github.com/alliedmodders/sou...erverCommandEx

CDboy

Quote:

Originally Posted by Bacardi

Try look ServerCommandEx ? https://sm.alliedmods.net/new-api/co...erverCommandEx
https://github.com/alliedmodders/sou...erverCommandEx

Well, I think I finally figured out the machanism of

Code:

static cell_t sm_ServerCommandEx(IPluginContext *pContext, const cell_t *params)

and I have written the code to get the output of a console command.
However during my test I found that any command would get a result of "Error, bad server command ...". For example, command status results in "Error, bad server command status".
Then I tested

Code:

IGameHelpers::ServerCommand

and I got the same result (Error...).
Then I tested ServerCommand() in SourcePawn, which worked.
Now I am really confused...

Ciallo · *Last edited by Ciallo; 12-13-2021 at 01:04. Reason: add code*

Code:

virtual void ServerCommand( const char *str )
{
	if ( !str )
	{
		Sys_Error( "ServerCommand with NULL string\n" );
	}
	if ( ValidCmd( str ) )
	{
		Cbuf_AddText( CBUF_SERVER, str );
	}
	else
	{
		ConMsg( "Error, bad server command %s\n", str );
	}
}

static bool ValidCmd( const char *pCmd )
{
	int len;

	len = strlen(pCmd);

	// Valid commands all have a ';' or newline '\n' as their last character
	if ( len && (pCmd[len-1] == '\n' || pCmd[len-1] == ';') )
		return true;

	return false;
}

make sure your command string have a ';' or newline '\n' as their last character

For example:

Code:

gamehelpers->ServerCommand("bot_kick\n");

Because the function does not auto \n terminate

Code:

/**
 * @brief Wraps IVEngineServer::ServerCommand. 
 *
 * @param buffer		Command buffer (does not auto \n terminate).
 */
virtual void ServerCommand(const char *buffer) =0;

CDboy

Quote:

Originally Posted by Ciallo

Code:

virtual void ServerCommand( const char *str )
{
	if ( !str )
	{
		Sys_Error( "ServerCommand with NULL string\n" );
	}
	if ( ValidCmd( str ) )
	{
		Cbuf_AddText( CBUF_SERVER, str );
	}
	else
	{
		ConMsg( "Error, bad server command %s\n", str );
	}
}

static bool ValidCmd( const char *pCmd )
{
	int len;

	len = strlen(pCmd);

	// Valid commands all have a ';' or newline '\n' as their last character
	if ( len && (pCmd[len-1] == '\n' || pCmd[len-1] == ';') )
		return true;

	return false;
}

make sure your command string have a ';' or newline '\n' as their last character

For example:

Code:

gamehelpers->ServerCommand("bot_kick\n");

Because the function does not auto \n terminate

Code:

/**
 * @brief Wraps IVEngineServer::ServerCommand. 
 *
 * @param buffer		Command buffer (does not auto \n terminate).
 */
virtual void ServerCommand(const char *buffer) =0;

Thanks, this solved the problem!