[versatile_bfg]

Hey,

I'm having a problem with the player_hurt event returning the wrong weapon name so does Weapon_Fire but the player_death event returns the right one.

hkp2000 is returned instead of usp_silencer or usp_silencer_off
same with m4a1 is returned instead of m4a1_silencer or m4a1_silencer_off

GetClientWeapon() also returns the wrong weapon name

Anyone know a fix for this?

Sourcemod 1.5.2 & MetaMod 1.10.0 being used.

here is a image of what I mean

PHP Code:

HookEvent("player_hurt",  Event_Player_Hurt);
HookEvent("player_death",  Event_Player_Death);
HookEvent("weapon_fire", Event_Weapon_Fire);

public Event_Player_Hurt(Handle:event, const String:name[], bool:dontBroadcast)
{
    if (!IsActive(0, true))
    {
        return;
    }
    
    // stats
    if (GetConVarBool(g_h_stats_enabled))
    {
        new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
        new victim = GetClientOfUserId(GetEventInt(event, "userid"));
        new damage = GetEventInt(event, "dmg_health");
        new damage_armor = GetEventInt(event, "dmg_armor");
        new hitgroup = GetEventInt(event, "hitgroup");
        new String: weapon[64];
        new String: weapons[64];  //this is only for testing
        GetClientWeapon(attacker, weapons, 64);    //this is only for testing
        GetEventString(event, "weapon", weapon, sizeof(weapon));
        PrintToChatAll("Hurt = GetEventString weapon %s - GetClientWeapon %s", weapon, weapons);    //this is only for testing
[more code here but not needed for this problem]
    }
}

public Event_Player_Death(Handle:event, const String:name[], bool:dontBroadcast)
{
    if (!IsActive(0, true))
    {
        return;
    }
    
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    new assister = GetClientOfUserId(GetEventInt(event, "assister"));
    new victim = GetClientOfUserId(GetEventInt(event, "userid"));
    new bool:headshot = GetEventBool(event, "headshot");
    new String: weapon[64];
    new String: weapons[64];  //this is only for testing
    GetEventString(event, "weapon", weapon, sizeof(weapon));
    GetClientWeapon(attacker, weapons, 64);  //this is only for testing
    PrintToChatAll("Death = GetEventString weapon %s - GetClientWeapon %s", weapon, weapons);  //this is only for testing
    new victim_team = GetClientTeam(victim);
[there is more code here but not needed for this problem]
}

public Event_Weapon_Fire(Handle:event, const String:name[], bool:dontBroadcast)
{
    if (!IsActive(0, true))
    {
        return;
    }
    
    // stats
    if (GetConVarBool(g_h_stats_enabled))
    {
        new client = GetClientOfUserId(GetEventInt(event, "userid"));
        if (client > 0)
        {
            new String: weapon[64];
            new String: weapons[64];  //this is only for testing
            GetEventString(event, "weapon", weapon, sizeof(weapon));
            GetClientWeapon(client, weapons, 64);  //this is only for testing
            PrintToChatAll("Fire = GetEventString weapon %s - GetClientWeapon %s", weapon, weapons);  //this is only for testing
            new weapon_index = GetWeaponIndex(weapon);
            if (weapon_index > -1)
            {
                weapon_stats[client][weapon_index][LOG_HIT_SHOTS]++;
            }
        }
    }
} 


[sim242]

SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage);

maybe?

[Root_]

I had similar issue with finding whether or not usp or m4a1-s was used. I found a way and implemented that in this plugin.
Here is a small snippet that I made just now, untested.

new m_bSilencerOn, m_hActiveWeapon;

public OnPluginStart()
{
    m_bSilencerOn   = FindSendPropOffs("CWeaponCSBaseGun", "m_bSilencerOn");
    m_hActiveWeapon = FindSendPropOffs("CBasePlayer",      "m_hActiveWeapon");
}

public OnSomeEvent()
{
    // Declare weapon string and player slot
    decl String:szWeapon[MAX_NAME_LENGTH], slot; // Make sure slot is valid and we can retrieve its classname
    if ((slot = GetEntDataEnt2(client, m_hActiveWeapon)) != -1 && GetEdictClassname(slot, szWeapon, sizeof(szWeapon)))
    {
        // Check whether or not silencer is inserted
        if (bool:GetEntData(slot, m_bSilencerOn, true) == true)
        {
            // Replace whole weapon string appropriately. If 8th char is 'h' (weapon_Hpk2000) replace string to weapon_usp, otherwise it was m4a1.
            ReplaceString(szWeapon, sizeof(szWeapon), szWeapon, (szWeapon[8] == 'h' ? "weapon_usp" : "weapon_m4a1"))
        }
        // Other stuff
    }
}

To be honest I'd like to use StrCat instead of replacing whole string (due to performance purposes), so take a look at Ammo Manager as well.

[Mathias.]

Originally Posted by Root_ I had similar issue with finding whether or not usp or m4a1-s was used. I found a way and implemented that in this plugin. Here is a small snippet that I made just now, untested. new m_bSilencerOn, m_hActiveWeapon; public OnPluginStart() {     m_bSilencerOn   = FindSendPropOffs("CWeaponCSBaseGun", "m_bSilencerOn");     m_hActiveWeapon = FindSendPropOffs("CBasePlayer",      "m_hActiveWeapon"); } public OnSomeEvent() {     // Declare weapon string and player slot     decl String:szWeapon[MAX_NAME_LENGTH], slot; // Make sure slot is valid and we can retrieve its classname     if ((slot = GetEntDataEnt2(client, m_hActiveWeapon)) != -1 && GetEdictClassname(slot, szWeapon, sizeof(szWeapon)))     {         // Check whether or not silencer is inserted         if (bool:GetEntData(slot, m_bSilencerOn, true) == true)         {             // Replace whole weapon string appropriately. If 8th char is 'h' (weapon_Hpk2000) replace string to weapon_usp, otherwise it was m4a1.             ReplaceString(szWeapon, sizeof(szWeapon), szWeapon, (szWeapon[8] == 'h' ? "weapon_usp" : "weapon_m4a1"))         }         // Other stuff     } } To be honest I'd like to use StrCat instead of replacing whole string (due to performance purposes), so take a look at Ammo Manager as well.

Is that not causing problem if you remove the silencer from the gun?

[Root_]

Black-Rabbit, I have no idea so far, because silencer check made when weapon just created in Ammo Manager. It's enough for me.

[Mathias.]

But you looking if the the silencer is ON, so if I get a usp and I remove the silencer from it manually in-game and kill someone it will still cause the issue isnt?

[Root_]

Originally Posted by Black-Rabbit But you looking if the the silencer is ON, so if I get a usp and I remove the silencer from it manually in-game and kill someone it will still cause the issue isnt?

Just test it out and tell whether or not issue occurs.

[versatile_bfg]

Thanks for that. I will have a play around tonight and see what happens. For the moment I have just forced it to use m4a1 or hkp2000 for player death atm.

[Mathias.]

Originally Posted by Root_ Just test it out and tell whether or not issue occurs.

Don't need to, the answer is already wrote.

[versatile_bfg]

FFS now it is happening with cz75a being p250 for player hurt and weapon fire but cz75a on player death. =(

Is this a sourcemod thing or a csgo [valve] thing?