[BOYSplayCS]

Health Kill v1.2

description

With each kill a player makes he is awarded a controllable amount of HP.

cvars

amx_hk_health <#> - Amount of HP received for one kill.
Default: 5

amx_hk_headshot <#> - Amount of HP received for a head-shot.
Default: 10

amx_hk_max <#> - Control the maximum health allowed.
Default: 100

amx_hk_sound <#> - Whether or not to play the sound when a kill is made.
Default: 1

amx_hk_hud <#> - Whether or not to display the hud message for a kill.
Default: 1

changelog

• Version 1.0
  • Initial Release

• Version 1.1
  • Added cvar for hud message display
  • Changed return PLUGIN_HANDLED; with return PLUGIN_CONTINUE;
  • Changed SyncHudMsg() to show_hudmessage()

• Version 1.2
  • Changed death event parameters
  • Changed all HANDLEDs to CONTINUEs
  • Added cvar for maximum health
  • Added cvar for head-shot mode
  • Added a is_user_alive() check
  • Added a get_user_team() check
  • Added a max clients check
  • Fully optimized code

credits

• My Shower - Thought of the idea while in it.

[crazyeffect]

Nice

[Xevious]

nice plugin , keep it up.

[ConnorMcLeod]

This kind of plugins has already been written many times, why do you wrote it ?

[Arkshine]

- iMax is used one time. No need to create a var, use directly get_pcvar_num(cMax).
- iHeadshot is used one time and either you use directly read_data(3), either you create the var after the first check.
- This code is done before the check if iKiller is a player or not. It doesn't make sense. Move these both lines in the check.

iHealth = get_user_health(iKiller);
iHealth += iAddHp;

Lines you could do directly : iHealth = get_user_health(iKiller) + iAddHp;

- There set_user_health(iKiller, get_user_health(iKiller) + iHealth); ; since you have calculated the value before, it should be only iHealth.
- Btw, why iAddHp, iHealth are global vars ?! It should not.
- There :

if (!get_pcvar_num(cHud))
	return PLUGIN_CONTINUE;
			
if (!get_pcvar_num(cSound))
	return PLUGIN_CONTINUE;

Do the checks on one line, compiler is idiot and will not optimize like that.

[Hawk552]

Reposting a plugin because you don't like the decision of an approver is not allowed in any case unless you are specifically instructed to do so.

As a side note, I'm amazed that you're still making mistakes, yet claiming that you can maintain your plugins.

Trashed.