[JusTGo]

why you preache this sound and you don't use it and it doesn't exist in resources:

precache_sound( "katana/knife_hit4.wav" );

[hgavdv]

Originally Posted by zmd94 You have to click "Get Source".

i did but i need the plugin too

it gives Error

[zmd94]

What the errors?

[hgavdv]

Plugin failed to compile! Please try contacting the author.
Welcome to the AMX Mod X 1.8.1-300 Compiler.
Copyright (c) 1997-2006 ITB CompuPhase, AMX Mod X Team

/home/forums/content/files/2/2/5/4/0/2/143441.attach(656) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(656) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(657) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(657) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(661) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(661) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(662) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(662) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(663) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(663) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(670) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(670) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(69 : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(699) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(699) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(702) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(702) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(750) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(751) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(751) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(752) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(752) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(753) : error 017: undefined symbol "MAX_PLAYERS"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(753) : error 009: invalid array size (negative or zero)
/home/forums/content/files/2/2/5/4/0/2/143441.attach(1149) : error 017: undefined symbol "client_print_color"
/home/forums/content/files/2/2/5/4/0/2/143441.attach(1149) : warning 215: expression has no effect
/home/forums/content/files/2/2/5/4/0/2/143441.attach(1149) : warning 215: expression has no effect
/home/forums/content/files/2/2/5/4/0/2/143441.attach(1149) : error 001: expected token: ";", but found ")"

Compilation aborted.
26 Errors.

[tonykaram1993]

You are using compiler version 1.8.1, in the installation instructions I clearly stated you need the latest dev build version 1.8.3

[hgavdv]

Originally Posted by tonykaram1993 You are using compiler version 1.8.1, in the installation instructions I clearly stated you need the latest dev build version 1.8.3

i Used dev build version 1.8.3 and i get new Error

[img]http://s2.************/drrhnakm1/image.png[/img]

[tonykaram1993]

Originally Posted by hgavdv i Used dev build version 1.8.3 and i get new Error [img]http://s2.************/drrhnakm1/image.png[/img]

There you go, I fixed it.
Must have uploaded the wrong version.

Tomorrow I will upload the code to github and start fixing it there.

[hgavdv]

Originally Posted by tonykaram1993 There you go, I fixed it. Must have uploaded the wrong version. Tomorrow I will upload the code to github and start fixing it there.

Waiting for you

and thanks

[hornet]

Okay, at the moment this is the brief / quick review ( mainly let's start with how to not blow up your CPU ):

• All CPU consuming forwards such as AddToFullPack, PreThink, and CmdStart should be registered only when they are in use, and unregistered when they are not.
  
• FM_Touch is a big nono . Use hamsandwich to detect touch and then like above, disable the forward when its not in use.
  
• Disable all other Touch forwards when they are not in use.
  
• You only use SetModel forward for Last Request purposes, so you should only have it registered during that time.
  
• Filter your CurWeapon event to only be triggered on knife deploy or hook Deploy with hamsandwich.
  
• To catch players text in chat you should instead register SayText message, but only when it your going to use it and then unregister it.
  
• To get the friendly fire effect in FFA, you only need to change player private data in TraceAttack, not TakeDamage aswell. You also should not need to do that in Killed forward either.
  
• You should use a multilingual file since JailBreak is popular world wide.
  
• When setting render FX on a player or other entity you should 100% be using engine module to do so instead of fakemeta.
  
• You have a stock called PlaySound() but you still use client_cmd() elsewhere.
  
• You have a macro for is_user() but you still use its defined code elsewere.
  
• You include xs but you have made your own macros for some of its functionality.
  
• You don't need to check is_user() in SetClientListening forward since you are also checking for player connected.
  
• All of your player and entity private data offsets should be defined for easy reading . example 116 instead define m_fHasPrimary.
  
• Do not hardcode string lengths or other array lengths for that matter.
  

I don't think hardcoded models, sounds or other resources should be a problem since they are part of the mod, so long as they can be changed globally. It would be customizable of course to use a config file or something, but not required.

So for now, that's just the main ones I've noticed. Further down the track we'll explore all of your other functions and systems etc.

And lastly I very highly recommend you make this compatible with 1.8.2 compiler.

[hgavdv]

/open didn't work for me